Code review comment for lp:~clint-fewbar/ubuntu/karmic/mysql-dfsg-5.1/mysql-sru-343870

Revision history for this message
Artur Rona (ari-tczew) wrote :

OK, I sent your patch to my PPA and it built fine, so I have last issues:

- debian/changelog: Description is too short, I suggest to use:

 * debian/patches/10_fix_segfaults_lp343870.dpatch:
   - Fixes race condition in libmysqlclient.
     Cherry-pick from upstream. (LP: #343870)

Please add also dot at the end of sentence in tag Description.

review: Needs Fixing

« Back to merge proposal