Code review comment for lp:~clint-fewbar/txaws/fix-s3-port
Revision history for this message
| Robert Collins (lifeless) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
35a32c5
(Get the code!)
Two things:
- only include :port if the port is not the default port for the
protocol. This (may) matter for signing with ec2 etc.
- a test or two would be massively preferred.
-Rob