Code review comment for lp:~clint-fewbar/pyjuju/no-lsb-release

+1, LGTM, with the following coding convention minor addressed.

https://codereview.appspot.com/6750055/diff/1/juju/charm/tests/test_directory.py
File juju/charm/tests/test_directory.py (right):

https://codereview.appspot.com/6750055/diff/1/juju/charm/tests/test_directory.py#newcode215
juju/charm/tests/test_directory.py:215: with
tempfile.NamedTemporaryFile(dir='/tmp') as external_file:
Use the makeFile method on our TestCase; it constructs a temporary file
as above, but also ensures it is deleted at the end of the test. This
method is used throughout our tests, so this will help with following
current coding conventions.

external_file = self.makeFile()

https://codereview.appspot.com/6750055/diff/1/juju/charm/tests/test_directory.py#newcode224
juju/charm/tests/test_directory.py:224: with
tempfile.NamedTemporaryFile(dir='/tmp') as external_file:
Ditto.

https://codereview.appspot.com/6750055/