lgtm, with these minors
https://codereview.appspot.com/6443090/diff/1/juju/charm/repository.py File juju/charm/repository.py (right):
https://codereview.appspot.com/6443090/diff/1/juju/charm/repository.py#newcode130 juju/charm/repository.py:130: host = url.split('/')[2] this would be more robust with urlparse.urlparse(url).hostname
https://codereview.appspot.com/6443090/diff/1/juju/charm/repository.py#newcode152 juju/charm/repository.py:152: host = url.split('/')[2] same with this one.
https://codereview.appspot.com/6443090/
« Back to merge proposal
lgtm, with these minors
https:/ /codereview. appspot. com/6443090/ diff/1/ juju/charm/ repository. py repository. py (right):
File juju/charm/
https:/ /codereview. appspot. com/6443090/ diff/1/ juju/charm/ repository. py#newcode130 repository. py:130: host = url.split('/')[2] urlparse( url).hostname
juju/charm/
this would be more robust with
urlparse.
https:/ /codereview. appspot. com/6443090/ diff/1/ juju/charm/ repository. py#newcode152 repository. py:152: host = url.split('/')[2]
juju/charm/
same with this one.
https:/ /codereview. appspot. com/6443090/