Code review comment for lp:~clint-fewbar/pyjuju/fix-ssl-for-charm-store

Revision history for this message
Kapil Thangavelu (hazmat) wrote :

lgtm, with these minors

https://codereview.appspot.com/6443090/diff/1/juju/charm/repository.py
File juju/charm/repository.py (right):

https://codereview.appspot.com/6443090/diff/1/juju/charm/repository.py#newcode130
juju/charm/repository.py:130: host = url.split('/')[2]
this would be more robust with
urlparse.urlparse(url).hostname

https://codereview.appspot.com/6443090/diff/1/juju/charm/repository.py#newcode152
juju/charm/repository.py:152: host = url.split('/')[2]
same with this one.

https://codereview.appspot.com/6443090/

« Back to merge proposal