Juju Charms Collection
mysql package

Code review comment for lp:~clint-fewbar/charms/precise/mysql/add-monitors

  1. Precise Pangolin (12.04)
  2. add-monitors
  3. Merge into trunk
Revision history for this message
Mark Mims (mark-mims) wrote :

discussion/recommendations:

Please move included scripts into a separate directory like
`$CHARM_DIR/lib` or `$CHARM_DIR\scripts`... only hooks belong
in the `hooks` directory. Charm readability is the goal for
our main series of charms like mysql.

We really should change the `.bash` file extensions to the more standard `.sh`...
/me thinks it's just a tad too pedantic to make a distinction between the two.
Why raise even the slightest possibility for people or editors to be confused?

« Back to merge proposal