Code review comment for lp:~claire-couchone/sahana-eden/branch

Revision history for this message
Fran Boon (flavour) wrote :

Thanks Claire,

#474 was, I think, requesting a little calendar icon next to the field which would provide a visual indicator that this was a date field which would bring up a date picker widget.
This could easily be added to the .comment for the field, although there should then be more work to make the icon clickable to bring up the widget (otherwise I can see a UX bug being reported for this)

I don't see any code to default the date of birth field.
I'm also not sure what the purpose of such would be - can you elaborate?

NB There shouldn't be any need to import datetime within this model since it has already been imported earlier in the request processing - in 00_db.py.

PS This merge is against a slightly older version of Sahana Eden so it still used Tstr(). This has now been deprecated since Web2Py has extended T() to support the common str() operations such as concatenation.

Best Wishes,
Fran.

review: Needs Fixing

« Back to merge proposal