Code review comment for lp:~cjwatson/webbrowser-app/allow-gles

Revision history for this message
Olivier Tilloy (osomon) wrote :

Thanks for that Colin.

The other change that looked dubious was in fact intentional, I should have explained it in the merge request description. qtdeclarative5-ubuntu-ui-extras-browser-plugin has been deprecated for over a year (and replaced by qtdeclarative5-ubuntu-web-plugin), this dependency was a useless leftover. And the fact that webapp-container didn’t depend on qtdeclarative5-ubuntu-ui-toolkit-plugin was obviously a mistake, although a harmless one since it pulled the dependency indirectly anyway.

review: Approve

« Back to merge proposal