lp:~cjwatson/txpkgupload/ipv4-mapped-pasv

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:~lazr-developers/txpkgupload/trunk at revision 46

William Grant: Approve (code) on 2019-07-11

Diff: 95 lines (+47/-2)

3 files modified

requirements.txt (+1/-1)
setup.py (+1/-0)
src/txpkgupload/twistedftp.py (+45/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1836059: dput via ftp to ppa.launchpad.net failure

Critical

Fix Released

Link a bug report

Related blueprints

46. By Colin Watson on 2019-07-11

Fix behaviour of PASV with IPv4-mapped addresses.

When receiving a connection to an IPv6 endpoint using an IPv4-mapped
address (possible on some IPv6 stacks), PASV can work but needs to
return a properly-encoded IPv4 address. Including the leading "::ffff:"
in the response appears to confuse connection tracking in some
firewalls.

This is a backport from a commit in
https://github.com/twisted/twisted/pull/1149, with the only changes being
minor adjustments to symbol names and using six.ensure_text rather than the
private twisted.python.compat._coercedUnicode. As before, getting the tests
backported here was unreasonably difficult, but the Twisted PR has
reasonable coverage.

45. By Colin Watson on 2019-07-09

[r=wgrant] Implement FTP extensions for IPv6.

44. By Colin Watson on 2019-07-09

Update NEWS file a bit.

43. By Colin Watson on 2018-08-22

[r=adam-collard] Upgrade to Twisted 18.4.0.

42. By Colin Watson on 2018-07-04

Switch zope.interface users from class advice to class decorators.

41. By Colin Watson on 2018-07-04

Use Python 3-style octal constants.

40. By Colin Watson on 2018-07-04

[r=wgrant] Upgrade to lazr.sshserver 0.1.8.

39. By Colin Watson on 2018-05-08

[r=wgrant] Upgrade to Twisted 17.9.0.

38. By Colin Watson on 2018-03-09

[r=verterok] Upgrade to Twisted 16.5.0.

37. By Colin Watson on 2017-02-10

Use Python 3-compatible octal constants.