lp:~cjwatson/storm/fix-py3-cextensions
Created by
Colin Watson
and last modified
- Get this branch:
- bzr branch lp:~cjwatson/storm/fix-py3-cextensions
Only
Colin Watson
can upload to this branch. If you are
Colin Watson
please log in for upload directions.
Branch merges
Propose for merging
No branches
dependent on this one.
- Kristian Glass (community): Approve
- Storm Developers: Pending requested
-
Diff: 53 lines (+11/-2)3 files modifiedNEWS (+2/-0)
storm/cextensions.c (+8/-1)
tox.ini (+1/-1)
Branch information
Recent revisions
- 532. By Colin Watson
-
Fix C version of Compile.
__call_ _(join= ) on Python 3. On Python 3, an "S" argument only takes bytes, but this parameter should
only accept text. (It still accepts either bytes or text on Python 2.)The reason this wasn't caught in tests was a little subtle. tox installs
the C extension in a virtualenv, as you might expect; but, when running the
test program, the storm package is imported from the same directory as the
test program, and so it never actually finds any C extensions. The simplest
workaround is to move the test program to a subdirectory, where no storm
package exists and so it will be properly imported from the virtualenv.
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp:storm