Merge lp:~cjwatson/phablet-tools/click-buddy-pass-framework into lp:phablet-tools

Proposed by Colin Watson
Status: Merged
Merged at revision: 260
Proposed branch: lp:~cjwatson/phablet-tools/click-buddy-pass-framework
Merge into: lp:phablet-tools
Diff against target: 35 lines (+8/-8)
1 file modified
click-buddy (+8/-8)
To merge this branch: bzr merge lp:~cjwatson/phablet-tools/click-buddy-pass-framework
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Ubuntu Phablet Team Pending
Review via email: mp+214744@code.launchpad.net

Commit message

click-buddy: Pass -f$FRAMEWORK to click chroot.

Description of the change

click-buddy needs to pass -f$FRAMEWORK to click chroot, otherwise: (a) it isn't possible to use it to build apps for the ubuntu-sdk-14.04 framework; (b) I can't change the default framework in click chroot without breaking click-buddy.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'click-buddy'
--- click-buddy 2014-02-24 22:39:42 +0000
+++ click-buddy 2014-04-08 13:04:26 +0000
@@ -155,8 +155,8 @@
155 echo "click chroot still doesn\'t support sessions and deps outside the"155 echo "click chroot still doesn\'t support sessions and deps outside the"
156 echo "default sdk were requested, you can optionally use click maint"156 echo "default sdk were requested, you can optionally use click maint"
157 echo "to install $EXTRA_DEPS by running"157 echo "to install $EXTRA_DEPS by running"
158 echo " click chroot -a$ARCH maint apt-get update"158 echo " click chroot -a$ARCH -f$FRAMEWORK maint apt-get update"
159 echo " click chroot -a$ARCH maint apt-get install $EXTRA_DEPS"159 echo " click chroot -a$ARCH -f$FRAMEWORK maint apt-get install $EXTRA_DEPS"
160 echo160 echo
161 echo "Your chroot will be unclean from then on, so if you want to"161 echo "Your chroot will be unclean from then on, so if you want to"
162 echo "guarantee clean builds the chroot would need to be recreated."162 echo "guarantee clean builds the chroot would need to be recreated."
@@ -166,14 +166,14 @@
166 fi166 fi
167 cd "$SOURCE"167 cd "$SOURCE"
168 if [ -n "$MAINTMODE" ]; then168 if [ -n "$MAINTMODE" ]; then
169 trap 'click chroot -a$ARCH maint apt-get autoremove --yes $EXTRA_DEPS' \169 trap 'click chroot -a$ARCH -f$FRAMEWORK maint apt-get autoremove --yes $EXTRA_DEPS' \
170 EXIT HUP INT TERM170 EXIT HUP INT TERM
171 click chroot -a$ARCH maint apt-get update171 click chroot -a$ARCH -f$FRAMEWORK maint apt-get update
172 click chroot -a$ARCH maint apt-get install --yes $EXTRA_DEPS172 click chroot -a$ARCH -f$FRAMEWORK maint apt-get install --yes $EXTRA_DEPS
173 fi173 fi
174 click chroot -a$ARCH run cmake $CMAKE_PARAMS174 click chroot -a$ARCH -f$FRAMEWORK run cmake $CMAKE_PARAMS
175 click chroot -a$ARCH run make175 click chroot -a$ARCH -f$FRAMEWORK run make
176 click chroot -a$ARCH run make DESTDIR=$installdir install176 click chroot -a$ARCH -f$FRAMEWORK run make DESTDIR=$installdir install
177fi177fi
178178
179if [ ! -f "$installdir/manifest.json" ]; then179if [ ! -f "$installdir/manifest.json" ]; then

Subscribers

People subscribed via source and target branches