Merge lp:~cjwatson/phablet-tools/click-buddy-pass-framework into lp:phablet-tools

Proposed by Colin Watson
Status: Merged
Merged at revision: 260
Proposed branch: lp:~cjwatson/phablet-tools/click-buddy-pass-framework
Merge into: lp:phablet-tools
Diff against target: 35 lines (+8/-8)
1 file modified
click-buddy (+8/-8)
To merge this branch: bzr merge lp:~cjwatson/phablet-tools/click-buddy-pass-framework
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Ubuntu Phablet Team Pending
Review via email: mp+214744@code.launchpad.net

Commit message

click-buddy: Pass -f$FRAMEWORK to click chroot.

Description of the change

click-buddy needs to pass -f$FRAMEWORK to click chroot, otherwise: (a) it isn't possible to use it to build apps for the ubuntu-sdk-14.04 framework; (b) I can't change the default framework in click chroot without breaking click-buddy.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'click-buddy'
2--- click-buddy 2014-02-24 22:39:42 +0000
3+++ click-buddy 2014-04-08 13:04:26 +0000
4@@ -155,8 +155,8 @@
5 echo "click chroot still doesn\'t support sessions and deps outside the"
6 echo "default sdk were requested, you can optionally use click maint"
7 echo "to install $EXTRA_DEPS by running"
8- echo " click chroot -a$ARCH maint apt-get update"
9- echo " click chroot -a$ARCH maint apt-get install $EXTRA_DEPS"
10+ echo " click chroot -a$ARCH -f$FRAMEWORK maint apt-get update"
11+ echo " click chroot -a$ARCH -f$FRAMEWORK maint apt-get install $EXTRA_DEPS"
12 echo
13 echo "Your chroot will be unclean from then on, so if you want to"
14 echo "guarantee clean builds the chroot would need to be recreated."
15@@ -166,14 +166,14 @@
16 fi
17 cd "$SOURCE"
18 if [ -n "$MAINTMODE" ]; then
19- trap 'click chroot -a$ARCH maint apt-get autoremove --yes $EXTRA_DEPS' \
20+ trap 'click chroot -a$ARCH -f$FRAMEWORK maint apt-get autoremove --yes $EXTRA_DEPS' \
21 EXIT HUP INT TERM
22- click chroot -a$ARCH maint apt-get update
23- click chroot -a$ARCH maint apt-get install --yes $EXTRA_DEPS
24+ click chroot -a$ARCH -f$FRAMEWORK maint apt-get update
25+ click chroot -a$ARCH -f$FRAMEWORK maint apt-get install --yes $EXTRA_DEPS
26 fi
27- click chroot -a$ARCH run cmake $CMAKE_PARAMS
28- click chroot -a$ARCH run make
29- click chroot -a$ARCH run make DESTDIR=$installdir install
30+ click chroot -a$ARCH -f$FRAMEWORK run cmake $CMAKE_PARAMS
31+ click chroot -a$ARCH -f$FRAMEWORK run make
32+ click chroot -a$ARCH -f$FRAMEWORK run make DESTDIR=$installdir install
33 fi
34
35 if [ ! -f "$installdir/manifest.json" ]; then

Subscribers

People subscribed via source and target branches