lp:~cjwatson/meliae/skip-dumping-large-longs
- Get this branch:
- bzr branch lp:~cjwatson/meliae/skip-dumping-large-longs
Branch merges
- John A Meinel: Approve
- Ioana Lasc (community): Approve
-
Diff: 55 lines (+24/-3)2 files modifiedmeliae/_scanner_core.c (+9/-1)
meliae/tests/test__scanner.py (+15/-2)
Related source package recipes
Branch information
Recent revisions
- 230. By Colin Watson
-
Skip dumping large longs that would require allocation.
Python long objects (spelled "int" at the Python level in Python 3) are
arbitrary-precision integers, so simply converting them to C longs using
PyLong_AsLong might overflow and raise OverflowError. (I ran into such a
case in the Launchpad test suite; I didn't track down exactly what it was,
but a Python long somewhere in memory that doesn't fit into a C long isn't
all that implausible.)Converting to long long instead (supported as of Python 2.7) makes this
situation less likely, but it's still possible, and I don't know of a way to
accurately format an arbitrary-precision integer to decimal without
allocating memory, which we try to avoid in the inner parts of the scanner.
Therefore, if the conversion overflows, just omit the value from the dump.
This is presumably reasonably tolerable since longs weren't dumped at all
before meliae 0.5. - 227. By John A Meinel
-
Now that we pass the test suite, actually declare support for multiple Python 3 versions.
- 226. By John A Meinel
-
Handle str vs bytes appropriately on Python 3
Lots of great fixes from Colin to bring in str vs bytes for values and types.
intern() type strings, since they are repeated over and over for groups of the
same object. - 223. By John A Meinel
-
Improve constant folding for Python >= 3.7
Python 3.7 is more aggressive about folding of constants, we want to still use
independent objects.
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp:meliae
