Merge ~cjwatson/lp-codeimport:charm-fix-part-name into lp-codeimport:master

Proposed by Colin Watson
Status: Merged
Approved by: Colin Watson
Approved revision: 70bea475d457ea519155222a48b72391c80269f1
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~cjwatson/lp-codeimport:charm-fix-part-name
Merge into: lp-codeimport:master
Diff against target: 31 lines (+18/-0)
1 file modified
charm/lp-codeimport/config.yaml (+18/-0)
Reviewer Review Type Date Requested Status
Guruprasad Approve
Review via email: mp+448507@code.launchpad.net

Commit message

charm: Add type/description to overridden install_sources/install_keys

Description of the change

Copied from `layer-apt/config.yaml`. `charmcraft` seems to be a bit pickier about this nowadays and is failing if we try to override just the default values.

To post a comment you must log in.
Revision history for this message
Guruprasad (lgp171188) wrote :

LGTM 👍

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/charm/lp-codeimport/config.yaml b/charm/lp-codeimport/config.yaml
index 9b38fb9..7bffb34 100644
--- a/charm/lp-codeimport/config.yaml
+++ b/charm/lp-codeimport/config.yaml
@@ -87,8 +87,26 @@ options:
87 the nrpe subordinate charm to set up /etc/rsyncd.conf properly.87 the nrpe subordinate charm to set up /etc/rsyncd.conf properly.
88 # layer-apt88 # layer-apt
89 install_sources:89 install_sources:
90 type: string
90 default: |91 default: |
91 - ppa:launchpad/ppa92 - ppa:launchpad/ppa
93 description: >
94 List of extra apt sources, per charm-helpers standard
95 format (a yaml list of strings encoded as a string). Each source
96 may be either a line that can be added directly to
97 sources.list(5), or in the form ppa:<user>/<ppa-name> for adding
98 Personal Package Archives, or a distribution component to enable.
92 install_keys:99 install_keys:
100 type: string
93 default: |101 default: |
94 - null # PPA keys securely added via Launchpad.102 - null # PPA keys securely added via Launchpad.
103 description: >
104 List of signing keys for install_sources package sources, per
105 charmhelpers standard format (a yaml list of strings encoded as
106 a string). The keys should be the full ASCII armoured GPG public
107 keys. While GPG key ids are also supported and looked up on a
108 keyserver, operators should be aware that this mechanism is
109 insecure. null can be used if a standard package signing key is
110 used that will already be installed on the machine, and for PPA
111 sources where the package signing key is securely retrieved from
112 Launchpad.

Subscribers

People subscribed via source and target branches