Merge lp:~cjwatson/lazr.restfulclient/no-py25 into lp:lazr.restfulclient

Proposed by Colin Watson
Status: Merged
Merged at revision: 174
Proposed branch: lp:~cjwatson/lazr.restfulclient/no-py25
Merge into: lp:lazr.restfulclient
Diff against target: 94 lines (+11/-33)
4 files modified
NEWS.rst (+5/-0)
src/lazr/restfulclient/_browser.py (+2/-11)
src/lazr/restfulclient/_json.py (+1/-6)
src/lazr/restfulclient/resource.py (+3/-16)
To merge this branch: bzr merge lp:~cjwatson/lazr.restfulclient/no-py25
Reviewer Review Type Date Requested Status
Cristian Gonzalez (community) Approve
Review via email: mp+396457@code.launchpad.net

Commit message

Drop support for Python < 2.6.

To post a comment you must log in.
Revision history for this message
Cristian Gonzalez (cristiangsp) wrote :

Looks good!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'NEWS.rst'
--- NEWS.rst 2020-01-27 13:29:16 +0000
+++ NEWS.rst 2021-01-18 23:11:49 +0000
@@ -2,6 +2,11 @@
2NEWS for lazr.restfulclient2NEWS for lazr.restfulclient
3===========================3===========================
44
50.14.4
6======
7
8 - Drop support for Python < 2.6.
9
50.14.3 (2020-01-27)100.14.3 (2020-01-27)
6===================11===================
712
813
=== modified file 'src/lazr/restfulclient/_browser.py'
--- src/lazr/restfulclient/_browser.py 2018-11-17 13:16:44 +0000
+++ src/lazr/restfulclient/_browser.py 2021-01-18 23:11:49 +0000
@@ -33,6 +33,8 @@
33import atexit33import atexit
34import errno34import errno
35from hashlib import md535from hashlib import md5
36from io import BytesIO
37from json import dumps
36import os38import os
37import re39import re
38import shutil40import shutil
@@ -50,17 +52,6 @@
50except ImportError:52except ImportError:
51 from httplib2 import ProxyInfo53 from httplib2 import ProxyInfo
52 proxy_info_from_environment = ProxyInfo.from_environment54 proxy_info_from_environment = ProxyInfo.from_environment
53try:
54 # Python 3 and sufficiently modern Python 2 versions.
55 from json import dumps
56except ImportError:
57 from simplejson import dumps
58
59try:
60 # Python 3.
61 from io import BytesIO
62except ImportError:
63 from cStringIO import StringIO as BytesIO
6455
65try:56try:
66 # Python 3.57 # Python 3.
6758
=== modified file 'src/lazr/restfulclient/_json.py'
--- src/lazr/restfulclient/_json.py 2012-06-04 19:54:58 +0000
+++ src/lazr/restfulclient/_json.py 2021-01-18 23:11:49 +0000
@@ -22,12 +22,7 @@
22__all__ = ['DatetimeJSONEncoder']22__all__ = ['DatetimeJSONEncoder']
2323
24import datetime24import datetime
2525from json import JSONEncoder
26try:
27 # Python 3 and sufficiently modern Python 2 versions.
28 from json import JSONEncoder
29except ImportError:
30 from simplejson import JSONEncoder
3126
3227
33class DatetimeJSONEncoder(JSONEncoder):28class DatetimeJSONEncoder(JSONEncoder):
3429
=== modified file 'src/lazr/restfulclient/resource.py'
--- src/lazr/restfulclient/resource.py 2015-04-22 20:37:26 +0000
+++ src/lazr/restfulclient/resource.py 2021-01-18 23:11:49 +0000
@@ -29,22 +29,9 @@
29 ]29 ]
3030
3131
32try:32from email.message import Message
33 from email.message import Message33from io import BytesIO
34except ImportError:34from json import dumps, loads
35 from email.Message import Message
36
37try:
38 # Python 3 and sufficiently modern Python 2 versions.
39 from json import dumps, loads
40except ImportError:
41 from simplejson import dumps, loads
42
43try:
44 # Python 3.
45 from io import BytesIO
46except ImportError:
47 from cStringIO import StringIO as BytesIO
4835
49try:36try:
50 # Python 3.37 # Python 3.

Subscribers

People subscribed via source and target branches