Merge lp:~cjwatson/lazr.restfulclient/no-py25 into lp:lazr.restfulclient

Proposed by Colin Watson
Status: Merged
Merged at revision: 174
Proposed branch: lp:~cjwatson/lazr.restfulclient/no-py25
Merge into: lp:lazr.restfulclient
Diff against target: 94 lines (+11/-33)
4 files modified
NEWS.rst (+5/-0)
src/lazr/restfulclient/_browser.py (+2/-11)
src/lazr/restfulclient/_json.py (+1/-6)
src/lazr/restfulclient/resource.py (+3/-16)
To merge this branch: bzr merge lp:~cjwatson/lazr.restfulclient/no-py25
Reviewer Review Type Date Requested Status
Cristian Gonzalez (community) Approve
Review via email: mp+396457@code.launchpad.net

Commit message

Drop support for Python < 2.6.

To post a comment you must log in.
Revision history for this message
Cristian Gonzalez (cristiangsp) wrote :

Looks good!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'NEWS.rst'
2--- NEWS.rst 2020-01-27 13:29:16 +0000
3+++ NEWS.rst 2021-01-18 23:11:49 +0000
4@@ -2,6 +2,11 @@
5 NEWS for lazr.restfulclient
6 ===========================
7
8+0.14.4
9+======
10+
11+ - Drop support for Python < 2.6.
12+
13 0.14.3 (2020-01-27)
14 ===================
15
16
17=== modified file 'src/lazr/restfulclient/_browser.py'
18--- src/lazr/restfulclient/_browser.py 2018-11-17 13:16:44 +0000
19+++ src/lazr/restfulclient/_browser.py 2021-01-18 23:11:49 +0000
20@@ -33,6 +33,8 @@
21 import atexit
22 import errno
23 from hashlib import md5
24+from io import BytesIO
25+from json import dumps
26 import os
27 import re
28 import shutil
29@@ -50,17 +52,6 @@
30 except ImportError:
31 from httplib2 import ProxyInfo
32 proxy_info_from_environment = ProxyInfo.from_environment
33-try:
34- # Python 3 and sufficiently modern Python 2 versions.
35- from json import dumps
36-except ImportError:
37- from simplejson import dumps
38-
39-try:
40- # Python 3.
41- from io import BytesIO
42-except ImportError:
43- from cStringIO import StringIO as BytesIO
44
45 try:
46 # Python 3.
47
48=== modified file 'src/lazr/restfulclient/_json.py'
49--- src/lazr/restfulclient/_json.py 2012-06-04 19:54:58 +0000
50+++ src/lazr/restfulclient/_json.py 2021-01-18 23:11:49 +0000
51@@ -22,12 +22,7 @@
52 __all__ = ['DatetimeJSONEncoder']
53
54 import datetime
55-
56-try:
57- # Python 3 and sufficiently modern Python 2 versions.
58- from json import JSONEncoder
59-except ImportError:
60- from simplejson import JSONEncoder
61+from json import JSONEncoder
62
63
64 class DatetimeJSONEncoder(JSONEncoder):
65
66=== modified file 'src/lazr/restfulclient/resource.py'
67--- src/lazr/restfulclient/resource.py 2015-04-22 20:37:26 +0000
68+++ src/lazr/restfulclient/resource.py 2021-01-18 23:11:49 +0000
69@@ -29,22 +29,9 @@
70 ]
71
72
73-try:
74- from email.message import Message
75-except ImportError:
76- from email.Message import Message
77-
78-try:
79- # Python 3 and sufficiently modern Python 2 versions.
80- from json import dumps, loads
81-except ImportError:
82- from simplejson import dumps, loads
83-
84-try:
85- # Python 3.
86- from io import BytesIO
87-except ImportError:
88- from cStringIO import StringIO as BytesIO
89+from email.message import Message
90+from io import BytesIO
91+from json import dumps, loads
92
93 try:
94 # Python 3.

Subscribers

People subscribed via source and target branches