Code review comment for ~cjwatson/lazr.delegates:src-layout

Revision history for this message
Jürgen Gmach (jugmac00) wrote (last edit ):

You need to apply the following patch...

$ git diff
diff --git a/tox.ini b/tox.ini
index 0d823c9..10d788b 100644
--- a/tox.ini
+++ b/tox.ini
@@ -42,3 +42,8 @@ commands =
 source = lazr.delegates
 omit = */docs/conf.py
 parallel = true
+
+[coverage:paths]
+source =
+ src
+ .tox/*/site-packages

otherwise - as we now test the actual packages and not the source - the executed paths will look like .tox/py38/lib/python3.8/site-packages/lazr/delegates/__init__.py and coverage combine would break.

Sorry, that goes on me for my coverage combine ambition.

review: Needs Fixing

« Back to merge proposal