Merge lp:~cjwatson/launchpadlib/isolate-doctests into lp:launchpadlib

Proposed by Colin Watson
Status: Merged
Merged at revision: 158
Proposed branch: lp:~cjwatson/launchpadlib/isolate-doctests
Merge into: lp:launchpadlib
Diff against target: 55 lines (+21/-1)
3 files modified
src/launchpadlib/NEWS.txt (+4/-0)
src/launchpadlib/__init__.py (+1/-1)
src/launchpadlib/docs/introduction.txt (+16/-0)
To merge this branch: bzr merge lp:~cjwatson/launchpadlib/isolate-doctests
Reviewer Review Type Date Requested Status
Barry Warsaw Approve
Review via email: mp+316081@code.launchpad.net

Commit message

Stop introduction.txt doctest from writing to $HOME.

To post a comment you must log in.
Revision history for this message
Barry Warsaw (barry) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/launchpadlib/NEWS.txt'
--- src/launchpadlib/NEWS.txt 2016-07-12 16:09:19 +0000
+++ src/launchpadlib/NEWS.txt 2017-02-01 09:36:51 +0000
@@ -2,6 +2,10 @@
2NEWS for launchpadlib2NEWS for launchpadlib
3=====================3=====================
44
51.10.5
6======
7- Stop introduction.txt doctest from writing to $HOME.
8
51.10.4 (2016-07-12)91.10.4 (2016-07-12)
6===================10===================
7- Fix _bad_oauth_token crash on Python 3. [bug=1471894]11- Fix _bad_oauth_token crash on Python 3. [bug=1471894]
812
=== modified file 'src/launchpadlib/__init__.py'
--- src/launchpadlib/__init__.py 2016-07-12 16:09:19 +0000
+++ src/launchpadlib/__init__.py 2017-02-01 09:36:51 +0000
@@ -14,4 +14,4 @@
14# You should have received a copy of the GNU Lesser General Public License14# You should have received a copy of the GNU Lesser General Public License
15# along with launchpadlib. If not, see <http://www.gnu.org/licenses/>.15# along with launchpadlib. If not, see <http://www.gnu.org/licenses/>.
1616
17__version__ = '1.10.4'17__version__ = '1.10.5'
1818
=== modified file 'src/launchpadlib/docs/introduction.txt'
--- src/launchpadlib/docs/introduction.txt 2016-07-12 16:08:43 +0000
+++ src/launchpadlib/docs/introduction.txt 2017-02-01 09:36:51 +0000
@@ -6,6 +6,20 @@
6services API. It is officially supported by Canonical, although third party6services API. It is officially supported by Canonical, although third party
7packages may be available to provide bindings to other programming languages.7packages may be available to provide bindings to other programming languages.
88
9Set up
10======
11
12launchpadlib writes to $HOME, so isolate ourselves.
13
14 >>> from fixtures import (
15 ... EnvironmentVariable,
16 ... TempDir,
17 ... )
18 >>> tempdir_fixture = TempDir()
19 >>> tempdir_fixture.setUp()
20 >>> home_fixture = EnvironmentVariable('HOME', tempdir_fixture.path)
21 >>> home_fixture.setUp()
22
9OAuth authentication23OAuth authentication
10====================24====================
1125
@@ -396,3 +410,5 @@
396========410========
397411
398 >>> os.remove(path)412 >>> os.remove(path)
413 >>> home_fixture.cleanUp()
414 >>> tempdir_fixture.cleanUp()

Subscribers

People subscribed via source and target branches