Code review comment for lp:~cjwatson/launchpad/virtualenv-pip

Revision history for this message
Colin Watson (cjwatson) wrote :

We may need a bit of extra care to make this work properly with deployments. At the moment we do "make build_eggs" (which also runs buildout in the old world, or builds the virtualenv in the new world), sync that out everywhere, and then run "make compile" on each deployment target. That isn't quite good enough here though, because "make compile" won't rebuild the virtualenv to account for changed paths, and in any case if we can avoid building a virtualenv on each deployment target then we wouldn't have to cope with deployments being significantly slower.

I think the best approach is probably to use something like virtualenv-tools to relocate the environment. I'm not thrilled about this, but it may be the least bad answer for now. If that doesn't work, we can probably arrange for "make compile" to check whether the virtualenv's paths are correct and rebuild it if they aren't.

« Back to merge proposal