Code review comment for lp:~cjwatson/launchpad/snap-webhooks

Revision history for this message
Celso Providelo (cprov) wrote :

Thanks, Colin.

Regarding the DB security changes, do we need to deploy them specially or are they applied for every devel revision on-the-fly ?

The new webhook payload looks complete (action, snap_url, snap_build_url, status) and useful for API operations.

Obviously I'm missing tons of important details, but the drive-by refactoring make sense and testing looks sufficient.

[]

review: Approve

« Back to merge proposal