Merge lp:~cjwatson/launchpad/snap-build-pass-series into lp:launchpad

Proposed by Colin Watson
Status: Merged
Merged at revision: 18440
Proposed branch: lp:~cjwatson/launchpad/snap-build-pass-series
Merge into: lp:launchpad
Diff against target: 54 lines (+6/-0)
2 files modified
lib/lp/snappy/model/snapbuildbehaviour.py (+1/-0)
lib/lp/snappy/tests/test_snapbuildbehaviour.py (+5/-0)
To merge this branch: bzr merge lp:~cjwatson/launchpad/snap-build-pass-series
Reviewer Review Type Date Requested Status
William Grant Approve
Review via email: mp+328050@code.launchpad.net

Commit message

Pass series name to snap builds, to make future LXD image creation easier.

Description of the change

I don't think it's absolutely required to put the series in the properties of a LXD image, but it seems like a good idea for debugging, and Stéphane's example chroot-to-LXD-image conversion script uses it.

To post a comment you must log in.
Revision history for this message
William Grant (wgrant) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'lib/lp/snappy/model/snapbuildbehaviour.py'
--- lib/lp/snappy/model/snapbuildbehaviour.py 2017-07-24 15:19:50 +0000
+++ lib/lp/snappy/model/snapbuildbehaviour.py 2017-07-25 21:49:52 +0000
@@ -96,6 +96,7 @@
96 endpoint=config.snappy.builder_proxy_auth_api_endpoint,96 endpoint=config.snappy.builder_proxy_auth_api_endpoint,
97 token=token['username']))97 token=token['username']))
98 args["name"] = build.snap.name98 args["name"] = build.snap.name
99 args["series"] = build.distro_series.name
99 args["arch_tag"] = build.distro_arch_series.architecturetag100 args["arch_tag"] = build.distro_arch_series.architecturetag
100 # XXX cjwatson 2015-08-03: Allow tools_source to be overridden at101 # XXX cjwatson 2015-08-03: Allow tools_source to be overridden at
101 # some more fine-grained level.102 # some more fine-grained level.
102103
=== modified file 'lib/lp/snappy/tests/test_snapbuildbehaviour.py'
--- lib/lp/snappy/tests/test_snapbuildbehaviour.py 2017-07-24 15:19:50 +0000
+++ lib/lp/snappy/tests/test_snapbuildbehaviour.py 2017-07-25 21:49:52 +0000
@@ -277,6 +277,7 @@
277 "name": u"test-snap",277 "name": u"test-snap",
278 "proxy_url": self.proxy_url,278 "proxy_url": self.proxy_url,
279 "revocation_endpoint": self.revocation_endpoint,279 "revocation_endpoint": self.revocation_endpoint,
280 "series": "unstable",
280 "trusted_keys": expected_trusted_keys,281 "trusted_keys": expected_trusted_keys,
281 }, args)282 }, args)
282283
@@ -299,6 +300,7 @@
299 "name": u"test-snap",300 "name": u"test-snap",
300 "proxy_url": self.proxy_url,301 "proxy_url": self.proxy_url,
301 "revocation_endpoint": self.revocation_endpoint,302 "revocation_endpoint": self.revocation_endpoint,
303 "series": "unstable",
302 "trusted_keys": expected_trusted_keys,304 "trusted_keys": expected_trusted_keys,
303 }, args)305 }, args)
304306
@@ -321,6 +323,7 @@
321 "name": u"test-snap",323 "name": u"test-snap",
322 "proxy_url": self.proxy_url,324 "proxy_url": self.proxy_url,
323 "revocation_endpoint": self.revocation_endpoint,325 "revocation_endpoint": self.revocation_endpoint,
326 "series": "unstable",
324 "trusted_keys": expected_trusted_keys,327 "trusted_keys": expected_trusted_keys,
325 }, args)328 }, args)
326329
@@ -345,6 +348,7 @@
345 "name": u"test-snap",348 "name": u"test-snap",
346 "proxy_url": self.proxy_url,349 "proxy_url": self.proxy_url,
347 "revocation_endpoint": self.revocation_endpoint,350 "revocation_endpoint": self.revocation_endpoint,
351 "series": "unstable",
348 "trusted_keys": expected_trusted_keys,352 "trusted_keys": expected_trusted_keys,
349 }, args)353 }, args)
350354
@@ -367,6 +371,7 @@
367 "name": u"test-snap",371 "name": u"test-snap",
368 "proxy_url": self.proxy_url,372 "proxy_url": self.proxy_url,
369 "revocation_endpoint": self.revocation_endpoint,373 "revocation_endpoint": self.revocation_endpoint,
374 "series": "unstable",
370 "trusted_keys": expected_trusted_keys,375 "trusted_keys": expected_trusted_keys,
371 }, args)376 }, args)
372377