Code review comment for lp:~cjwatson/launchpad/remove-data-tar-xz-version-requirement
Revision history for this message
| Colin Watson (cjwatson) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
35a32c5
(Get the code!)
On Fri, Apr 27, 2012 at 02:05:21PM -0000, Brad Crittenden wrote:
> In the test you restored, test_verifyForm
> still necessary to have the 'Pre-Depends' in the control in order for
> the upload to be accepted? Perhaps you can keep the test, though
> rename it, and remove the dependencies that are made obsolete by your
> branch.
It isn't necessary to have the Pre-Depends any more, no. I've pushed a
change that removes it. How's that?
> Once ready I'll be happy to land it for you.
>
> Normally I'd mark this as 'Approved' but this time I'm setting it to
> 'Needs fixing' as a reminder that I need to revisit it when you've
> made the change and then land it.
Thanks. I have PQM access these days, though, so all I need is for a
member of ~launchpad to set the MP status to Approved when you're happy
and then I can land it myself.