I'm going through the diff sequentially at the moment; the parts I'm ignoring are the parts that I have nothing to say about. When I get to the end I can give you a very brief formal review. :)
+ def getConfig(self):
+ """Set up a configuration object for this archive."""
+ for archive in self.distribution.all_distro_archives:
+ # We only work on the primary archive.
+ if archive.purpose == ArchivePurpose.PRIMARY:
+ return getPubConfig(archive)
+ else:
+ raise LaunchpadScriptFailure(
+ 'There is no PRIMARY archive for %s' %
+ self.options.distribution)
I'm going through the diff sequentially at the moment; the parts I'm ignoring are the parts that I have nothing to say about. When I get to the end I can give you a very brief formal review. :)
=== added file 'lib/lp/ archivepublishe r/scripts/ generate_ extra_overrides .py'
+ def getConfig(self): on.all_ distro_ archives: PRIMARY: archive) Failure( distribution)
+ """Set up a configuration object for this archive."""
+ for archive in self.distributi
+ # We only work on the primary archive.
+ if archive.purpose == ArchivePurpose.
+ return getPubConfig(
+ else:
+ raise LaunchpadScript
+ 'There is no PRIMARY archive for %s' %
+ self.options.
Why not just use self.distributi on.main_ archive?
(Also, remember to punctuate that error message!)