Launchpad itself

Code review comment for lp:~cjwatson/launchpad/queue-api-refactor-overrides

Revision history for this message

Benji York (benji) wrote on 2012-07-02:

This looks good. I like the way the data for the changes is
packaged/unpacked.

The only thing I spotted were some extra parens:

    raise QueueInconsistentStateError(
        "No rights to override from %s" % (
            binarypackage.component.name))

Since the % expression is already in parenthesis, those around
"binarypackage.component.name" are unnecessary.

review: Approve (code)