Code review comment for lp:~cjwatson/launchpad/process-accepted-bugs-job

Revision history for this message
Steve Kowalik (stevenk) wrote :

374 + bug_ids = []
375 for bug_id in bugs_fixed_line.split():
376 if not bug_id.isdigit():
377 continue
389 + bug_ids.append(int(bug_id))
390 + return bug_ids

Excuse the terrible indentation, but what about return [int(bug_id) for bug_id in bugs_fixed_line.split() if bug_id.isdigits()] instead of that block?

I'd also prefer to see the tests running under the process_accepted dbuser so we can pick up any missing permissions -- on say, public.job.

review: Approve (code)

« Back to merge proposal