Merge lp:~cjwatson/launchpad/global-bugs-search into lp:launchpad

[Colin Watson]

Export MaloneApplication.searchTasks on the webservice, and implement a global bugs feed to go with it.

MaloneApplication was very close to being a valid IHasBugs implementation, so I just adjusted things a little until it actually is one.

I had to implement a global bugs feed as well, since adding IHasBugs caused the feeds mechanism to spring into action.

[William Grant (wgrant)]

review: Approve (code)

=== modified file 'lib/lp/bugs/feed/bug.py'
--- lib/lp/bugs/feed/bug.py	2014-11-29 01:33:59 +0000
+++ lib/lp/bugs/feed/bug.py	2017-05-17 06:46:56 +0000
@@ -1,4 +1,4 @@
-# Copyright 2009 Canonical Ltd.  This software is licensed under the
+# Copyright 2009-2017 Canonical Ltd.  This software is licensed under the
 # GNU Affero General Public License version 3 (see the file LICENSE).
 
 """Bug feed (syndication) views."""
@@ -228,7 +228,10 @@
     @property
     def title(self):
         """See `IFeed`."""
-        return "Bugs in %s" % self.context.displayname
+        if IMaloneApplication.providedBy(self.context):
+            return "Launchpad bugs"
+        else:
+            return "Bugs in %s" % self.context.displayname
 
     @property
     def feed_id(self):
@@ -240,7 +243,10 @@
             datecreated = self.context.datecreated.date().isoformat()
         else:
             datecreated = '2008'
-        url_path = urlparse(self.link_alternate)[2]
+        if IMaloneApplication.providedBy(self.context):
+            url_path = ''
+        else:
+            url_path = urlparse(self.link_alternate)[2]
         id_ = 'tag:launchpad.net,%s:/%s%s' % (
             datecreated,
             self.rootsite,
 
=== modified file 'lib/lp/bugs/interfaces/malone.py'
--- lib/lp/bugs/interfaces/malone.py	2013-01-07 02:40:55 +0000
+++ lib/lp/bugs/interfaces/malone.py	2017-05-17 06:46:56 +0000
@@ -1,4 +1,4 @@
-# Copyright 2009 Canonical Ltd.  This software is licensed under the
+# Copyright 2009-2017 Canonical Ltd.  This software is licensed under the
 # GNU Affero General Public License version 3 (see the file LICENSE).
 
 """Interfaces pertaining to the launchpad Malone application."""
@@ -20,7 +20,10 @@
 from zope.interface import Attribute
 
 from lp.bugs.interfaces.bug import IBug
-from lp.bugs.interfaces.bugtarget import IBugTarget
+from lp.bugs.interfaces.bugtarget import (
+    IBugTarget,
+    IHasBugs,
+    )
 from lp.services.webapp.interfaces import ILaunchpadApplication
 
 
@@ -30,13 +33,10 @@
     ]
 
 
-class IMaloneApplication(ILaunchpadApplication):
+class IMaloneApplication(ILaunchpadApplication, IHasBugs):
     """Application root for malone."""
     export_as_webservice_collection(IBug)
 
-    def searchTasks(search_params):
-        """Search IBugTasks with the given search parameters."""
-
     @call_with(user=REQUEST_USER)
     @operation_parameters(
         bug_id=copy_field(IBug['id']),
 
=== modified file 'lib/lp/bugs/stories/feeds/xx-bug-atom.txt'
--- lib/lp/bugs/stories/feeds/xx-bug-atom.txt	2016-07-27 22:36:34 +0000
+++ lib/lp/bugs/stories/feeds/xx-bug-atom.txt	2017-05-17 06:46:56 +0000
@@ -437,6 +437,44 @@
     ...     "Published dates are not sorted.")
 
 
+== Latest bugs for any target ==
+
+This feed gets the latest bugs reported against any target.
+
+    >>> browser.open('http://feeds.launchpad.dev/bugs/latest-bugs.atom')
+    >>> validate_feed(browser.contents,
+    ...               browser.headers['content-type'], browser.url)
+    No Errors
+    >>> BSS(browser.contents).title.contents
+    [u'Launchpad bugs']
+    >>> browser.url
+    'http://feeds.launchpad.dev/bugs/latest-bugs.atom'
+
+    >>> soup = BSS(browser.contents, parseOnlyThese=SoupStrainer('id'))
+    >>> print extract_text(soup.find('id'))
+    tag:launchpad.net,2008:/bugs
+
+    >>> self_links = parse_links(browser.contents, 'self')
+    >>> for link in self_links:
+    ...     print link
+    <link rel="self" href="http://feeds.launchpad.dev/bugs/latest-bugs.atom" />
+
+    >>> entries = parse_entries(browser.contents)
+    >>> print len(entries)
+    13
+
+    >>> entry = entries[0]
+    >>> print extract_text(entry.title)
+    [15] Nonsensical bugs are useless
+    >>> print extract_text(entry.author('name')[0])
+    Foo Bar
+    >>> print extract_text(entry.author('uri')[0])
+    http://bugs.launchpad.dev/~name16
+
+    >>> assert check_entries_order(entries), (
+    ...     "Published dates are not sorted.")
+
+
 == General bug search ==
 
 This feed is the most useful of them all. Any bug search can be turned into
 
=== modified file 'lib/lp/bugs/stories/feeds/xx-bug-html.txt'
--- lib/lp/bugs/stories/feeds/xx-bug-html.txt	2016-07-27 22:36:34 +0000
+++ lib/lp/bugs/stories/feeds/xx-bug-html.txt	2017-05-17 06:46:56 +0000
@@ -146,6 +146,33 @@
     [15, 15, 12, 11, 10, 9, 9, 7, 7, 3, 3, 3]
 
 
+== Latest bugs for any target ==
+
+This feed gets the latest bugs reported against any target.
+
+    >>> browser.open('http://feeds.launchpad.dev/bugs/latest-bugs.html?'
+    ...              'show_column=bugtargetdisplayname')
+    >>> browser.title
+    'Launchpad bugs'
+    >>> browser.url
+    'http://feeds.launchpad.dev/bugs/latest-bugs.html?show_column=bugtargetdisplayname'
+
+    >>> entries = parse_entries(browser.contents)
+    >>> print len(entries)
+    27
+
+    >>> print_entry(entries[1])
+    number: 15
+    href: http://bugs.launchpad.dev/redfish/+bug/15
+    title: Nonsensical bugs are useless
+    importance: Undecided
+    status: New
+
+    >>> get_bug_numbers(entries)
+    [15, 15, 13, 12, 11, 10, 9, 9, 8, 7, 7, 5, 5, 5, 4, 3, 3, 3, 2, 2, 2, 2,
+     2, 1, 1, 1]
+
+
 == General bug search ==
 
 This feed is the most useful of them all. Any bug search can be turned into
 
=== modified file 'lib/lp/bugs/tests/test_searchtasks_webservice.py'
--- lib/lp/bugs/tests/test_searchtasks_webservice.py	2012-10-09 10:28:02 +0000
+++ lib/lp/bugs/tests/test_searchtasks_webservice.py	2017-05-17 06:46:56 +0000
@@ -1,4 +1,4 @@
-# Copyright 2009-2012 Canonical Ltd.  This software is licensed under the
+# Copyright 2009-2017 Canonical Ltd.  This software is licensed under the
 # GNU Affero General Public License version 3 (see the file LICENSE).
 
 """Webservice unit tests related to Launchpad Bugs."""
@@ -124,6 +124,29 @@
         self.assertEqual(response['total_size'], 2)
 
 
+class TestMaloneApplicationSearchTasks(TestCaseWithFactory):
+    """Test the searchTasks operation on the top-level /bugs collection."""
+
+    layer = DatabaseFunctionalLayer
+
+    def test_global_search_by_tag(self):
+        project1 = self.factory.makeProduct()
+        project2 = self.factory.makeProduct()
+        bug1 = self.factory.makeBug(target=project1, tags=["foo"])
+        self.factory.makeBug(target=project1, tags=["bar"])
+        bug3 = self.factory.makeBug(target=project2, tags=["foo"])
+        self.factory.makeBug(target=project2, tags=["baz"])
+        webservice = LaunchpadWebServiceCaller(
+            "launchpad-library", "salgado-change-anything")
+        response = webservice.named_get(
+            "/bugs", "searchTasks", api_version="devel", tags="foo").jsonBody()
+        self.assertEqual(2, response["total_size"])
+        self.assertContentEqual(
+            [bug1.id, bug3.id],
+            [int(entry["bug_link"].split("/")[-1])
+             for entry in response["entries"]])
+
+
 class TestGetBugData(TestCaseWithFactory):
     """Tests for the /bugs getBugData operation."""
 
 
=== modified file 'lib/lp/services/feeds/browser.py'
--- lib/lp/services/feeds/browser.py	2015-07-08 16:05:11 +0000
+++ lib/lp/services/feeds/browser.py	2017-05-17 06:46:56 +0000
@@ -1,4 +1,4 @@
-# Copyright 2009 Canonical Ltd.  This software is licensed under the
+# Copyright 2009-2017 Canonical Ltd.  This software is licensed under the
 # GNU Affero General Public License version 3 (see the file LICENSE).
 
 """View support classes for feeds."""
@@ -35,6 +35,7 @@
     IBugTask,
     IBugTaskSet,
     )
+from lp.bugs.interfaces.malone import IMaloneApplication
 from lp.code.interfaces.branch import IBranch
 from lp.layers import FeedsLayer
 from lp.registry.interfaces.announcement import (
@@ -121,7 +122,8 @@
             redirect = RedirectionView(target, self.request, 301)
             return redirect
 
-        # Handle the two formats of urls:
+        # Handle the three formats of urls:
+        # http://feeds.launchpad.net/bugs/latest-bugs.atom
         # http://feeds.launchpad.net/bugs/+bugs.atom?...
         # http://feeds.launchpad.net/bugs/1/bug.atom
         if name == 'bugs':
@@ -134,6 +136,8 @@
                     return getUtility(IBugTaskSet)
                 else:
                     raise Unauthorized("Bug search feed deactivated")
+            elif bug_id.startswith('latest-bugs.'):
+                return getUtility(IMaloneApplication)
             else:
                 self.request.stepstogo.consume()
                 return getUtility(IBugSet).getByNameOrID(bug_id)
@@ -209,7 +213,10 @@
 
     @property
     def title(self):
-        return 'Latest Bugs for %s' % self.context.displayname
+        if IMaloneApplication.providedBy(self.context):
+            return 'Latest Bugs'
+        else:
+            return 'Latest Bugs for %s' % self.context.displayname
 
     @property
     def href(self):
 
=== modified file 'lib/lp/systemhomes.py'
--- lib/lp/systemhomes.py	2015-07-08 16:05:11 +0000
+++ lib/lp/systemhomes.py	2017-05-17 06:46:56 +0000
@@ -1,4 +1,4 @@
-# Copyright 2009-2015 Canonical Ltd.  This software is licensed under the
+# Copyright 2009-2017 Canonical Ltd.  This software is licensed under the
 # GNU Affero General Public License version 3 (see the file LICENSE).
 
 """Content classes for the 'home pages' of the subsystems of Launchpad."""
@@ -40,6 +40,7 @@
     IPrivateMaloneApplication,
     )
 from lp.bugs.model.bug import Bug
+from lp.bugs.model.bugtarget import HasBugsBase
 from lp.code.interfaces.codehosting import (
     IBazaarApplication,
     ICodehostingApplication,
@@ -117,14 +118,18 @@
 
 
 @implementer(IMaloneApplication)
-class MaloneApplication:
+class MaloneApplication(HasBugsBase):
 
     def __init__(self):
         self.title = 'Malone: the Launchpad bug tracker'
 
-    def searchTasks(self, search_params):
-        """See `IMaloneApplication`."""
-        return getUtility(IBugTaskSet).search(search_params)
+    def _customizeSearchParams(self, search_params):
+        """See `HasBugsBase`."""
+        pass
+
+    def getBugSummaryContextWhereClause(self):
+        """See `HasBugsBase`."""
+        return True
 
     def getBugData(self, user, bug_id, related_bug=None):
         """See `IMaloneApplication`."""