Merge lp:~cjwatson/launchpad/db-livefs-keep-binary-files-interval into lp:launchpad/db-devel
Proposed by
Colin Watson
on 2019-06-12
Status: | Merged |
---|---|
Merged at revision: | 14098 |
Proposed branch: | lp:~cjwatson/launchpad/db-livefs-keep-binary-files-interval |
Merge into: | lp:launchpad/db-devel |
Diff against target: |
14 lines (+10/-0) 1 file modified
database/schema/patch-2210-04-0.sql (+10/-0) |
To merge this branch: | bzr merge lp:~cjwatson/launchpad/db-livefs-keep-binary-files-interval |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
William Grant | db | 2019-06-12 | Approve on 2019-06-12 |
Stuart Bishop | db | 2019-06-12 | Pending |
Review via email:
|
Commit message
Add LiveFS.
Description of the change
I just set the default for the new column directly here, since there are only around 400 LiveFS rows on production.
https:/
To post a comment you must log in.
Colin Watson (cjwatson) wrote : | # |
If by JSON you mean the webservice specifically, I dealt with that by only exposing a _days variant on the webservice. I did consider writing a timedelta marshaller, but for the web UI I think we want something simpler anyway.
Nullable was an oversight, but I guess you have a point; I'll see about adding that to the code branch.
interval column, fancy. Also not very roundtrippable through JSON, but hopefully not a problem.
You've left the column nullable here, though the code expects it to be NOT NULL. But it seems like it's not totally unreasonable to allow NULL to disable pruning, given it's locked down.