Code review comment for lp:~cjwatson/launchpad/db-livefs-keep-binary-files-interval

William Grant (wgrant) wrote :

interval column, fancy. Also not very roundtrippable through JSON, but hopefully not a problem.

You've left the column nullable here, though the code expects it to be NOT NULL. But it seems like it's not totally unreasonable to allow NULL to disable pruning, given it's locked down.

review: Approve (db)

« Back to merge proposal