Code review comment for lp:~cjwatson/launchpad/db-bpph-phase

Revision history for this message
Stuart Bishop (stub) wrote :

You have a huge diff as PostgreSQL 9.1.4 was used to regenerate the sampledata, but you need 9.1.6 or 9.1.7.

The DB patch is fine.

Are you sure an integer is the correct datatype, or would a floating point be better? I'm unsure if people would want to use this feature for <1% of users (even though that is significant when dealing with hundreds of thousands or millions).

review: Approve (db)

« Back to merge proposal