Code review comment for ~cjwatson/launchpad:ci-build-multi-arch-ui

Revision history for this message
Jürgen Gmach (jugmac00) wrote :

Great improvement!

Would it be possible to make the tests as expressive as the commit message?

I would love to see that we assert against literals more often.

This makes the tests easier to read and to debug, and in case a test breaks it is much easier to see at one glance what is going wrong.

review: Approve

« Back to merge proposal