Merge ~cjwatson/launchpad:fix-stormify-potemplate into launchpad:master

Proposed by Colin Watson
Status: Merged
Approved by: Colin Watson
Approved revision: c2d186531bcd4bcd51c245115cf66e991affe2ae
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~cjwatson/launchpad:fix-stormify-potemplate
Merge into: launchpad:master
Diff against target: 27 lines (+2/-3)
2 files modified
lib/lp/translations/scripts/remove_translations.py (+1/-2)
lib/lp/translations/scripts/tests/test_remove_translations.py (+1/-1)
Reviewer Review Type Date Requested Status
Ines Almeida Approve
Review via email: mp+447427@code.launchpad.net

Commit message

Fix test failures from converting POTemplate to Storm

To post a comment you must log in.
Revision history for this message
Ines Almeida (ines-almeida) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/lib/lp/translations/scripts/remove_translations.py b/lib/lp/translations/scripts/remove_translations.py
index 5864987..c042b8a 100644
--- a/lib/lp/translations/scripts/remove_translations.py
+++ b/lib/lp/translations/scripts/remove_translations.py
@@ -471,8 +471,7 @@ def remove_translations(
471 " = TranslationMessage.potmsgset"471 " = TranslationMessage.potmsgset"
472 )472 )
473 conditions.add(473 conditions.add(
474 "TranslationTemplateItem.potemplate = %s"474 "TranslationTemplateItem.potemplate = %s" % sqlvalues(potemplate)
475 % sqlvalues(potemplate.id)
476 )475 )
477476
478 if language_code is not None:477 if language_code is not None:
diff --git a/lib/lp/translations/scripts/tests/test_remove_translations.py b/lib/lp/translations/scripts/tests/test_remove_translations.py
index baf2573..15c2638 100644
--- a/lib/lp/translations/scripts/tests/test_remove_translations.py
+++ b/lib/lp/translations/scripts/tests/test_remove_translations.py
@@ -676,7 +676,7 @@ class TestRemoveTranslations(TestCase):
676 ).origin = RosettaTranslationOrigin.SCM676 ).origin = RosettaTranslationOrigin.SCM
677677
678 self._removeMessages(678 self._removeMessages(
679 potemplate=self.potemplate, origin=RosettaTranslationOrigin.SCM679 potemplate=self.potemplate.id, origin=RosettaTranslationOrigin.SCM
680 )680 )
681681
682 self._checkInvariant()682 self._checkInvariant()

Subscribers

People subscribed via source and target branches

to status/vote changes: