Merge ~cjwatson/launchpad:charm-scripts-actions into launchpad:master

[Colin Watson]

charm/launchpad-scripts: Add start-services/stop-services actions

In our legacy production deployment, we stop and start these services around certain kinds of maintenance actions, mainly database schema upgrades. The preferred way to do this sort of thing in Juju is using actions, so define a couple of suitable actions; once we deploy this to production, we'll set up an SSH trigger allowing developers to run any of an allowlist of actions on production.

[Ines Almeida (ines-almeida)]

Makes sense to me

Added a small question in the comments.
Also what's the purpose of `hookenv.action_set()`? In the docs it seems to be the value that the action returns - but we don't seem to use any return value from the actions (?). Is it mostly because as action needs to return something?

review: Approve

[Guruprasad (lgp171188)]

review: Approve

5458c60... by Colin Watson on 2023-07-03

Clarify a couple of documentation points

[Colin Watson (cjwatson)]

`hookenv.action_set` is indeed just because it's generally expected that actions return something. The arguments to that should show up in the output from `juju run-action --wait`.

diff --git a/charm/launchpad-scripts/README.md b/charm/launchpad-scripts/README.md
index ec07c92..257a0f7 100644
--- a/charm/launchpad-scripts/README.md
+++ b/charm/launchpad-scripts/README.md
@@ -8,3 +8,14 @@ You will need the following relations:
     juju relate launchpad-scripts:session-db postgresql:db
     juju relate launchpad-scripts memcached
     juju relate launchpad-scripts rabbitmq-server
+
+## Maintenance actions
+
+To stop Celery workers and `number-cruncher` (perhaps in preparation for a
+schema upgrade), run:
+
+    juju run-action --wait launchpad-scripts/leader stop-services
+
+To start them again once maintenance is complete:
+
+    juju run-action --wait launchpad-scripts/leader start-services
diff --git a/charm/launchpad-scripts/actions.yaml b/charm/launchpad-scripts/actions.yaml
 new file mode 100644
index 0000000..aa1c55c
--- /dev/null
+++ b/charm/launchpad-scripts/actions.yaml
@@ -0,0 +1,9 @@
+start-services:
+  description: Start services.  Usually run after maintenance.
+stop-services:
+  description: |
+    Stop services.  Usually run in preparation for maintenance.  (Note that
+    this does not stop services in a way that will persist across a reboot.
+    It also doesn't disable cron jobs, since those are handled by the
+    cron-control mechanism instead; see
+    lp.services.scripts.base.cronscript_enabled.)
diff --git a/charm/launchpad-scripts/actions/actions.py b/charm/launchpad-scripts/actions/actions.py
 new file mode 100755
index 0000000..67d862c
--- /dev/null
+++ b/charm/launchpad-scripts/actions/actions.py
@@ -0,0 +1,60 @@
+#! /usr/bin/python3
+# Copyright 2023 Canonical Ltd.  This software is licensed under the
+# GNU Affero General Public License version 3 (see the file LICENSE).
+
+import subprocess
+import sys
+import traceback
+from pathlib import Path
+
+sys.path.append("lib")
+
+from charms.layer import basic  # noqa: E402
+
+basic.bootstrap_charm_deps()
+basic.init_config_states()
+
+from charmhelpers.core import hookenv  # noqa: E402
+
+services = (
+    "celerybeat_launchpad.service",
+    "celeryd_launchpad_job.service",
+    "celeryd_launchpad_job_slow.service",
+    "number-cruncher.service",
+)
+
+
+def start_services():
+    for service in services:
+        hookenv.log(f"Starting {service}.")
+        subprocess.run(["systemctl", "start", service], check=True)
+    hookenv.action_set({"result": "Services started"})
+
+
+def stop_services():
+    for service in services:
+        hookenv.log(f"Stopping {service}.")
+        subprocess.run(["systemctl", "stop", service], check=True)
+    hookenv.action_set({"result": "Services stopped"})
+
+
+def main(argv):
+    action = Path(argv[0]).name
+    try:
+        if action == "start-services":
+            start_services()
+        elif action == "stop-services":
+            stop_services()
+        else:
+            hookenv.action_fail(f"Action {action} not implemented.")
+    except Exception:
+        hookenv.action_fail("Unhandled exception")
+        tb = traceback.format_exc()
+        hookenv.action_set(dict(traceback=tb))
+        hookenv.log(f"Unhandled exception in action {action}:")
+        for line in tb.splitlines():
+            hookenv.log(line)
+
+
+if __name__ == "__main__":
+    main(sys.argv)
diff --git a/charm/launchpad-scripts/actions/start-services b/charm/launchpad-scripts/actions/start-services
 new file mode 120000
index 0000000..405a394
--- /dev/null
+++ b/charm/launchpad-scripts/actions/start-services
@@ -0,0 +1 @@
+actions.py
 \ No newline at end of file
diff --git a/charm/launchpad-scripts/actions/stop-services b/charm/launchpad-scripts/actions/stop-services
 new file mode 120000
index 0000000..405a394
--- /dev/null
+++ b/charm/launchpad-scripts/actions/stop-services
@@ -0,0 +1 @@
+actions.py
 \ No newline at end of file