Launchpad itself

Code review comment for ~cjwatson/launchpad:generic-artifactory-properties

  1. Git
  2. lp:~cjwatson/launchpad
  3. generic-artifactory-properties
  4. Merge into master
Revision history for this message
Jürgen Gmach (jugmac00) wrote :

LGTM

I think it would be great to have some description of the properties in the docstring at least. Currently, it feels a bit that like we set some properties somehow and somewhere, but for unknown reasons.

I think it makes no sense to repeat the logic of the source code, but somehow give some spec, e.g. what properties are expected.

review: Approve

« Back to merge proposal