Merge ~cjwatson/launchpad:librarian-gc-log-delete-failures into launchpad:master
Proposed by
Colin Watson
Status: | Merged |
---|---|
Approved by: | Colin Watson |
Approved revision: | f88ec60e1d0f4a89ce6be88c5300f35cfa515f74 |
Merge reported by: | Otto Co-Pilot |
Merged at revision: | not available |
Proposed branch: | ~cjwatson/launchpad:librarian-gc-log-delete-failures |
Merge into: | launchpad:master |
Diff against target: |
78 lines (+33/-5) 2 files modified
lib/lp/services/librarianserver/librariangc.py (+9/-5) lib/lp/services/librarianserver/tests/test_gc.py (+24/-0) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ioana Lasc (community) | Approve | ||
Review via email: mp+414421@code.launchpad.net |
Commit message
Make librarian GC log delete failures rather than crashing
Description of the change
librarian-gc has been crashing on every run since at least the start of 2022. A debug run showed that most of the deletions it was attempting from Swift were succeeding, but occasionally one timed out. Since future runs will retry the deletion, it makes sense to log such events rather than crashing.
To post a comment you must log in.
Nice fix with good comments in unit test!