Merge ~cjwatson/launchpad:soyuz-dbenum into launchpad:master
- Git
- lp:~cjwatson/launchpad
- soyuz-dbenum
- Merge into master
Proposed by
Colin Watson
Status: | Merged |
---|---|
Approved by: | Colin Watson |
Approved revision: | 44bd842b1515e8a016fd6a57d4a3e631e55f1a22 |
Merge reported by: | Otto Co-Pilot |
Merged at revision: | not available |
Proposed branch: | ~cjwatson/launchpad:soyuz-dbenum |
Merge into: | launchpad:master |
Diff against target: |
381 lines (+56/-60) 12 files modified
lib/lp/soyuz/model/archive.py (+5/-5) lib/lp/soyuz/model/archivejob.py (+2/-2) lib/lp/soyuz/model/binarypackagerelease.py (+5/-5) lib/lp/soyuz/model/distributionjob.py (+2/-2) lib/lp/soyuz/model/distroarchseries.py (+7/-7) lib/lp/soyuz/model/files.py (+3/-4) lib/lp/soyuz/model/packagecopyjob.py (+3/-3) lib/lp/soyuz/model/packagediff.py (+3/-3) lib/lp/soyuz/model/publishing.py (+8/-8) lib/lp/soyuz/model/queue.py (+9/-14) lib/lp/soyuz/model/reporting.py (+2/-2) lib/lp/soyuz/model/sourcepackagerelease.py (+7/-5) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jürgen Gmach | Approve | ||
Review via email: mp+412042@code.launchpad.net |
Commit message
lp.soyuz: Use DBEnum rather than EnumCol
Description of the change
I dropped `unique=False` since it did nothing in Storm's SQLObject emulation anyway; in Launchpad we define constraints (unique or otherwise) in the SQL schema, not in Storm models.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1 | diff --git a/lib/lp/soyuz/model/archive.py b/lib/lp/soyuz/model/archive.py | |||
2 | index 6da89d1..fc5b9b0 100644 | |||
3 | --- a/lib/lp/soyuz/model/archive.py | |||
4 | +++ b/lib/lp/soyuz/model/archive.py | |||
5 | @@ -103,7 +103,7 @@ from lp.services.database.bulk import ( | |||
6 | 103 | from lp.services.database.constants import UTC_NOW | 103 | from lp.services.database.constants import UTC_NOW |
7 | 104 | from lp.services.database.datetimecol import UtcDateTimeCol | 104 | from lp.services.database.datetimecol import UtcDateTimeCol |
8 | 105 | from lp.services.database.decoratedresultset import DecoratedResultSet | 105 | from lp.services.database.decoratedresultset import DecoratedResultSet |
10 | 106 | from lp.services.database.enumcol import EnumCol | 106 | from lp.services.database.enumcol import DBEnum |
11 | 107 | from lp.services.database.interfaces import ( | 107 | from lp.services.database.interfaces import ( |
12 | 108 | ISlaveStore, | 108 | ISlaveStore, |
13 | 109 | IStore, | 109 | IStore, |
14 | @@ -298,11 +298,11 @@ class Archive(SQLBase): | |||
15 | 298 | distribution = ForeignKey( | 298 | distribution = ForeignKey( |
16 | 299 | foreignKey='Distribution', dbName='distribution', notNull=False) | 299 | foreignKey='Distribution', dbName='distribution', notNull=False) |
17 | 300 | 300 | ||
20 | 301 | purpose = EnumCol( | 301 | purpose = DBEnum( |
21 | 302 | dbName='purpose', unique=False, notNull=True, schema=ArchivePurpose) | 302 | name='purpose', allow_none=False, enum=ArchivePurpose) |
22 | 303 | 303 | ||
25 | 304 | status = EnumCol( | 304 | status = DBEnum( |
26 | 305 | dbName="status", unique=False, notNull=True, schema=ArchiveStatus, | 305 | name="status", allow_none=False, enum=ArchiveStatus, |
27 | 306 | default=ArchiveStatus.ACTIVE) | 306 | default=ArchiveStatus.ACTIVE) |
28 | 307 | 307 | ||
29 | 308 | _enabled = BoolCol(dbName='enabled', notNull=True, default=True) | 308 | _enabled = BoolCol(dbName='enabled', notNull=True, default=True) |
30 | diff --git a/lib/lp/soyuz/model/archivejob.py b/lib/lp/soyuz/model/archivejob.py | |||
31 | index 6aac1e6..3dcaff2 100644 | |||
32 | --- a/lib/lp/soyuz/model/archivejob.py | |||
33 | +++ b/lib/lp/soyuz/model/archivejob.py | |||
34 | @@ -18,7 +18,7 @@ from zope.interface import ( | |||
35 | 18 | ) | 18 | ) |
36 | 19 | 19 | ||
37 | 20 | from lp.services.config import config | 20 | from lp.services.config import config |
39 | 21 | from lp.services.database.enumcol import EnumCol | 21 | from lp.services.database.enumcol import DBEnum |
40 | 22 | from lp.services.database.interfaces import IMasterStore | 22 | from lp.services.database.interfaces import IMasterStore |
41 | 23 | from lp.services.database.stormbase import StormBase | 23 | from lp.services.database.stormbase import StormBase |
42 | 24 | from lp.services.job.model.job import ( | 24 | from lp.services.job.model.job import ( |
43 | @@ -54,7 +54,7 @@ class ArchiveJob(StormBase): | |||
44 | 54 | archive_id = Int(name='archive') | 54 | archive_id = Int(name='archive') |
45 | 55 | archive = Reference(archive_id, Archive.id) | 55 | archive = Reference(archive_id, Archive.id) |
46 | 56 | 56 | ||
48 | 57 | job_type = EnumCol(enum=ArchiveJobType, notNull=True) | 57 | job_type = DBEnum(enum=ArchiveJobType, allow_none=False) |
49 | 58 | 58 | ||
50 | 59 | metadata = JSON('json_data') | 59 | metadata = JSON('json_data') |
51 | 60 | 60 | ||
52 | diff --git a/lib/lp/soyuz/model/binarypackagerelease.py b/lib/lp/soyuz/model/binarypackagerelease.py | |||
53 | index 0ba1681..0421e81 100644 | |||
54 | --- a/lib/lp/soyuz/model/binarypackagerelease.py | |||
55 | +++ b/lib/lp/soyuz/model/binarypackagerelease.py | |||
56 | @@ -21,7 +21,7 @@ from zope.interface import implementer | |||
57 | 21 | 21 | ||
58 | 22 | from lp.services.database.constants import UTC_NOW | 22 | from lp.services.database.constants import UTC_NOW |
59 | 23 | from lp.services.database.datetimecol import UtcDateTimeCol | 23 | from lp.services.database.datetimecol import UtcDateTimeCol |
61 | 24 | from lp.services.database.enumcol import EnumCol | 24 | from lp.services.database.enumcol import DBEnum |
62 | 25 | from lp.services.database.sqlbase import SQLBase | 25 | from lp.services.database.sqlbase import SQLBase |
63 | 26 | from lp.services.database.sqlobject import ( | 26 | from lp.services.database.sqlobject import ( |
64 | 27 | BoolCol, | 27 | BoolCol, |
65 | @@ -59,13 +59,13 @@ class BinaryPackageRelease(SQLBase): | |||
66 | 59 | description = StringCol(dbName='description', notNull=True) | 59 | description = StringCol(dbName='description', notNull=True) |
67 | 60 | build = ForeignKey( | 60 | build = ForeignKey( |
68 | 61 | dbName='build', foreignKey='BinaryPackageBuild', notNull=True) | 61 | dbName='build', foreignKey='BinaryPackageBuild', notNull=True) |
71 | 62 | binpackageformat = EnumCol(dbName='binpackageformat', notNull=True, | 62 | binpackageformat = DBEnum(name='binpackageformat', allow_none=False, |
72 | 63 | schema=BinaryPackageFormat) | 63 | enum=BinaryPackageFormat) |
73 | 64 | component = ForeignKey(dbName='component', foreignKey='Component', | 64 | component = ForeignKey(dbName='component', foreignKey='Component', |
74 | 65 | notNull=True) | 65 | notNull=True) |
75 | 66 | section = ForeignKey(dbName='section', foreignKey='Section', notNull=True) | 66 | section = ForeignKey(dbName='section', foreignKey='Section', notNull=True) |
78 | 67 | priority = EnumCol(dbName='priority', notNull=True, | 67 | priority = DBEnum(name='priority', allow_none=False, |
79 | 68 | schema=PackagePublishingPriority) | 68 | enum=PackagePublishingPriority) |
80 | 69 | shlibdeps = StringCol(dbName='shlibdeps') | 69 | shlibdeps = StringCol(dbName='shlibdeps') |
81 | 70 | depends = StringCol(dbName='depends') | 70 | depends = StringCol(dbName='depends') |
82 | 71 | recommends = StringCol(dbName='recommends') | 71 | recommends = StringCol(dbName='recommends') |
83 | diff --git a/lib/lp/soyuz/model/distributionjob.py b/lib/lp/soyuz/model/distributionjob.py | |||
84 | index 91c4571..2fb9da3 100644 | |||
85 | --- a/lib/lp/soyuz/model/distributionjob.py | |||
86 | +++ b/lib/lp/soyuz/model/distributionjob.py | |||
87 | @@ -18,7 +18,7 @@ from zope.interface import implementer | |||
88 | 18 | from lp.app.errors import NotFoundError | 18 | from lp.app.errors import NotFoundError |
89 | 19 | from lp.registry.model.distribution import Distribution | 19 | from lp.registry.model.distribution import Distribution |
90 | 20 | from lp.registry.model.distroseries import DistroSeries | 20 | from lp.registry.model.distroseries import DistroSeries |
92 | 21 | from lp.services.database.enumcol import EnumCol | 21 | from lp.services.database.enumcol import DBEnum |
93 | 22 | from lp.services.database.interfaces import IStore | 22 | from lp.services.database.interfaces import IStore |
94 | 23 | from lp.services.database.stormbase import StormBase | 23 | from lp.services.database.stormbase import StormBase |
95 | 24 | from lp.services.job.model.job import ( | 24 | from lp.services.job.model.job import ( |
96 | @@ -49,7 +49,7 @@ class DistributionJob(StormBase): | |||
97 | 49 | distroseries_id = Int(name='distroseries') | 49 | distroseries_id = Int(name='distroseries') |
98 | 50 | distroseries = Reference(distroseries_id, DistroSeries.id) | 50 | distroseries = Reference(distroseries_id, DistroSeries.id) |
99 | 51 | 51 | ||
101 | 52 | job_type = EnumCol(enum=DistributionJobType, notNull=True) | 52 | job_type = DBEnum(enum=DistributionJobType, allow_none=False) |
102 | 53 | 53 | ||
103 | 54 | metadata = JSON('json_data') | 54 | metadata = JSON('json_data') |
104 | 55 | 55 | ||
105 | diff --git a/lib/lp/soyuz/model/distroarchseries.py b/lib/lp/soyuz/model/distroarchseries.py | |||
106 | index e8eef7a..32e6525 100644 | |||
107 | --- a/lib/lp/soyuz/model/distroarchseries.py | |||
108 | +++ b/lib/lp/soyuz/model/distroarchseries.py | |||
109 | @@ -25,7 +25,7 @@ from lp.registry.interfaces.person import validate_public_person | |||
110 | 25 | from lp.registry.interfaces.pocket import PackagePublishingPocket | 25 | from lp.registry.interfaces.pocket import PackagePublishingPocket |
111 | 26 | from lp.services.database.constants import DEFAULT | 26 | from lp.services.database.constants import DEFAULT |
112 | 27 | from lp.services.database.decoratedresultset import DecoratedResultSet | 27 | from lp.services.database.decoratedresultset import DecoratedResultSet |
114 | 28 | from lp.services.database.enumcol import EnumCol | 28 | from lp.services.database.enumcol import DBEnum |
115 | 29 | from lp.services.database.interfaces import IStore | 29 | from lp.services.database.interfaces import IStore |
116 | 30 | from lp.services.database.sqlbase import SQLBase | 30 | from lp.services.database.sqlbase import SQLBase |
117 | 31 | from lp.services.database.sqlobject import ( | 31 | from lp.services.database.sqlobject import ( |
118 | @@ -380,12 +380,12 @@ class PocketChroot(SQLBase): | |||
119 | 380 | distroarchseries = ForeignKey( | 380 | distroarchseries = ForeignKey( |
120 | 381 | dbName='distroarchseries', foreignKey='DistroArchSeries', notNull=True) | 381 | dbName='distroarchseries', foreignKey='DistroArchSeries', notNull=True) |
121 | 382 | 382 | ||
125 | 383 | pocket = EnumCol( | 383 | pocket = DBEnum( |
126 | 384 | schema=PackagePublishingPocket, | 384 | enum=PackagePublishingPocket, |
127 | 385 | default=PackagePublishingPocket.RELEASE, notNull=True) | 385 | default=PackagePublishingPocket.RELEASE, allow_none=False) |
128 | 386 | 386 | ||
129 | 387 | chroot = ForeignKey(dbName='chroot', foreignKey='LibraryFileAlias') | 387 | chroot = ForeignKey(dbName='chroot', foreignKey='LibraryFileAlias') |
130 | 388 | 388 | ||
134 | 389 | image_type = EnumCol( | 389 | image_type = DBEnum( |
135 | 390 | schema=BuildBaseImageType, default=BuildBaseImageType.CHROOT, | 390 | enum=BuildBaseImageType, default=BuildBaseImageType.CHROOT, |
136 | 391 | notNull=True) | 391 | allow_none=False) |
137 | diff --git a/lib/lp/soyuz/model/files.py b/lib/lp/soyuz/model/files.py | |||
138 | index c14b7cc..3c77c36 100644 | |||
139 | --- a/lib/lp/soyuz/model/files.py | |||
140 | +++ b/lib/lp/soyuz/model/files.py | |||
141 | @@ -10,7 +10,7 @@ __all__ = [ | |||
142 | 10 | from zope.interface import implementer | 10 | from zope.interface import implementer |
143 | 11 | 11 | ||
144 | 12 | from lp.registry.interfaces.sourcepackage import SourcePackageFileType | 12 | from lp.registry.interfaces.sourcepackage import SourcePackageFileType |
146 | 13 | from lp.services.database.enumcol import EnumCol | 13 | from lp.services.database.enumcol import DBEnum |
147 | 14 | from lp.services.database.sqlbase import SQLBase | 14 | from lp.services.database.sqlbase import SQLBase |
148 | 15 | from lp.services.database.sqlobject import ForeignKey | 15 | from lp.services.database.sqlobject import ForeignKey |
149 | 16 | from lp.soyuz.enums import BinaryPackageFileType | 16 | from lp.soyuz.enums import BinaryPackageFileType |
150 | @@ -30,8 +30,7 @@ class BinaryPackageFile(SQLBase): | |||
151 | 30 | notNull=True) | 30 | notNull=True) |
152 | 31 | libraryfile = ForeignKey(dbName='libraryfile', | 31 | libraryfile = ForeignKey(dbName='libraryfile', |
153 | 32 | foreignKey='LibraryFileAlias', notNull=True) | 32 | foreignKey='LibraryFileAlias', notNull=True) |
156 | 33 | filetype = EnumCol(dbName='filetype', | 33 | filetype = DBEnum(name='filetype', enum=BinaryPackageFileType) |
155 | 34 | schema=BinaryPackageFileType) | ||
157 | 35 | 34 | ||
158 | 36 | 35 | ||
159 | 37 | class SourceFileMixin: | 36 | class SourceFileMixin: |
160 | @@ -55,4 +54,4 @@ class SourcePackageReleaseFile(SourceFileMixin, SQLBase): | |||
161 | 55 | dbName='sourcepackagerelease') | 54 | dbName='sourcepackagerelease') |
162 | 56 | libraryfile = ForeignKey(foreignKey='LibraryFileAlias', | 55 | libraryfile = ForeignKey(foreignKey='LibraryFileAlias', |
163 | 57 | dbName='libraryfile') | 56 | dbName='libraryfile') |
165 | 58 | filetype = EnumCol(schema=SourcePackageFileType) | 57 | filetype = DBEnum(enum=SourcePackageFileType) |
166 | diff --git a/lib/lp/soyuz/model/packagecopyjob.py b/lib/lp/soyuz/model/packagecopyjob.py | |||
167 | index f9bea8b..f3a91a8 100644 | |||
168 | --- a/lib/lp/soyuz/model/packagecopyjob.py | |||
169 | +++ b/lib/lp/soyuz/model/packagecopyjob.py | |||
170 | @@ -45,7 +45,7 @@ from lp.registry.model.distroseries import DistroSeries | |||
171 | 45 | from lp.services.config import config | 45 | from lp.services.config import config |
172 | 46 | from lp.services.database import bulk | 46 | from lp.services.database import bulk |
173 | 47 | from lp.services.database.decoratedresultset import DecoratedResultSet | 47 | from lp.services.database.decoratedresultset import DecoratedResultSet |
175 | 48 | from lp.services.database.enumcol import EnumCol | 48 | from lp.services.database.enumcol import DBEnum |
176 | 49 | from lp.services.database.interfaces import ( | 49 | from lp.services.database.interfaces import ( |
177 | 50 | IMasterStore, | 50 | IMasterStore, |
178 | 51 | IStore, | 51 | IStore, |
179 | @@ -108,9 +108,9 @@ class PackageCopyJob(StormBase): | |||
180 | 108 | target_distroseries = Reference(target_distroseries_id, DistroSeries.id) | 108 | target_distroseries = Reference(target_distroseries_id, DistroSeries.id) |
181 | 109 | 109 | ||
182 | 110 | package_name = Unicode('package_name') | 110 | package_name = Unicode('package_name') |
184 | 111 | copy_policy = EnumCol(enum=PackageCopyPolicy) | 111 | copy_policy = DBEnum(enum=PackageCopyPolicy) |
185 | 112 | 112 | ||
187 | 113 | job_type = EnumCol(enum=PackageCopyJobType, notNull=True) | 113 | job_type = DBEnum(enum=PackageCopyJobType, allow_none=False) |
188 | 114 | 114 | ||
189 | 115 | metadata = JSON('json_data') | 115 | metadata = JSON('json_data') |
190 | 116 | 116 | ||
191 | diff --git a/lib/lp/soyuz/model/packagediff.py b/lib/lp/soyuz/model/packagediff.py | |||
192 | index 5b16c29..c9ad7a3 100644 | |||
193 | --- a/lib/lp/soyuz/model/packagediff.py | |||
194 | +++ b/lib/lp/soyuz/model/packagediff.py | |||
195 | @@ -26,7 +26,7 @@ from lp.services.database.bulk import load | |||
196 | 26 | from lp.services.database.constants import UTC_NOW | 26 | from lp.services.database.constants import UTC_NOW |
197 | 27 | from lp.services.database.datetimecol import UtcDateTimeCol | 27 | from lp.services.database.datetimecol import UtcDateTimeCol |
198 | 28 | from lp.services.database.decoratedresultset import DecoratedResultSet | 28 | from lp.services.database.decoratedresultset import DecoratedResultSet |
200 | 29 | from lp.services.database.enumcol import EnumCol | 29 | from lp.services.database.enumcol import DBEnum |
201 | 30 | from lp.services.database.interfaces import IStore | 30 | from lp.services.database.interfaces import IStore |
202 | 31 | from lp.services.database.sqlbase import ( | 31 | from lp.services.database.sqlbase import ( |
203 | 32 | SQLBase, | 32 | SQLBase, |
204 | @@ -141,8 +141,8 @@ class PackageDiff(SQLBase): | |||
205 | 141 | dbName="diff_content", foreignKey='LibraryFileAlias', | 141 | dbName="diff_content", foreignKey='LibraryFileAlias', |
206 | 142 | notNull=False, default=None) | 142 | notNull=False, default=None) |
207 | 143 | 143 | ||
210 | 144 | status = EnumCol( | 144 | status = DBEnum( |
211 | 145 | dbName='status', notNull=True, schema=PackageDiffStatus, | 145 | name='status', allow_none=False, enum=PackageDiffStatus, |
212 | 146 | default=PackageDiffStatus.PENDING) | 146 | default=PackageDiffStatus.PENDING) |
213 | 147 | 147 | ||
214 | 148 | @property | 148 | @property |
215 | diff --git a/lib/lp/soyuz/model/publishing.py b/lib/lp/soyuz/model/publishing.py | |||
216 | index ff4d2bb..442ca59 100644 | |||
217 | --- a/lib/lp/soyuz/model/publishing.py | |||
218 | +++ b/lib/lp/soyuz/model/publishing.py | |||
219 | @@ -50,7 +50,7 @@ from lp.services.database import bulk | |||
220 | 50 | from lp.services.database.constants import UTC_NOW | 50 | from lp.services.database.constants import UTC_NOW |
221 | 51 | from lp.services.database.datetimecol import UtcDateTimeCol | 51 | from lp.services.database.datetimecol import UtcDateTimeCol |
222 | 52 | from lp.services.database.decoratedresultset import DecoratedResultSet | 52 | from lp.services.database.decoratedresultset import DecoratedResultSet |
224 | 53 | from lp.services.database.enumcol import EnumCol | 53 | from lp.services.database.enumcol import DBEnum |
225 | 54 | from lp.services.database.interfaces import ( | 54 | from lp.services.database.interfaces import ( |
226 | 55 | IMasterStore, | 55 | IMasterStore, |
227 | 56 | IStore, | 56 | IStore, |
228 | @@ -245,7 +245,7 @@ class SourcePackagePublishingHistory(SQLBase, ArchivePublisherBase): | |||
229 | 245 | distroseries = ForeignKey(foreignKey='DistroSeries', dbName='distroseries') | 245 | distroseries = ForeignKey(foreignKey='DistroSeries', dbName='distroseries') |
230 | 246 | component = ForeignKey(foreignKey='Component', dbName='component') | 246 | component = ForeignKey(foreignKey='Component', dbName='component') |
231 | 247 | section = ForeignKey(foreignKey='Section', dbName='section') | 247 | section = ForeignKey(foreignKey='Section', dbName='section') |
233 | 248 | status = EnumCol(schema=PackagePublishingStatus) | 248 | status = DBEnum(enum=PackagePublishingStatus) |
234 | 249 | scheduleddeletiondate = UtcDateTimeCol(default=None) | 249 | scheduleddeletiondate = UtcDateTimeCol(default=None) |
235 | 250 | datepublished = UtcDateTimeCol(default=None) | 250 | datepublished = UtcDateTimeCol(default=None) |
236 | 251 | datecreated = UtcDateTimeCol(default=UTC_NOW) | 251 | datecreated = UtcDateTimeCol(default=UTC_NOW) |
237 | @@ -254,9 +254,9 @@ class SourcePackagePublishingHistory(SQLBase, ArchivePublisherBase): | |||
238 | 254 | dbName='supersededby', default=None) | 254 | dbName='supersededby', default=None) |
239 | 255 | datemadepending = UtcDateTimeCol(default=None) | 255 | datemadepending = UtcDateTimeCol(default=None) |
240 | 256 | dateremoved = UtcDateTimeCol(default=None) | 256 | dateremoved = UtcDateTimeCol(default=None) |
244 | 257 | pocket = EnumCol(dbName='pocket', schema=PackagePublishingPocket, | 257 | pocket = DBEnum(name='pocket', enum=PackagePublishingPocket, |
245 | 258 | default=PackagePublishingPocket.RELEASE, | 258 | default=PackagePublishingPocket.RELEASE, |
246 | 259 | notNull=True) | 259 | allow_none=False) |
247 | 260 | archive = ForeignKey(dbName="archive", foreignKey="Archive", notNull=True) | 260 | archive = ForeignKey(dbName="archive", foreignKey="Archive", notNull=True) |
248 | 261 | copied_from_archive = ForeignKey( | 261 | copied_from_archive = ForeignKey( |
249 | 262 | dbName="copied_from_archive", foreignKey="Archive", notNull=False) | 262 | dbName="copied_from_archive", foreignKey="Archive", notNull=False) |
250 | @@ -643,8 +643,8 @@ class BinaryPackagePublishingHistory(SQLBase, ArchivePublisherBase): | |||
251 | 643 | foreignKey='DistroArchSeries', dbName='distroarchseries') | 643 | foreignKey='DistroArchSeries', dbName='distroarchseries') |
252 | 644 | component = ForeignKey(foreignKey='Component', dbName='component') | 644 | component = ForeignKey(foreignKey='Component', dbName='component') |
253 | 645 | section = ForeignKey(foreignKey='Section', dbName='section') | 645 | section = ForeignKey(foreignKey='Section', dbName='section') |
256 | 646 | priority = EnumCol(dbName='priority', schema=PackagePublishingPriority) | 646 | priority = DBEnum(name='priority', enum=PackagePublishingPriority) |
257 | 647 | status = EnumCol(dbName='status', schema=PackagePublishingStatus) | 647 | status = DBEnum(name='status', enum=PackagePublishingStatus) |
258 | 648 | phased_update_percentage = IntCol( | 648 | phased_update_percentage = IntCol( |
259 | 649 | dbName='phased_update_percentage', notNull=False, default=None) | 649 | dbName='phased_update_percentage', notNull=False, default=None) |
260 | 650 | scheduleddeletiondate = UtcDateTimeCol(default=None) | 650 | scheduleddeletiondate = UtcDateTimeCol(default=None) |
261 | @@ -658,7 +658,7 @@ class BinaryPackagePublishingHistory(SQLBase, ArchivePublisherBase): | |||
262 | 658 | foreignKey='BinaryPackageBuild', dbName='supersededby', default=None) | 658 | foreignKey='BinaryPackageBuild', dbName='supersededby', default=None) |
263 | 659 | datemadepending = UtcDateTimeCol(default=None) | 659 | datemadepending = UtcDateTimeCol(default=None) |
264 | 660 | dateremoved = UtcDateTimeCol(default=None) | 660 | dateremoved = UtcDateTimeCol(default=None) |
266 | 661 | pocket = EnumCol(dbName='pocket', schema=PackagePublishingPocket) | 661 | pocket = DBEnum(name='pocket', enum=PackagePublishingPocket) |
267 | 662 | archive = ForeignKey(dbName="archive", foreignKey="Archive", notNull=True) | 662 | archive = ForeignKey(dbName="archive", foreignKey="Archive", notNull=True) |
268 | 663 | copied_from_archive = ForeignKey( | 663 | copied_from_archive = ForeignKey( |
269 | 664 | dbName="copied_from_archive", foreignKey="Archive", notNull=False) | 664 | dbName="copied_from_archive", foreignKey="Archive", notNull=False) |
270 | diff --git a/lib/lp/soyuz/model/queue.py b/lib/lp/soyuz/model/queue.py | |||
271 | index c5ff4f0..314dc74 100644 | |||
272 | --- a/lib/lp/soyuz/model/queue.py | |||
273 | +++ b/lib/lp/soyuz/model/queue.py | |||
274 | @@ -52,10 +52,7 @@ from lp.services.database.constants import ( | |||
275 | 52 | ) | 52 | ) |
276 | 53 | from lp.services.database.datetimecol import UtcDateTimeCol | 53 | from lp.services.database.datetimecol import UtcDateTimeCol |
277 | 54 | from lp.services.database.decoratedresultset import DecoratedResultSet | 54 | from lp.services.database.decoratedresultset import DecoratedResultSet |
282 | 55 | from lp.services.database.enumcol import ( | 55 | from lp.services.database.enumcol import DBEnum |
279 | 56 | DBEnum, | ||
280 | 57 | EnumCol, | ||
281 | 58 | ) | ||
283 | 59 | from lp.services.database.interfaces import ( | 56 | from lp.services.database.interfaces import ( |
284 | 60 | IMasterStore, | 57 | IMasterStore, |
285 | 61 | IStore, | 58 | IStore, |
286 | @@ -169,18 +166,17 @@ class PackageUpload(SQLBase): | |||
287 | 169 | 166 | ||
288 | 170 | _defaultOrder = ['id'] | 167 | _defaultOrder = ['id'] |
289 | 171 | 168 | ||
294 | 172 | status = EnumCol( | 169 | status = DBEnum( |
295 | 173 | dbName='status', unique=False, notNull=True, | 170 | name='status', allow_none=False, |
296 | 174 | default=PackageUploadStatus.NEW, schema=PackageUploadStatus, | 171 | default=PackageUploadStatus.NEW, enum=PackageUploadStatus, |
297 | 175 | storm_validator=validate_status) | 172 | validator=validate_status) |
298 | 176 | 173 | ||
299 | 177 | date_created = UtcDateTimeCol(notNull=False, default=UTC_NOW) | 174 | date_created = UtcDateTimeCol(notNull=False, default=UTC_NOW) |
300 | 178 | 175 | ||
301 | 179 | distroseries = ForeignKey(dbName="distroseries", foreignKey='DistroSeries') | 176 | distroseries = ForeignKey(dbName="distroseries", foreignKey='DistroSeries') |
302 | 180 | 177 | ||
306 | 181 | pocket = EnumCol( | 178 | pocket = DBEnum( |
307 | 182 | dbName='pocket', unique=False, notNull=True, | 179 | name='pocket', allow_none=False, enum=PackagePublishingPocket) |
305 | 183 | schema=PackagePublishingPocket) | ||
308 | 184 | 180 | ||
309 | 185 | changes_file_id = Int(name='changesfile') | 181 | changes_file_id = Int(name='changesfile') |
310 | 186 | changesfile = Reference(changes_file_id, 'LibraryFileAlias.id') | 182 | changesfile = Reference(changes_file_id, 'LibraryFileAlias.id') |
311 | @@ -1421,9 +1417,8 @@ class PackageUploadCustom(SQLBase): | |||
312 | 1421 | packageupload = ForeignKey( | 1417 | packageupload = ForeignKey( |
313 | 1422 | dbName='packageupload', foreignKey='PackageUpload') | 1418 | dbName='packageupload', foreignKey='PackageUpload') |
314 | 1423 | 1419 | ||
318 | 1424 | customformat = EnumCol( | 1420 | customformat = DBEnum( |
319 | 1425 | dbName='customformat', unique=False, notNull=True, | 1421 | name='customformat', allow_none=False, enum=PackageUploadCustomFormat) |
317 | 1426 | schema=PackageUploadCustomFormat) | ||
320 | 1427 | 1422 | ||
321 | 1428 | libraryfilealias = ForeignKey( | 1423 | libraryfilealias = ForeignKey( |
322 | 1429 | dbName='libraryfilealias', foreignKey="LibraryFileAlias", notNull=True) | 1424 | dbName='libraryfilealias', foreignKey="LibraryFileAlias", notNull=True) |
323 | diff --git a/lib/lp/soyuz/model/reporting.py b/lib/lp/soyuz/model/reporting.py | |||
324 | index f72b5b4..64211b3 100644 | |||
325 | --- a/lib/lp/soyuz/model/reporting.py | |||
326 | +++ b/lib/lp/soyuz/model/reporting.py | |||
327 | @@ -14,7 +14,7 @@ from storm.locals import ( | |||
328 | 14 | from storm.properties import DateTime | 14 | from storm.properties import DateTime |
329 | 15 | from zope.interface import implementer | 15 | from zope.interface import implementer |
330 | 16 | 16 | ||
332 | 17 | from lp.services.database.enumcol import EnumCol | 17 | from lp.services.database.enumcol import DBEnum |
333 | 18 | from lp.soyuz.enums import ArchivePurpose | 18 | from lp.soyuz.enums import ArchivePurpose |
334 | 19 | from lp.soyuz.interfaces.reporting import ( | 19 | from lp.soyuz.interfaces.reporting import ( |
335 | 20 | ILatestPersonSourcePackageReleaseCache, | 20 | ILatestPersonSourcePackageReleaseCache, |
336 | @@ -38,7 +38,7 @@ class LatestPersonSourcePackageReleaseCache(Storm): | |||
337 | 38 | maintainer_id = Int(name='maintainer') | 38 | maintainer_id = Int(name='maintainer') |
338 | 39 | upload_archive_id = Int(name='upload_archive') | 39 | upload_archive_id = Int(name='upload_archive') |
339 | 40 | upload_archive = Reference(upload_archive_id, 'Archive.id') | 40 | upload_archive = Reference(upload_archive_id, 'Archive.id') |
341 | 41 | archive_purpose = EnumCol(schema=ArchivePurpose) | 41 | archive_purpose = DBEnum(enum=ArchivePurpose) |
342 | 42 | upload_distroseries_id = Int(name='upload_distroseries') | 42 | upload_distroseries_id = Int(name='upload_distroseries') |
343 | 43 | upload_distroseries = Reference(upload_distroseries_id, 'DistroSeries.id') | 43 | upload_distroseries = Reference(upload_distroseries_id, 'DistroSeries.id') |
344 | 44 | sourcepackagename_id = Int(name='sourcepackagename') | 44 | sourcepackagename_id = Int(name='sourcepackagename') |
345 | diff --git a/lib/lp/soyuz/model/sourcepackagerelease.py b/lib/lp/soyuz/model/sourcepackagerelease.py | |||
346 | index 2615be9..65c3479 100644 | |||
347 | --- a/lib/lp/soyuz/model/sourcepackagerelease.py | |||
348 | +++ b/lib/lp/soyuz/model/sourcepackagerelease.py | |||
349 | @@ -42,7 +42,7 @@ from lp.registry.interfaces.sourcepackage import ( | |||
350 | 42 | from lp.services.database.constants import UTC_NOW | 42 | from lp.services.database.constants import UTC_NOW |
351 | 43 | from lp.services.database.datetimecol import UtcDateTimeCol | 43 | from lp.services.database.datetimecol import UtcDateTimeCol |
352 | 44 | from lp.services.database.decoratedresultset import DecoratedResultSet | 44 | from lp.services.database.decoratedresultset import DecoratedResultSet |
354 | 45 | from lp.services.database.enumcol import EnumCol | 45 | from lp.services.database.enumcol import DBEnum |
355 | 46 | from lp.services.database.sqlbase import ( | 46 | from lp.services.database.sqlbase import ( |
356 | 47 | cursor, | 47 | cursor, |
357 | 48 | SQLBase, | 48 | SQLBase, |
358 | @@ -92,8 +92,9 @@ class SourcePackageRelease(SQLBase): | |||
359 | 92 | signing_key_owner_id = Int(name="signing_key_owner") | 92 | signing_key_owner_id = Int(name="signing_key_owner") |
360 | 93 | signing_key_owner = Reference(signing_key_owner_id, 'Person.id') | 93 | signing_key_owner = Reference(signing_key_owner_id, 'Person.id') |
361 | 94 | signing_key_fingerprint = Unicode() | 94 | signing_key_fingerprint = Unicode() |
364 | 95 | urgency = EnumCol(dbName='urgency', schema=SourcePackageUrgency, | 95 | urgency = DBEnum( |
365 | 96 | default=SourcePackageUrgency.LOW, notNull=True) | 96 | name='urgency', enum=SourcePackageUrgency, |
366 | 97 | default=SourcePackageUrgency.LOW, allow_none=False) | ||
367 | 97 | dateuploaded = UtcDateTimeCol(dbName='dateuploaded', notNull=True, | 98 | dateuploaded = UtcDateTimeCol(dbName='dateuploaded', notNull=True, |
368 | 98 | default=UTC_NOW) | 99 | default=UTC_NOW) |
369 | 99 | dsc = StringCol(dbName='dsc') | 100 | dsc = StringCol(dbName='dsc') |
370 | @@ -107,8 +108,9 @@ class SourcePackageRelease(SQLBase): | |||
371 | 107 | build_conflicts_indep = StringCol(dbName='build_conflicts_indep') | 108 | build_conflicts_indep = StringCol(dbName='build_conflicts_indep') |
372 | 108 | architecturehintlist = StringCol(dbName='architecturehintlist') | 109 | architecturehintlist = StringCol(dbName='architecturehintlist') |
373 | 109 | homepage = StringCol(dbName='homepage') | 110 | homepage = StringCol(dbName='homepage') |
376 | 110 | format = EnumCol(dbName='format', schema=SourcePackageType, | 111 | format = DBEnum( |
377 | 111 | default=SourcePackageType.DPKG, notNull=True) | 112 | name='format', enum=SourcePackageType, |
378 | 113 | default=SourcePackageType.DPKG, allow_none=False) | ||
379 | 112 | upload_distroseries = ForeignKey(foreignKey='DistroSeries', | 114 | upload_distroseries = ForeignKey(foreignKey='DistroSeries', |
380 | 113 | dbName='upload_distroseries') | 115 | dbName='upload_distroseries') |
381 | 114 | upload_archive = ForeignKey( | 116 | upload_archive = ForeignKey( |
LGTM