Merge ~cjwatson/launchpad:flake8-line-length into launchpad:master

Proposed by Colin Watson
Status: Merged
Approved by: Colin Watson
Approved revision: 98d05f79d5525bd68170a061f2f8686dfd9a7860
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~cjwatson/launchpad:flake8-line-length
Merge into: launchpad:master
Diff against target: 712 lines (+187/-159)
25 files modified
doc/conf.py (+12/-9)
lib/lp/app/validators/email.py (+1/-0)
lib/lp/app/validators/tests/test_validation.py (+2/-1)
lib/lp/app/widgets/date.py (+2/-0)
lib/lp/archivepublisher/customupload.py (+3/-1)
lib/lp/archivepublisher/tests/test_signing.py (+2/-1)
lib/lp/archiveuploader/tests/test_tagfiles.py (+5/-5)
lib/lp/code/mail/tests/test_codehandler.py (+2/-1)
lib/lp/code/mail/tests/test_codeimport.py (+2/-1)
lib/lp/code/model/tests/test_branch.py (+4/-3)
lib/lp/oci/tests/test_ocirecipe.py (+2/-2)
lib/lp/registry/model/distributionsourcepackage.py (+2/-1)
lib/lp/registry/tests/test_prf_walker.py (+2/-2)
lib/lp/services/librarianserver/testing/server.py (+23/-14)
lib/lp/soyuz/browser/archivesubscription.py (+2/-1)
lib/lp/soyuz/browser/tests/test_distroarchseries_webservice.py (+2/-1)
lib/lp/soyuz/mail/tests/test_packageupload.py (+1/-1)
lib/lp/testing/keyserver/tests/test_web.py (+1/-1)
lib/lp/translations/scripts/tests/test_packaging_translations.py (+2/-2)
lib/lp/translations/utilities/gettext_po_parser.py (+1/-1)
lib/lp/translations/utilities/tests/test_gettext_po_exporter.py (+1/-1)
lib/lp/translations/utilities/tests/test_xpi_po_exporter.py (+2/-2)
scripts/update-stacked-on.py (+2/-1)
test_on_merge.py (+2/-1)
utilities/community-contributions.py (+107/-106)
Reviewer Review Type Date Requested Status
Cristian Gonzalez (community) Approve
Review via email: mp+406337@code.launchpad.net

Commit message

Fix/ignore flake8 line length errors

To post a comment you must log in.
Revision history for this message
Cristian Gonzalez (cristiangsp) wrote :

Looks good!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/doc/conf.py b/doc/conf.py
index 212dd6b..c4a73e4 100644
--- a/doc/conf.py
+++ b/doc/conf.py
@@ -3,7 +3,8 @@
3# Launchpad documentation build configuration file, created by3# Launchpad documentation build configuration file, created by
4# sphinx-quickstart on Thu Feb 3 16:06:09 2011.4# sphinx-quickstart on Thu Feb 3 16:06:09 2011.
5#5#
6# This file is execfile()d with the current directory set to its containing dir.6# This file is execfile()d with the current directory set to its containing
7# dir.
7#8#
8# Note that not all possible configuration values are present in this9# Note that not all possible configuration values are present in this
9# autogenerated file.10# autogenerated file.
@@ -16,13 +17,13 @@
16# documentation root, use os.path.abspath to make it absolute, like shown here.17# documentation root, use os.path.abspath to make it absolute, like shown here.
17#sys.path.insert(0, os.path.abspath('.'))18#sys.path.insert(0, os.path.abspath('.'))
1819
19# -- General configuration -----------------------------------------------------20# -- General configuration ----------------------------------------------------
2021
21# If your documentation needs a minimal Sphinx version, state it here.22# If your documentation needs a minimal Sphinx version, state it here.
22#needs_sphinx = '1.0'23#needs_sphinx = '1.0'
2324
24# Add any Sphinx extension module names here, as strings. They can be extensions25# Add any Sphinx extension module names here, as strings. They can be
25# coming with Sphinx (named 'sphinx.ext.*') or your custom ones.26# extensions coming with Sphinx (named 'sphinx.ext.*') or your custom ones.
26extensions = ['sphinx.ext.autodoc', 'sphinx.ext.doctest', 'sphinx.ext.todo']27extensions = ['sphinx.ext.autodoc', 'sphinx.ext.doctest', 'sphinx.ext.todo']
2728
28# Add any paths that contain templates here, relative to this directory.29# Add any paths that contain templates here, relative to this directory.
@@ -64,7 +65,8 @@ release = 'dev'
64# directories to ignore when looking for source files.65# directories to ignore when looking for source files.
65exclude_patterns = ['_build']66exclude_patterns = ['_build']
6667
67# The reST default role (used for this markup: `text`) to use for all documents.68# The reST default role (used for this markup: `text`) to use for all
69# documents.
68#default_role = None70#default_role = None
6971
70# If true, '()' will be appended to :func: etc. cross-reference text.72# If true, '()' will be appended to :func: etc. cross-reference text.
@@ -85,7 +87,7 @@ pygments_style = 'sphinx'
85#modindex_common_prefix = []87#modindex_common_prefix = []
8688
8789
88# -- Options for HTML output ---------------------------------------------------90# -- Options for HTML output --------------------------------------------------
8991
90# The theme to use for HTML and HTML Help pages. See the documentation for92# The theme to use for HTML and HTML Help pages. See the documentation for
91# a list of builtin themes.93# a list of builtin themes.
@@ -165,7 +167,7 @@ html_static_path = ['_static']
165htmlhelp_basename = 'Launchpaddoc'167htmlhelp_basename = 'Launchpaddoc'
166168
167169
168# -- Options for LaTeX output --------------------------------------------------170# -- Options for LaTeX output -------------------------------------------------
169171
170# The paper size ('letter' or 'a4').172# The paper size ('letter' or 'a4').
171#latex_paper_size = 'letter'173#latex_paper_size = 'letter'
@@ -174,7 +176,8 @@ htmlhelp_basename = 'Launchpaddoc'
174#latex_font_size = '10pt'176#latex_font_size = '10pt'
175177
176# Grouping the document tree into LaTeX files. List of tuples178# Grouping the document tree into LaTeX files. List of tuples
177# (source start file, target name, title, author, documentclass [howto/manual]).179# (source start file, target name, title, author,
180# documentclass [howto/manual]).
178latex_documents = [181latex_documents = [
179 ('index', 'Launchpad.tex', u'Launchpad Documentation',182 ('index', 'Launchpad.tex', u'Launchpad Documentation',
180 u'The Launchpad Developers', 'manual'),183 u'The Launchpad Developers', 'manual'),
@@ -204,7 +207,7 @@ latex_documents = [
204#latex_domain_indices = True207#latex_domain_indices = True
205208
206209
207# -- Options for manual page output --------------------------------------------210# -- Options for manual page output -------------------------------------------
208211
209# One entry per manual page. List of tuples212# One entry per manual page. List of tuples
210# (source start file, name, description, authors, manual section).213# (source start file, name, description, authors, manual section).
diff --git a/lib/lp/app/validators/email.py b/lib/lp/app/validators/email.py
index ce959fc..04d02dc 100644
--- a/lib/lp/app/validators/email.py
+++ b/lib/lp/app/validators/email.py
@@ -79,6 +79,7 @@ def email_validator(emailaddr):
79 >>> email_validator('bugs@example.com')79 >>> email_validator('bugs@example.com')
80 True80 True
81 >>> email_validator('not-valid')81 >>> email_validator('not-valid')
82 ... # noqa
82 ... # doctest: +IGNORE_EXCEPTION_MODULE_IN_PYTHON283 ... # doctest: +IGNORE_EXCEPTION_MODULE_IN_PYTHON2
83 Traceback (most recent call last):84 Traceback (most recent call last):
84 ...85 ...
diff --git a/lib/lp/app/validators/tests/test_validation.py b/lib/lp/app/validators/tests/test_validation.py
index 7c9c8b5..3cd87d9 100644
--- a/lib/lp/app/validators/tests/test_validation.py
+++ b/lib/lp/app/validators/tests/test_validation.py
@@ -38,4 +38,5 @@ class TestOCIBranchValidator(TestCase):
38 self.assertTrue(validate_oci_branch_name('refs/tags/v2-1.0-20.04'))38 self.assertTrue(validate_oci_branch_name('refs/tags/v2-1.0-20.04'))
3939
40 def test_validate_oci_branch_name_heads_and_tags(self):40 def test_validate_oci_branch_name_heads_and_tags(self):
41 self.assertFalse(validate_oci_branch_name("refs/heads/refs/tags/v1.0-20.04"))41 self.assertFalse(validate_oci_branch_name(
42 "refs/heads/refs/tags/v1.0-20.04"))
diff --git a/lib/lp/app/widgets/date.py b/lib/lp/app/widgets/date.py
index 85d0756..c24da8f 100644
--- a/lib/lp/app/widgets/date.py
+++ b/lib/lp/app/widgets/date.py
@@ -85,6 +85,7 @@ class DateTimeWidget(TextWidget):
85 >>> widget.from_date = datetime(2006, 5, 23,85 >>> widget.from_date = datetime(2006, 5, 23,
86 ... tzinfo=pytz.timezone('UTC'))86 ... tzinfo=pytz.timezone('UTC'))
87 >>> print(widget.getInputValue())87 >>> print(widget.getInputValue())
88 ... # noqa
88 ... # doctest: +NORMALIZE_WHITESPACE,+ELLIPSIS89 ... # doctest: +NORMALIZE_WHITESPACE,+ELLIPSIS
89 ... # doctest: +IGNORE_EXCEPTION_MODULE_IN_PYTHON290 ... # doctest: +IGNORE_EXCEPTION_MODULE_IN_PYTHON2
90 Traceback (most recent call last):91 Traceback (most recent call last):
@@ -103,6 +104,7 @@ class DateTimeWidget(TextWidget):
103 >>> widget.to_date = datetime(2008, 1, 26,104 >>> widget.to_date = datetime(2008, 1, 26,
104 ... tzinfo=pytz.timezone('UTC'))105 ... tzinfo=pytz.timezone('UTC'))
105 >>> print(widget.getInputValue())106 >>> print(widget.getInputValue())
107 ... # noqa
106 ... # doctest: +NORMALIZE_WHITESPACE,+ELLIPSIS108 ... # doctest: +NORMALIZE_WHITESPACE,+ELLIPSIS
107 ... # doctest: +IGNORE_EXCEPTION_MODULE_IN_PYTHON2109 ... # doctest: +IGNORE_EXCEPTION_MODULE_IN_PYTHON2
108 Traceback (most recent call last):110 Traceback (most recent call last):
diff --git a/lib/lp/archivepublisher/customupload.py b/lib/lp/archivepublisher/customupload.py
index 0c6a2c9..741211a 100644
--- a/lib/lp/archivepublisher/customupload.py
+++ b/lib/lp/archivepublisher/customupload.py
@@ -27,7 +27,9 @@ from lp.archivepublisher.debversion import (
27 Version as make_version,27 Version as make_version,
28 VersionError,28 VersionError,
29 )29 )
30from lp.archivepublisher.interfaces.archivegpgsigningkey import ISignableArchive30from lp.archivepublisher.interfaces.archivegpgsigningkey import (
31 ISignableArchive,
32 )
31from lp.services.librarian.utils import copy_and_close33from lp.services.librarian.utils import copy_and_close
32from lp.soyuz.interfaces.queue import (34from lp.soyuz.interfaces.queue import (
33 CustomUploadError,35 CustomUploadError,
diff --git a/lib/lp/archivepublisher/tests/test_signing.py b/lib/lp/archivepublisher/tests/test_signing.py
index 8e01ca1..e57ae72 100644
--- a/lib/lp/archivepublisher/tests/test_signing.py
+++ b/lib/lp/archivepublisher/tests/test_signing.py
@@ -1770,7 +1770,8 @@ class TestSigningUploadWithSigningService(TestSigningHelpers):
1770 '1.0/empty.sipl.sig', '1.0/control/sipl.x509',1770 '1.0/empty.sipl.sig', '1.0/control/sipl.x509',
1771 '1.0/empty.fit.signed', '1.0/control/fit.crt',1771 '1.0/empty.fit.signed', '1.0/control/fit.crt',
1772 '1.0/empty.cv2-kernel.sig', '1.0/control/cv2-kernel.pub',1772 '1.0/empty.cv2-kernel.sig', '1.0/control/cv2-kernel.pub',
1773 '1.0/empty.android-kernel.sig', '1.0/control/android-kernel.x509',1773 '1.0/empty.android-kernel.sig',
1774 '1.0/control/android-kernel.x509',
1774 ], tarball.getnames())1775 ], tarball.getnames())
1775 self.assertEqual(0, self.signing_service_client.generate.call_count)1776 self.assertEqual(0, self.signing_service_client.generate.call_count)
1776 keys = self.signing_keys1777 keys = self.signing_keys
diff --git a/lib/lp/archiveuploader/tests/test_tagfiles.py b/lib/lp/archiveuploader/tests/test_tagfiles.py
index f5bf552..5c541d9 100755
--- a/lib/lp/archiveuploader/tests/test_tagfiles.py
+++ b/lib/lp/archiveuploader/tests/test_tagfiles.py
@@ -119,9 +119,9 @@ class TestTagFileDebianPolicyCompat(unittest.TestCase):
119 Note: in the past, our parse_tagfile function left the leading119 Note: in the past, our parse_tagfile function left the leading
120 '\n' in the parsed value, whereas it should not have.120 '\n' in the parsed value, whereas it should not have.
121121
122 For an example,122 For an example, see
123 see http://www.debian.org/doc/debian-policy/ch-controlfields.html#s-f-Files123 https://www.debian.org/doc/debian-policy/ch-controlfields.html#s-f-files
124 """124 """ # noqa: E501
125125
126 expected_bytes = (126 expected_bytes = (
127 b'f26bb9b29b1108e53139da3584a4dc92 1511 test75874_0.1.tar.gz\n '127 b'f26bb9b29b1108e53139da3584a4dc92 1511 test75874_0.1.tar.gz\n '
@@ -142,8 +142,8 @@ class TestTagFileDebianPolicyCompat(unittest.TestCase):
142 """Apt-pkg preserves the blank-line indicator and does not strip142 """Apt-pkg preserves the blank-line indicator and does not strip
143 leading spaces.143 leading spaces.
144144
145 See http://www.debian.org/doc/debian-policy/ch-controlfields.html#s-f-Description145 See https://www.debian.org/doc/debian-policy/ch-controlfields.html#s-f-description
146 """146 """ # noqa: E501
147 expected_bytes = (147 expected_bytes = (
148 b"Here's the single-line synopsis.\n"148 b"Here's the single-line synopsis.\n"
149 b" Then there is the extended description which can\n"149 b" Then there is the extended description which can\n"
diff --git a/lib/lp/code/mail/tests/test_codehandler.py b/lib/lp/code/mail/tests/test_codehandler.py
index 47dc486..55fd4a5 100644
--- a/lib/lp/code/mail/tests/test_codehandler.py
+++ b/lib/lp/code/mail/tests/test_codehandler.py
@@ -229,7 +229,8 @@ class TestCodeHandler(TestCaseWithFactory):
229 Error message:229 Error message:
230230
231 The 'review' command expects any of the following arguments:231 The 'review' command expects any of the following arguments:
232 abstain, approve, disapprove, needs-fixing, needs-info, needs-resubmitting232 abstain, approve, disapprove, needs-fixing, needs-info,
233 needs-resubmitting
233234
234 For example:235 For example:
235236
diff --git a/lib/lp/code/mail/tests/test_codeimport.py b/lib/lp/code/mail/tests/test_codeimport.py
index b37f538..03411f5 100644
--- a/lib/lp/code/mail/tests/test_codeimport.py
+++ b/lib/lp/code/mail/tests/test_codeimport.py
@@ -150,7 +150,8 @@ class TestNewCodeImports(TestCaseWithFactory):
150 self.assertEqual(150 self.assertEqual(
151 'A new git code import has been requested '151 'A new git code import has been requested '
152 'by Eric:\n'152 'by Eric:\n'
153 ' http://code.launchpad.test/~eric/foobuntu/manic/fooix/master\n'153 ' http://code.launchpad.test/'
154 '~eric/foobuntu/manic/fooix/master\n'
154 'from\n'155 'from\n'
155 ' git://git.example.com/fooix.git\n'156 ' git://git.example.com/fooix.git\n'
156 '\n'157 '\n'
diff --git a/lib/lp/code/model/tests/test_branch.py b/lib/lp/code/model/tests/test_branch.py
index 1649dc9..d69c650 100644
--- a/lib/lp/code/model/tests/test_branch.py
+++ b/lib/lp/code/model/tests/test_branch.py
@@ -3273,8 +3273,8 @@ class TestGetBzrBranch(TestCaseWithFactory):
3273 self.useBzrBranches(direct_database=True)3273 self.useBzrBranches(direct_database=True)
32743274
3275 def test_simple(self):3275 def test_simple(self):
3276 # open_only_scheme returns the underlying bzr branch of a database branch in3276 # open_only_scheme returns the underlying bzr branch of a database
3277 # the simple, unstacked, case.3277 # branch in the simple, unstacked, case.
3278 db_branch, tree = self.create_branch_and_tree()3278 db_branch, tree = self.create_branch_and_tree()
3279 # XXX: AaronBentley 2010-08-06 bug=614404: a bzr username is3279 # XXX: AaronBentley 2010-08-06 bug=614404: a bzr username is
3280 # required to generate the revision-id.3280 # required to generate the revision-id.
@@ -3335,7 +3335,8 @@ class TestBranchGetBlob(TestCaseWithFactory):
3335 [((branch.id, 'some-file-id'), {'rev': 'scanned-id'})],3335 [((branch.id, 'some-file-id'), {'rev': 'scanned-id'})],
3336 hosting_fixture.getBlob.calls)3336 hosting_fixture.getBlob.calls)
3337 key = (3337 key = (
3338 'bazaar.launchpad.test:bzr-file-list:%s:scanned-id:src' % branch.id)3338 'bazaar.launchpad.test:bzr-file-list:%s:scanned-id:src' %
3339 branch.id)
3339 self.assertEqual(3340 self.assertEqual(
3340 json.dumps({'README.txt': 'some-file-id'}),3341 json.dumps({'README.txt': 'some-file-id'}),
3341 getUtility(IMemcacheClient).get(key.encode('UTF-8')))3342 getUtility(IMemcacheClient).get(key.encode('UTF-8')))
diff --git a/lib/lp/oci/tests/test_ocirecipe.py b/lib/lp/oci/tests/test_ocirecipe.py
index 95e30a8..c3bb8f8 100644
--- a/lib/lp/oci/tests/test_ocirecipe.py
+++ b/lib/lp/oci/tests/test_ocirecipe.py
@@ -680,8 +680,8 @@ class TestOCIRecipe(OCIConfigHelperMixin, TestCaseWithFactory):
680 oci_project=oci_project, registrant=owner)680 oci_project=oci_project, registrant=owner)
681681
682 self.assertRaises(682 self.assertRaises(
683 OCIProjectRecipeInvalid, another_oci_project.setOfficialRecipeStatus,683 OCIProjectRecipeInvalid,
684 recipe, True)684 another_oci_project.setOfficialRecipeStatus, recipe, True)
685685
686 def test_permission_check_on_setOfficialRecipe(self):686 def test_permission_check_on_setOfficialRecipe(self):
687 distro = self.factory.makeDistribution()687 distro = self.factory.makeDistribution()
diff --git a/lib/lp/registry/model/distributionsourcepackage.py b/lib/lp/registry/model/distributionsourcepackage.py
index 863ae85..e7611be 100644
--- a/lib/lp/registry/model/distributionsourcepackage.py
+++ b/lib/lp/registry/model/distributionsourcepackage.py
@@ -263,7 +263,8 @@ class DistributionSourcePackage(BugTargetBase,
263 self.distribution.all_distro_archive_ids),263 self.distribution.all_distro_archive_ids),
264 SourcePackagePublishingHistory.sourcepackagerelease ==264 SourcePackagePublishingHistory.sourcepackagerelease ==
265 SourcePackageRelease.id,265 SourcePackageRelease.id,
266 SourcePackagePublishingHistory.sourcepackagename == self.sourcepackagename,266 SourcePackagePublishingHistory.sourcepackagename ==
267 self.sourcepackagename,
267 SourcePackageRelease.sourcepackagename == self.sourcepackagename,268 SourcePackageRelease.sourcepackagename == self.sourcepackagename,
268 Cast(SourcePackageRelease.version, "text") ==269 Cast(SourcePackageRelease.version, "text") ==
269 six.ensure_text(version),270 six.ensure_text(version),
diff --git a/lib/lp/registry/tests/test_prf_walker.py b/lib/lp/registry/tests/test_prf_walker.py
index 9a1f32d..cf82294 100644
--- a/lib/lp/registry/tests/test_prf_walker.py
+++ b/lib/lp/registry/tests/test_prf_walker.py
@@ -282,7 +282,7 @@ class HTTPWalker_ListDir(TestCase):
282282
283<address>Apache/2.2.3 (Unix) Server at <a href="mailto:ftp-adm@acc.umu.se">ftp.acc.umu.se</a> Port 80</address>283<address>Apache/2.2.3 (Unix) Server at <a href="mailto:ftp-adm@acc.umu.se">ftp.acc.umu.se</a> Port 80</address>
284</body></html>284</body></html>
285 '''285 ''' # noqa: E501
286 listing_url = 'http://ftp.gnome.org/pub/GNOME/sources/gnome-gpg/0.5/'286 listing_url = 'http://ftp.gnome.org/pub/GNOME/sources/gnome-gpg/0.5/'
287 responses.add('GET', listing_url, body=content)287 responses.add('GET', listing_url, body=content)
288 expected_filenames = [288 expected_filenames = [
@@ -323,7 +323,7 @@ FTP Directory: <A HREF="/">ftp://ftp.gnome.org</A>/<A HREF="/pub/">pub</A>/<A HR
323<ADDRESS>323<ADDRESS>
324Generated Wed, 06 Sep 2006 11:04:02 GMT by squid (squid/2.5.STABLE12)324Generated Wed, 06 Sep 2006 11:04:02 GMT by squid (squid/2.5.STABLE12)
325</ADDRESS></BODY></HTML>325</ADDRESS></BODY></HTML>
326 '''326 ''' # noqa: E501
327 listing_url = 'ftp://ftp.gnome.org/pub/GNOME/sources/gnome-gpg/0.5/'327 listing_url = 'ftp://ftp.gnome.org/pub/GNOME/sources/gnome-gpg/0.5/'
328 responses.add('GET', listing_url, body=content)328 responses.add('GET', listing_url, body=content)
329 walker = HTTPWalker(listing_url, logging.getLogger())329 walker = HTTPWalker(listing_url, logging.getLogger())
diff --git a/lib/lp/services/librarianserver/testing/server.py b/lib/lp/services/librarianserver/testing/server.py
index 20bfdfd..535d504 100644
--- a/lib/lp/services/librarianserver/testing/server.py
+++ b/lib/lp/services/librarianserver/testing/server.py
@@ -161,20 +161,29 @@ class LibrarianServerFixture(TacTestSetup):
161 return161 return
162 chunks = self.getLogChunks()162 chunks = self.getLogChunks()
163 # A typical startup: upload, download, restricted up, restricted down.163 # A typical startup: upload, download, restricted up, restricted down.
164 #2017-12-09 06:33:13+0530 [-] Loading /home/ubuntu/launchpad/lp-branches/devel/daemons/librarian.tac...164 # (Line-wrapped to pacify flake8.)
165 #2017-12-09 06:33:19+0530 [-] Loaded.165 # 2017-12-09 06:33:13+0530 [-] Loading .../daemons/librarian.tac...
166 #2017-12-09 06:33:19+0530 [-] twistd 16.5.0 (/home/ubuntu/launchpad/lp-branches/devel/env/bin/python2.7 2.7.12) starting up.166 # 2017-12-09 06:33:19+0530 [-] Loaded.
167 #2017-12-09 06:33:19+0530 [-] reactor class: twisted.internet.epollreactor.EPollReactor.167 # 2017-12-09 06:33:19+0530 [-] twistd 16.5.0
168 #2017-12-09 06:33:19+0530 [-] FileUploadFactory starting on 39851168 # (.../env/bin/python2.7 2.7.12) starting up.
169 #2017-12-09 06:33:19+0530 [-] Starting factory <lp.services.librarianserver.libraryprotocol.FileUploadFactory instance at 0xf0ef80ac>169 # 2017-12-09 06:33:19+0530 [-] reactor class:
170 #2017-12-09 06:33:19+0530 [-] Site starting on 45355170 # twisted.internet.epollreactor.EPollReactor.
171 #2017-12-09 06:33:19+0530 [-] Starting factory <twisted.web.server.Site instance at 0xf0ef848c>171 # 2017-12-09 06:33:19+0530 [-] FileUploadFactory starting on 39851
172 #2017-12-09 06:33:19+0530 [-] FileUploadFactory starting on 42150172 # 2017-12-09 06:33:19+0530 [-] Starting factory
173 #2017-12-09 06:33:19+0530 [-] Starting factory <lp.services.librarianserver.libraryprotocol.FileUploadFactory instance at 0xf0ef856c>173 # <lp.services.librarianserver.libraryprotocol.FileUploadFactory
174 #2017-12-09 06:33:19+0530 [-] Site starting on 37341174 # instance at 0xf0ef80ac>
175 #2017-12-09 06:33:19+0530 [-] Starting factory <twisted.web.server.Site instance at 0xf0ef85ec>175 # 2017-12-09 06:33:19+0530 [-] Site starting on 45355
176 #2017-12-09 06:33:19+0530 [-] Not using upstream librarian176 # 2017-12-09 06:33:19+0530 [-] Starting factory
177 #2017-12-09 06:33:19+0530 [-] daemon ready!177 # <twisted.web.server.Site instance at 0xf0ef848c>
178 # 2017-12-09 06:33:19+0530 [-] FileUploadFactory starting on 42150
179 # 2017-12-09 06:33:19+0530 [-] Starting factory
180 # <lp.services.librarianserver.libraryprotocol.FileUploadFactory
181 # instance at 0xf0ef856c>
182 # 2017-12-09 06:33:19+0530 [-] Site starting on 37341
183 # 2017-12-09 06:33:19+0530 [-] Starting factory
184 # <twisted.web.server.Site instance at 0xf0ef85ec>
185 # 2017-12-09 06:33:19+0530 [-] Not using upstream librarian
186 # 2017-12-09 06:33:19+0530 [-] daemon ready!
178 self.upload_port = int(chunks[4].split()[-1])187 self.upload_port = int(chunks[4].split()[-1])
179 self.download_port = int(chunks[6].split()[-1])188 self.download_port = int(chunks[6].split()[-1])
180 self.restricted_upload_port = int(chunks[8].split()[-1])189 self.restricted_upload_port = int(chunks[8].split()[-1])
diff --git a/lib/lp/soyuz/browser/archivesubscription.py b/lib/lp/soyuz/browser/archivesubscription.py
index f05a506..e78b7cd 100644
--- a/lib/lp/soyuz/browser/archivesubscription.py
+++ b/lib/lp/soyuz/browser/archivesubscription.py
@@ -129,7 +129,8 @@ class ArchiveSubscribersView(LaunchpadFormView):
129129
130 schema = IArchiveSubscriberUI130 schema = IArchiveSubscriberUI
131 field_names = ['subscriber', 'date_expires', 'description']131 field_names = ['subscriber', 'date_expires', 'description']
132 custom_widget_description = CustomWidgetFactory(TextWidget, displayWidth=40)132 custom_widget_description = CustomWidgetFactory(
133 TextWidget, displayWidth=40)
133 custom_widget_date_expires = DateWidget134 custom_widget_date_expires = DateWidget
134 custom_widget_subscriber = CustomWidgetFactory(135 custom_widget_subscriber = CustomWidgetFactory(
135 PersonPickerWidget, header="Select the subscriber")136 PersonPickerWidget, header="Select the subscriber")
diff --git a/lib/lp/soyuz/browser/tests/test_distroarchseries_webservice.py b/lib/lp/soyuz/browser/tests/test_distroarchseries_webservice.py
index 4555f60..1db0346 100644
--- a/lib/lp/soyuz/browser/tests/test_distroarchseries_webservice.py
+++ b/lib/lp/soyuz/browser/tests/test_distroarchseries_webservice.py
@@ -198,7 +198,8 @@ class TestDistroArchSeriesWebservice(TestCaseWithFactory):
198 sha1_1 = hashlib.sha1(b'abcxyz').hexdigest()198 sha1_1 = hashlib.sha1(b'abcxyz').hexdigest()
199 ws_das.setChroot(data=b'abcxyz', sha1sum=sha1_1)199 ws_das.setChroot(data=b'abcxyz', sha1sum=sha1_1)
200 sha1_2 = hashlib.sha1(b'123456').hexdigest()200 sha1_2 = hashlib.sha1(b'123456').hexdigest()
201 ws_das.setChroot(data=b'123456', sha1sum=sha1_2, image_type='LXD image')201 ws_das.setChroot(
202 data=b'123456', sha1sum=sha1_2, image_type='LXD image')
202 chroot_image = das.getChroot(image_type=BuildBaseImageType.CHROOT)203 chroot_image = das.getChroot(image_type=BuildBaseImageType.CHROOT)
203 self.assertEqual(sha1_1, chroot_image.content.sha1)204 self.assertEqual(sha1_1, chroot_image.content.sha1)
204 lxd_image = das.getChroot(image_type=BuildBaseImageType.LXD)205 lxd_image = das.getChroot(image_type=BuildBaseImageType.LXD)
diff --git a/lib/lp/soyuz/mail/tests/test_packageupload.py b/lib/lp/soyuz/mail/tests/test_packageupload.py
index c7378f9..1b59fd5 100644
--- a/lib/lp/soyuz/mail/tests/test_packageupload.py
+++ b/lib/lp/soyuz/mail/tests/test_packageupload.py
@@ -243,7 +243,7 @@ class TestNotificationRequiringLibrarian(TestCaseWithFactory):
243 %s243 %s
244 http://launchpad.test/~archiver/+archive/ubuntu/ppa244 http://launchpad.test/~archiver/+archive/ubuntu/ppa
245 You are receiving this email because you made this upload.245 You are receiving this email because you made this upload.
246 """ % "-- ")246 """ % "-- ") # noqa: E501
247 self.assertEqual(expected_body, body)247 self.assertEqual(expected_body, body)
248248
249249
diff --git a/lib/lp/testing/keyserver/tests/test_web.py b/lib/lp/testing/keyserver/tests/test_web.py
index e11f86c..74c343b 100644
--- a/lib/lp/testing/keyserver/tests/test_web.py
+++ b/lib/lp/testing/keyserver/tests/test_web.py
@@ -120,7 +120,7 @@ class TestWebResources(TestCase):
120...120...
121pub 1024D/DFD20543 2005-04-13 Sample Person (revoked) &lt;sample.revoked@canonical.com&gt;121pub 1024D/DFD20543 2005-04-13 Sample Person (revoked) &lt;sample.revoked@canonical.com&gt;
122...122...
123''')123''') # noqa: E501
124124
125 def test_content_lookup(self):125 def test_content_lookup(self):
126 # A key content lookup form via GET.126 # A key content lookup form via GET.
diff --git a/lib/lp/translations/scripts/tests/test_packaging_translations.py b/lib/lp/translations/scripts/tests/test_packaging_translations.py
index 77673b8..766c749 100644
--- a/lib/lp/translations/scripts/tests/test_packaging_translations.py
+++ b/lib/lp/translations/scripts/tests/test_packaging_translations.py
@@ -39,7 +39,7 @@ class TestMergeTranslations(TestCaseWithFactory):
39 INFO Merging template 1/2.39 INFO Merging template 1/2.
40 INFO Merging template 2/2.40 INFO Merging template 2/2.
41 INFO Ran 1 TranslationMergeJob jobs.41 INFO Ran 1 TranslationMergeJob jobs.
42 """))42 """)) # noqa: E501
43 self.assertThat(stderr, matcher)43 self.assertThat(stderr, matcher)
44 self.assertEqual('', stdout)44 self.assertEqual('', stdout)
4545
@@ -57,6 +57,6 @@ class TestMergeTranslations(TestCaseWithFactory):
57 INFO Splitting .* and .* in Ubuntu Distroseries.*57 INFO Splitting .* and .* in Ubuntu Distroseries.*
58 INFO 1 entries split.58 INFO 1 entries split.
59 INFO Ran 1 TranslationSplitJob jobs.59 INFO Ran 1 TranslationSplitJob jobs.
60 """))60 """)) # noqa: E501
61 self.assertThat(stderr, matcher)61 self.assertThat(stderr, matcher)
62 self.assertEqual('', stdout)62 self.assertEqual('', stdout)
diff --git a/lib/lp/translations/utilities/gettext_po_parser.py b/lib/lp/translations/utilities/gettext_po_parser.py
index 925af2d..4756050 100644
--- a/lib/lp/translations/utilities/gettext_po_parser.py
+++ b/lib/lp/translations/utilities/gettext_po_parser.py
@@ -801,7 +801,7 @@ class POParser(object):
801 Traceback (most recent call last):801 Traceback (most recent call last):
802 ...802 ...
803 lp.translations.interfaces.translationimporter.TranslationFormatSyntaxError: Extra content found after string: (x)803 lp.translations.interfaces.translationimporter.TranslationFormatSyntaxError: Extra content found after string: (x)
804 """804 """ # noqa: E501
805 if self._escaped_line_break:805 if self._escaped_line_break:
806 # Continuing a line after an escaped newline. Strip indentation.806 # Continuing a line after an escaped newline. Strip indentation.
807 string = string.lstrip()807 string = string.lstrip()
diff --git a/lib/lp/translations/utilities/tests/test_gettext_po_exporter.py b/lib/lp/translations/utilities/tests/test_gettext_po_exporter.py
index 7bf5479..916965e 100644
--- a/lib/lp/translations/utilities/tests/test_gettext_po_exporter.py
+++ b/lib/lp/translations/utilities/tests/test_gettext_po_exporter.py
@@ -133,7 +133,7 @@ class GettextPOExporterTestCase(TestCaseWithFactory):
133133
134 #~ msgid "zot"134 #~ msgid "zot"
135 #~ msgstr "zat"135 #~ msgstr "zat"
136 ''').encode('UTF-8')136 ''').encode('UTF-8') # noqa: E501
137 cy_translation_file = self.parser.parse(pofile_cy)137 cy_translation_file = self.parser.parse(pofile_cy)
138 cy_translation_file.is_template = False138 cy_translation_file.is_template = False
139 cy_translation_file.language_code = 'cy'139 cy_translation_file.language_code = 'cy'
diff --git a/lib/lp/translations/utilities/tests/test_xpi_po_exporter.py b/lib/lp/translations/utilities/tests/test_xpi_po_exporter.py
index 78ab7cc..a28be12 100644
--- a/lib/lp/translations/utilities/tests/test_xpi_po_exporter.py
+++ b/lib/lp/translations/utilities/tests/test_xpi_po_exporter.py
@@ -80,7 +80,7 @@ test_xpi_header = dedent(u'''\
80 </em:targetApplication>80 </em:targetApplication>
81 </Description>81 </Description>
82 </RDF>82 </RDF>
83''')83''') # noqa: E501
84test_xpi_messages = [84test_xpi_messages = [
85 (u'foozilla.menu.title', u'main/subdir/test2.dtd',85 (u'foozilla.menu.title', u'main/subdir/test2.dtd',
86 u'jar:chrome/en-US.jar!/subdir/test2.dtd', u'MENU',86 u'jar:chrome/en-US.jar!/subdir/test2.dtd', u'MENU',
@@ -385,7 +385,7 @@ class XPIPOExporterTestCase(TestCase):
385 msgctxt "main/test1.properties"385 msgctxt "main/test1.properties"
386 msgid "Дан=Day"386 msgid "Дан=Day"
387 msgstr ""387 msgstr ""
388 ''').strip()388 ''').strip() # noqa: E501
389389
390 output = storage.export().read().decode("utf-8")390 output = storage.export().read().decode("utf-8")
391 self._compareExpectedAndExported(expected_template, output)391 self._compareExpectedAndExported(expected_template, output)
diff --git a/scripts/update-stacked-on.py b/scripts/update-stacked-on.py
index 1648ec9..85d4df3 100755
--- a/scripts/update-stacked-on.py
+++ b/scripts/update-stacked-on.py
@@ -6,7 +6,8 @@
6"""Update stacked_on_location for all Bazaar branches.6"""Update stacked_on_location for all Bazaar branches.
77
8Expects standard input of:8Expects standard input of:
9 '<id> <branch_type> <unique_name> <stacked_on_id> <stacked_on_unique_name>\n'.9 '<id> <branch_type> <unique_name> <stacked_on_id>
10 <stacked_on_unique_name>\n'.
1011
11Such input can be provided using "get-stacked-on-branches.py".12Such input can be provided using "get-stacked-on-branches.py".
1213
diff --git a/test_on_merge.py b/test_on_merge.py
index a1cd0e2..59fa01b 100755
--- a/test_on_merge.py
+++ b/test_on_merge.py
@@ -179,7 +179,8 @@ def run_test_process():
179 # bzr. -- mbp 20100924179 # bzr. -- mbp 20100924
180 while True:180 while True:
181 try:181 try:
182 rlist, wlist, xlist = select.select(open_readers, [], [], TIMEOUT)182 rlist, wlist, xlist = select.select(
183 open_readers, [], [], TIMEOUT)
183 break184 break
184 except select.error as e:185 except select.error as e:
185 # nb: select.error doesn't expose a named 'errno' attribute,186 # nb: select.error doesn't expose a named 'errno' attribute,
diff --git a/utilities/community-contributions.py b/utilities/community-contributions.py
index 10f07e9..d9c59e2 100755
--- a/utilities/community-contributions.py
+++ b/utilities/community-contributions.py
@@ -104,111 +104,112 @@ CANONICAL_ADDR = wiki_encode(u" {_AT_} canonical.com")
104104
105# People on the Canonical Launchpad team.105# People on the Canonical Launchpad team.
106known_canonical_lp_devs = \106known_canonical_lp_devs = \
107 [wiki_encode(x) for x in (u'Aaron Bentley',107 [wiki_encode(x) for x in (
108 u'Abel Deuring',108 u'Aaron Bentley',
109 u'Andrew Bennetts',109 u'Abel Deuring',
110 u'Barry Warsaw',110 u'Andrew Bennetts',
111 u'Benji York',111 u'Barry Warsaw',
112 u'Bjorn Tillenius',112 u'Benji York',
113 u'Björn Tillenius',113 u'Bjorn Tillenius',
114 u'Brad Bollenbach',114 u'Björn Tillenius',
115 u'Brad Crittenden',115 u'Brad Bollenbach',
116 u'Brian Fromme',116 u'Brad Crittenden',
117 u'Canonical.com Patch Queue Manager',117 u'Brian Fromme',
118 u'Carlos Perello Marin',118 u'Canonical.com Patch Queue Manager',
119 u'Carlos Perelló Marín',119 u'Carlos Perello Marin',
120 u'carlos.perello {_AT_} canonical.com',120 u'Carlos Perelló Marín',
121 u'Celso Providelo',121 u'carlos.perello {_AT_} canonical.com',
122 u'Christian Reis',122 u'Celso Providelo',
123 u'Christian Robottom Reis',123 u'Christian Reis',
124 u'kiko {_AT_} beetle',124 u'Christian Robottom Reis',
125 u'Colin Watson',125 u'kiko {_AT_} beetle',
126 u'Curtis Hovey',126 u'Colin Watson',
127 u'Dafydd Harries',127 u'Curtis Hovey',
128 u'Danilo Šegan',128 u'Dafydd Harries',
129 u'Danilo Segan',129 u'Danilo Šegan',
130 u'david <david {_AT_} marvin>',130 u'Danilo Segan',
131 u'Данило Шеган',131 u'david <david {_AT_} marvin>',
132 u'данило шеган',132 u'Данило Шеган',
133 u'Daniel Silverstone',133 u'данило шеган',
134 u'David Allouche',134 u'Daniel Silverstone',
135 u'Deryck Hodge',135 u'David Allouche',
136 u'Diogo Matsubara',136 u'Deryck Hodge',
137 u'Edwin Grubbs',137 u'Diogo Matsubara',
138 u'Elliot Murphy',138 u'Edwin Grubbs',
139 u'Firstname Lastname',139 u'Elliot Murphy',
140 u'Francesco Banconi',140 u'Firstname Lastname',
141 u'Francis Lacoste',141 u'Francesco Banconi',
142 u'Francis J. Lacoste',142 u'Francis Lacoste',
143 u'Gary Poster',143 u'Francis J. Lacoste',
144 u'Gavin Panella',144 u'Gary Poster',
145 u'Graham Binns',145 u'Gavin Panella',
146 u'Guilherme Salgado',146 u'Graham Binns',
147 u'Henning Eggers',147 u'Guilherme Salgado',
148 u'Herb McNew',148 u'Henning Eggers',
149 u'Huw Wilkins',149 u'Herb McNew',
150 u'Ian Booth',150 u'Huw Wilkins',
151 u'James Henstridge',151 u'Ian Booth',
152 u'j.c.sackett',152 u'James Henstridge',
153 u'jc',153 u'j.c.sackett',
154 u'Jelmer Vernooij',154 u'jc',
155 u'Jeroen Vermeulen',155 u'Jelmer Vernooij',
156 u'Jeroen T. Vermeulen',156 u'Jeroen Vermeulen',
157 u'Joey Stanford',157 u'Jeroen T. Vermeulen',
158 u'Jon Sackett',158 u'Joey Stanford',
159 u'Jonathan Lange',159 u'Jon Sackett',
160 u'j.c.sackett',160 u'Jonathan Lange',
161 u'jonathan.sackett {_AT_} canonical.com',161 u'j.c.sackett',
162 u'jml {_AT_} canonical.com',162 u'jonathan.sackett {_AT_} canonical.com',
163 u'jml {_AT_} mumak.net',163 u'jml {_AT_} canonical.com',
164 u'Jonathan Knowles',164 u'jml {_AT_} mumak.net',
165 u'jonathan.knowles {_AT_} canonical.com',165 u'Jonathan Knowles',
166 u'Julian Edwards',166 u'jonathan.knowles {_AT_} canonical.com',
167 u'Karl Fogel',167 u'Julian Edwards',
168 u'Kit Randel',168 u'Karl Fogel',
169 u'Launch Pad',169 u'Kit Randel',
170 u'Launchpad APA',170 u'Launch Pad',
171 u'Launchpad Developers',171 u'Launchpad APA',
172 u'Launchpad Patch Queue Manager',172 u'Launchpad Developers',
173 u'Launchpad PQM Bot',173 u'Launchpad Patch Queue Manager',
174 u'Leonard Richardson',174 u'Launchpad PQM Bot',
175 u'Malcolm Cleaton',175 u'Leonard Richardson',
176 u'Maris Fogels',176 u'Malcolm Cleaton',
177 u'Mark Shuttleworth',177 u'Maris Fogels',
178 u'Martin Albisetti',178 u'Mark Shuttleworth',
179 u'Matt Zimmerman',179 u'Martin Albisetti',
180 u'Matthew Paul Thomas',180 u'Matt Zimmerman',
181 u'Matthew Thomas',181 u'Matthew Paul Thomas',
182 u'Matthew Revell',182 u'Matthew Thomas',
183 u'matthew.revell {_AT_} canonical.com',183 u'Matthew Revell',
184 u'Michael Hudson',184 u'matthew.revell {_AT_} canonical.com',
185 u'michael.hudson {_AT_} canonical.com',185 u'Michael Hudson',
186 u'Michael Nelson',186 u'michael.hudson {_AT_} canonical.com',
187 u'Muharem Hrnjadovic',187 u'Michael Nelson',
188 u'muharem {_AT_} canonical.com',188 u'Muharem Hrnjadovic',
189 u'Patch Queue Manager',189 u'muharem {_AT_} canonical.com',
190 u'Paul Hummer',190 u'Patch Queue Manager',
191 u'Raphael Badin',191 u'Paul Hummer',
192 u'Raphaël Badin',192 u'Raphael Badin',
193 u'Richard Harding',193 u'Raphaël Badin',
194 u'Rick Harding',194 u'Richard Harding',
195 u'Rick harding',195 u'Rick Harding',
196 u'Robert Collins',196 u'Rick harding',
197 u'root <root {_AT_} ubuntu>',197 u'Robert Collins',
198 u'rvb',198 u'root <root {_AT_} ubuntu>',
199 u'Stuart Bishop',199 u'rvb',
200 u'Steve Alexander',200 u'Stuart Bishop',
201 u'Steve Kowalik',201 u'Steve Alexander',
202 u'Steve McInerney',202 u'Steve Kowalik',
203 u'<steve {_AT_} stedee.id.au>',203 u'Steve McInerney',
204 u'test {_AT_} canonical.com',204 u'<steve {_AT_} stedee.id.au>',
205 u'Tom Haddon',205 u'test {_AT_} canonical.com',
206 u'Tim Penhey',206 u'Tom Haddon',
207 u'Tom Berger',207 u'Tim Penhey',
208 u'ubuntu <ubuntu {_AT_} lp-dev>',208 u'Tom Berger',
209 u'Ursula Junque',209 u'ubuntu <ubuntu {_AT_} lp-dev>',
210 u'William Grant <william.grant {_AT_} canonical.com>',210 u'Ursula Junque',
211 )]211 u'William Grant <william.grant {_AT_} canonical.com>',
212 )]
212213
213# People known to work for Canonical but not on the Launchpad team.214# People known to work for Canonical but not on the Launchpad team.
214# Anyone with "@canonical.com" in their email address is considered to215# Anyone with "@canonical.com" in their email address is considered to
@@ -641,7 +642,7 @@ generates this page is \
641[[https://bazaar.launchpad.net/%7Elaunchpad-pqm/launchpad/devel/annotate/head%3A/utilities/community-contributions.py|utilities/community-contributions.py]] \642[[https://bazaar.launchpad.net/%7Elaunchpad-pqm/launchpad/devel/annotate/head%3A/utilities/community-contributions.py|utilities/community-contributions.py]] \
642in the Launchpad tree.''-~643in the Launchpad tree.''-~
643644
644"""645""" # noqa: E501
645646
646647
647def main():648def main():

Subscribers

People subscribed via source and target branches

to status/vote changes: