Merge ~cjwatson/launchpad:charm-recipe-build-behaviour into launchpad:master

[Colin Watson]

Add a build behaviour for charm recipes

[Cristian Gonzalez (cristiangsp)]

Looks good!

review: Approve

[Ioana Lasc (ilasc)]

review: Approve

diff --git a/lib/lp/charms/configure.zcml b/lib/lp/charms/configure.zcml
index f1deb96..68acb5e 100644
--- a/lib/lp/charms/configure.zcml
+++ b/lib/lp/charms/configure.zcml
@@ -77,6 +77,13 @@
         <allow interface="lp.charms.interfaces.charmrecipebuild.ICharmFile" />
     </class>
 
+    <!-- CharmRecipeBuildBehaviour -->
+    <adapter
+        for="lp.charms.interfaces.charmrecipebuild.ICharmRecipeBuild"
+        provides="lp.buildmaster.interfaces.buildfarmjobbehaviour.IBuildFarmJobBehaviour"
+        factory="lp.charms.model.charmrecipebuildbehaviour.CharmRecipeBuildBehaviour"
+        permission="zope.Public" />
+
     <!-- Charm-related jobs -->
     <class class="lp.charms.model.charmrecipejob.CharmRecipeJob">
         <allow interface="lp.charms.interfaces.charmrecipejob.ICharmRecipeJob" />
diff --git a/lib/lp/charms/model/charmrecipebuildbehaviour.py b/lib/lp/charms/model/charmrecipebuildbehaviour.py
 new file mode 100644
index 0000000..31ef483
--- /dev/null
+++ b/lib/lp/charms/model/charmrecipebuildbehaviour.py
@@ -0,0 +1,111 @@
+# Copyright 2021 Canonical Ltd.  This software is licensed under the
+# GNU Affero General Public License version 3 (see the file LICENSE).
+
+"""An `IBuildFarmJobBehaviour` for `CharmRecipeBuild`.
+
+Dispatches charm recipe build jobs to build-farm slaves.
+"""
+
+from __future__ import absolute_import, print_function, unicode_literals
+
+__metaclass__ = type
+__all__ = [
+    "CharmRecipeBuildBehaviour",
+    ]
+
+from twisted.internet import defer
+from zope.component import adapter
+from zope.interface import implementer
+from zope.security.proxy import removeSecurityProxy
+
+from lp.buildmaster.enums import BuildBaseImageType
+from lp.buildmaster.interfaces.builder import CannotBuild
+from lp.buildmaster.interfaces.buildfarmjobbehaviour import (
+    IBuildFarmJobBehaviour,
+    )
+from lp.buildmaster.model.buildfarmjobbehaviour import (
+    BuildFarmJobBehaviourBase,
+    )
+from lp.charms.interfaces.charmrecipebuild import ICharmRecipeBuild
+from lp.registry.interfaces.series import SeriesStatus
+from lp.soyuz.adapters.archivedependencies import (
+    get_sources_list_for_building,
+    )
+
+
+@adapter(ICharmRecipeBuild)
+@implementer(IBuildFarmJobBehaviour)
+class CharmRecipeBuildBehaviour(BuildFarmJobBehaviourBase):
+    """Dispatches `CharmRecipeBuild` jobs to slaves."""
+
+    builder_type = "charm"
+    image_types = [BuildBaseImageType.LXD, BuildBaseImageType.CHROOT]
+
+    def getLogFileName(self):
+        das = self.build.distro_arch_series
+
+        # Examples:
+        #   buildlog_charm_ubuntu_wily_amd64_name_FULLYBUILT.txt
+        return "buildlog_charm_%s_%s_%s_%s_%s.txt" % (
+            das.distroseries.distribution.name, das.distroseries.name,
+            das.architecturetag, self.build.recipe.name,
+            self.build.status.name)
+
+    def verifyBuildRequest(self, logger):
+        """Assert some pre-build checks.
+
+        The build request is checked:
+         * Virtualized builds can't build on a non-virtual builder
+         * Ensure that we have a chroot
+        """
+        build = self.build
+        if build.virtualized and not self._builder.virtualized:
+            raise AssertionError(
+                "Attempt to build virtual item on a non-virtual builder.")
+
+        chroot = build.distro_arch_series.getChroot()
+        if chroot is None:
+            raise CannotBuild(
+                "Missing chroot for %s" % build.distro_arch_series.displayname)
+
+    @defer.inlineCallbacks
+    def extraBuildArgs(self, logger=None):
+        """
+        Return the extra arguments required by the slave for the given build.
+        """
+        build = self.build
+        args = yield super(CharmRecipeBuildBehaviour, self).extraBuildArgs(
+            logger=logger)
+        args["name"] = build.recipe.store_name or build.recipe.name
+        channels = build.channels or {}
+        # We have to remove the security proxy that Zope applies to this
+        # dict, since otherwise we'll be unable to serialise it to XML-RPC.
+        args["channels"] = removeSecurityProxy(channels)
+        args["archives"], args["trusted_keys"] = (
+            yield get_sources_list_for_building(
+                self, build.distro_arch_series, None, logger=logger))
+        if build.recipe.build_path is not None:
+            args["build_path"] = build.recipe.build_path
+        if build.recipe.git_ref is not None:
+            args["git_repository"] = build.recipe.git_repository.git_https_url
+            # "git clone -b" doesn't accept full ref names.  If this becomes
+            # a problem then we could change launchpad-buildd to do "git
+            # clone" followed by "git checkout" instead.
+            if build.recipe.git_path != "HEAD":
+                args["git_path"] = build.recipe.git_ref.name
+        else:
+            raise CannotBuild(
+                "Source repository for ~%s/%s/+charm/%s has been deleted." % (
+                    build.recipe.owner.name, build.recipe.project.name,
+                    build.recipe.name))
+        args["private"] = build.is_private
+        defer.returnValue(args)
+
+    def verifySuccessfulBuild(self):
+        """See `IBuildFarmJobBehaviour`."""
+        # The implementation in BuildFarmJobBehaviourBase checks whether the
+        # target suite is modifiable in the target archive.  However, a
+        # `CharmRecipeBuild`'s archive is a source rather than a target, so
+        # that check does not make sense.  We do, however, refuse to build
+        # for obsolete series.
+        assert self.build.distro_series.status != SeriesStatus.OBSOLETE
diff --git a/lib/lp/charms/tests/test_charmrecipebuildbehaviour.py b/lib/lp/charms/tests/test_charmrecipebuildbehaviour.py
 new file mode 100644
index 0000000..cafabd1
--- /dev/null
+++ b/lib/lp/charms/tests/test_charmrecipebuildbehaviour.py
@@ -0,0 +1,423 @@
+# Copyright 2021 Canonical Ltd.  This software is licensed under the
+# GNU Affero General Public License version 3 (see the file LICENSE).
+
+"""Test charm recipe build behaviour."""
+
+from __future__ import absolute_import, print_function, unicode_literals
+
+__metaclass__ = type
+
+import os.path
+
+from pymacaroons import Macaroon
+from testtools import ExpectedException
+from testtools.matchers import (
+    Equals,
+    Is,
+    IsInstance,
+    MatchesDict,
+    MatchesListwise,
+    )
+from testtools.twistedsupport import (
+    AsynchronousDeferredRunTestForBrokenTwisted,
+    )
+import transaction
+from twisted.internet import defer
+from zope.component import getUtility
+from zope.proxy import isProxy
+from zope.security.proxy import removeSecurityProxy
+
+from lp.app.enums import InformationType
+from lp.archivepublisher.interfaces.archivegpgsigningkey import (
+    IArchiveGPGSigningKey,
+    )
+from lp.buildmaster.enums import (
+    BuildBaseImageType,
+    BuildStatus,
+    )
+from lp.buildmaster.interfaces.builder import CannotBuild
+from lp.buildmaster.interfaces.buildfarmjobbehaviour import (
+    IBuildFarmJobBehaviour,
+    )
+from lp.buildmaster.interfaces.processor import IProcessorSet
+from lp.buildmaster.tests.mock_slaves import (
+    MockBuilder,
+    OkSlave,
+    )
+from lp.buildmaster.tests.test_buildfarmjobbehaviour import (
+    TestGetUploadMethodsMixin,
+    TestHandleStatusMixin,
+    TestVerifySuccessfulBuildMixin,
+    )
+from lp.charms.interfaces.charmrecipe import (
+    CHARM_RECIPE_ALLOW_CREATE,
+    CHARM_RECIPE_PRIVATE_FEATURE_FLAG,
+    )
+from lp.charms.model.charmrecipebuildbehaviour import (
+    CharmRecipeBuildBehaviour,
+    )
+from lp.registry.interfaces.series import SeriesStatus
+from lp.services.config import config
+from lp.services.features.testing import FeatureFixture
+from lp.services.log.logger import (
+    BufferLogger,
+    DevNullLogger,
+    )
+from lp.services.statsd.tests import StatsMixin
+from lp.services.webapp import canonical_url
+from lp.soyuz.adapters.archivedependencies import (
+    get_sources_list_for_building,
+    )
+from lp.soyuz.enums import PackagePublishingStatus
+from lp.soyuz.tests.soyuz import Base64KeyMatches
+from lp.testing import TestCaseWithFactory
+from lp.testing.dbuser import dbuser
+from lp.testing.gpgkeys import gpgkeysdir
+from lp.testing.keyserver import InProcessKeyServerFixture
+from lp.testing.layers import LaunchpadZopelessLayer
+
+
+class TestCharmRecipeBuildBehaviourBase(TestCaseWithFactory):
+    layer = LaunchpadZopelessLayer
+
+    def setUp(self):
+        self.useFixture(FeatureFixture({CHARM_RECIPE_ALLOW_CREATE: "on"}))
+        super(TestCharmRecipeBuildBehaviourBase, self).setUp()
+
+    def makeJob(self, distribution=None, with_builder=False, **kwargs):
+        """Create a sample `ICharmRecipeBuildBehaviour`."""
+        if distribution is None:
+            distribution = self.factory.makeDistribution(name="distro")
+        distroseries = self.factory.makeDistroSeries(
+            distribution=distribution, name="unstable")
+        processor = getUtility(IProcessorSet).getByName("386")
+        distroarchseries = self.factory.makeDistroArchSeries(
+            distroseries=distroseries, architecturetag="i386",
+            processor=processor)
+
+        # Taken from test_archivedependencies.py
+        for component_name in ("main", "universe"):
+            self.factory.makeComponentSelection(distroseries, component_name)
+
+        build = self.factory.makeCharmRecipeBuild(
+            distro_arch_series=distroarchseries, name="test-charm", **kwargs)
+        job = IBuildFarmJobBehaviour(build)
+        if with_builder:
+            builder = MockBuilder()
+            builder.processor = processor
+            job.setBuilder(builder, None)
+        return job
+
+
+class TestCharmRecipeBuildBehaviour(TestCharmRecipeBuildBehaviourBase):
+    layer = LaunchpadZopelessLayer
+
+    def test_provides_interface(self):
+        # CharmRecipeBuildBehaviour provides IBuildFarmJobBehaviour.
+        job = CharmRecipeBuildBehaviour(None)
+        self.assertProvides(job, IBuildFarmJobBehaviour)
+
+    def test_adapts_ICharmRecipeBuild(self):
+        # IBuildFarmJobBehaviour adapts an ICharmRecipeBuild.
+        build = self.factory.makeCharmRecipeBuild()
+        job = IBuildFarmJobBehaviour(build)
+        self.assertProvides(job, IBuildFarmJobBehaviour)
+
+    def test_verifyBuildRequest_valid(self):
+        # verifyBuildRequest doesn't raise any exceptions when called with a
+        # valid builder set.
+        job = self.makeJob()
+        lfa = self.factory.makeLibraryFileAlias()
+        transaction.commit()
+        job.build.distro_arch_series.addOrUpdateChroot(lfa)
+        builder = MockBuilder()
+        job.setBuilder(builder, OkSlave())
+        logger = BufferLogger()
+        job.verifyBuildRequest(logger)
+        self.assertEqual("", logger.getLogBuffer())
+
+    def test_verifyBuildRequest_virtual_mismatch(self):
+        # verifyBuildRequest raises on an attempt to build a virtualized
+        # build on a non-virtual builder.
+        job = self.makeJob()
+        lfa = self.factory.makeLibraryFileAlias()
+        transaction.commit()
+        job.build.distro_arch_series.addOrUpdateChroot(lfa)
+        builder = MockBuilder(virtualized=False)
+        job.setBuilder(builder, OkSlave())
+        logger = BufferLogger()
+        e = self.assertRaises(AssertionError, job.verifyBuildRequest, logger)
+        self.assertEqual(
+            "Attempt to build virtual item on a non-virtual builder.", str(e))
+
+    def test_verifyBuildRequest_no_chroot(self):
+        # verifyBuildRequest raises when the DAS has no chroot.
+        job = self.makeJob()
+        builder = MockBuilder()
+        job.setBuilder(builder, OkSlave())
+        logger = BufferLogger()
+        e = self.assertRaises(CannotBuild, job.verifyBuildRequest, logger)
+        self.assertIn("Missing chroot", str(e))
+
+
+class TestAsyncCharmRecipeBuildBehaviour(
+        StatsMixin, TestCharmRecipeBuildBehaviourBase):
+
+    run_tests_with = AsynchronousDeferredRunTestForBrokenTwisted.make_factory(
+        timeout=30)
+
+    def setUp(self):
+        super(TestAsyncCharmRecipeBuildBehaviour, self).setUp()
+        self.setUpStats()
+
+    @defer.inlineCallbacks
+    def test_composeBuildRequest(self):
+        job = self.makeJob(with_builder=True)
+        lfa = self.factory.makeLibraryFileAlias(db_only=True)
+        job.build.distro_arch_series.addOrUpdateChroot(lfa)
+        build_request = yield job.composeBuildRequest(None)
+        self.assertThat(build_request, MatchesListwise([
+            Equals("charm"),
+            Equals(job.build.distro_arch_series),
+            Equals(job.build.pocket),
+            Equals({}),
+            IsInstance(dict),
+            ]))
+
+    @defer.inlineCallbacks
+    def test_extraBuildArgs_git(self):
+        # extraBuildArgs returns appropriate arguments if asked to build a
+        # job for a Git branch.
+        [ref] = self.factory.makeGitRefs()
+        job = self.makeJob(git_ref=ref, with_builder=True)
+        expected_archives, expected_trusted_keys = (
+            yield get_sources_list_for_building(
+                job, job.build.distro_arch_series, None))
+        for archive_line in expected_archives:
+            self.assertIn("universe", archive_line)
+        with dbuser(config.builddmaster.dbuser):
+            args = yield job.extraBuildArgs()
+        self.assertThat(args, MatchesDict({
+            "archive_private": Is(False),
+            "archives": Equals(expected_archives),
+            "arch_tag": Equals("i386"),
+            "build_url": Equals(canonical_url(job.build)),
+            "channels": Equals({}),
+            "fast_cleanup": Is(True),
+            "git_repository": Equals(ref.repository.git_https_url),
+            "git_path": Equals(ref.name),
+            "name": Equals("test-charm"),
+            "private": Is(False),
+            "series": Equals("unstable"),
+            "trusted_keys": Equals(expected_trusted_keys),
+            }))
+
+    @defer.inlineCallbacks
+    def test_extraBuildArgs_git_HEAD(self):
+        # extraBuildArgs returns appropriate arguments if asked to build a
+        # job for the default branch in a Launchpad-hosted Git repository.
+        [ref] = self.factory.makeGitRefs()
+        removeSecurityProxy(ref.repository)._default_branch = ref.path
+        job = self.makeJob(
+            git_ref=ref.repository.getRefByPath("HEAD"), with_builder=True)
+        expected_archives, expected_trusted_keys = (
+            yield get_sources_list_for_building(
+                job, job.build.distro_arch_series, None))
+        for archive_line in expected_archives:
+            self.assertIn("universe", archive_line)
+        with dbuser(config.builddmaster.dbuser):
+            args = yield job.extraBuildArgs()
+        self.assertThat(args, MatchesDict({
+            "archive_private": Is(False),
+            "archives": Equals(expected_archives),
+            "arch_tag": Equals("i386"),
+            "build_url": Equals(canonical_url(job.build)),
+            "channels": Equals({}),
+            "fast_cleanup": Is(True),
+            "git_repository": Equals(ref.repository.git_https_url),
+            "name": Equals("test-charm"),
+            "private": Is(False),
+            "series": Equals("unstable"),
+            "trusted_keys": Equals(expected_trusted_keys),
+            }))
+
+    @defer.inlineCallbacks
+    def test_extraBuildArgs_prefers_store_name(self):
+        # For the "name" argument, extraBuildArgs prefers
+        # CharmRecipe.store_name over CharmRecipe.name if the former is set.
+        job = self.makeJob(store_name="something-else", with_builder=True)
+        with dbuser(config.builddmaster.dbuser):
+            args = yield job.extraBuildArgs()
+        self.assertEqual("something-else", args["name"])
+
+    @defer.inlineCallbacks
+    def test_extraBuildArgs_archive_trusted_keys(self):
+        # If the archive has a signing key, extraBuildArgs sends it.
+        yield self.useFixture(InProcessKeyServerFixture()).start()
+        distribution = self.factory.makeDistribution()
+        key_path = os.path.join(gpgkeysdir, "[e-mail]")
+        yield IArchiveGPGSigningKey(distribution.main_archive).setSigningKey(
+            key_path, async_keyserver=True)
+        job = self.makeJob(distribution=distribution, with_builder=True)
+        self.factory.makeBinaryPackagePublishingHistory(
+            distroarchseries=job.build.distro_arch_series,
+            pocket=job.build.pocket, archive=distribution.main_archive,
+            status=PackagePublishingStatus.PUBLISHED)
+        with dbuser(config.builddmaster.dbuser):
+            args = yield job.extraBuildArgs()
+        self.assertThat(args["trusted_keys"], MatchesListwise([
+            Base64KeyMatches("0D57E99656BEFB0897606EE9A022DD1F5001B46D"),
+            ]))
+
+    @defer.inlineCallbacks
+    def test_extraBuildArgs_channels(self):
+        # If the build needs particular channels, extraBuildArgs sends them.
+        job = self.makeJob(channels={"charmcraft": "edge"}, with_builder=True)
+        expected_archives, expected_trusted_keys = (
+            yield get_sources_list_for_building(
+                job, job.build.distro_arch_series, None))
+        with dbuser(config.builddmaster.dbuser):
+            args = yield job.extraBuildArgs()
+        self.assertFalse(isProxy(args["channels"]))
+        self.assertEqual({"charmcraft": "edge"}, args["channels"])
+
+    @defer.inlineCallbacks
+    def test_extraBuildArgs_archives_primary(self):
+        # The build uses the release, security, and updates pockets from the
+        # primary archive.
+        job = self.makeJob(with_builder=True)
+        expected_archives = [
+            "deb %s %s main universe" % (
+                job.archive.archive_url, job.build.distro_series.name),
+            "deb %s %s-security main universe" % (
+                job.archive.archive_url, job.build.distro_series.name),
+            "deb %s %s-updates main universe" % (
+                job.archive.archive_url, job.build.distro_series.name),
+            ]
+        with dbuser(config.builddmaster.dbuser):
+            extra_args = yield job.extraBuildArgs()
+        self.assertEqual(expected_archives, extra_args["archives"])
+
+    @defer.inlineCallbacks
+    def test_extraBuildArgs_build_path(self):
+        # If the recipe specifies a build path, extraBuildArgs sends it.
+        job = self.makeJob(build_path="src", with_builder=True)
+        expected_archives, expected_trusted_keys = (
+            yield get_sources_list_for_building(
+                job, job.build.distro_arch_series, None))
+        with dbuser(config.builddmaster.dbuser):
+            args = yield job.extraBuildArgs()
+        self.assertEqual("src", args["build_path"])
+
+    @defer.inlineCallbacks
+    def test_extraBuildArgs_private(self):
+        # If the recipe is private, extraBuildArgs sends the appropriate
+        # arguments.
+        self.useFixture(FeatureFixture({
+            CHARM_RECIPE_ALLOW_CREATE: "on",
+            CHARM_RECIPE_PRIVATE_FEATURE_FLAG: "on",
+            }))
+        job = self.makeJob(
+            information_type=InformationType.PROPRIETARY, with_builder=True)
+        with dbuser(config.builddmaster.dbuser):
+            args = yield job.extraBuildArgs()
+        self.assertTrue(args["private"])
+
+    @defer.inlineCallbacks
+    def test_composeBuildRequest_git_ref_deleted(self):
+        # If the source Git reference has been deleted, composeBuildRequest
+        # raises CannotBuild.
+        repository = self.factory.makeGitRepository()
+        [ref] = self.factory.makeGitRefs(repository=repository)
+        owner = self.factory.makePerson(name="charm-owner")
+        project = self.factory.makeProduct(name="charm-project")
+        job = self.makeJob(
+            registrant=owner, owner=owner, project=project, git_ref=ref,
+            with_builder=True)
+        repository.removeRefs([ref.path])
+        self.assertIsNone(job.build.recipe.git_ref)
+        expected_exception_msg = (
+            r"Source repository for "
+            r"~charm-owner/charm-project/\+charm/test-charm has been deleted.")
+        with ExpectedException(CannotBuild, expected_exception_msg):
+            yield job.composeBuildRequest(None)
+
+    @defer.inlineCallbacks
+    def test_dispatchBuildToSlave_prefers_lxd(self):
+        job = self.makeJob()
+        builder = MockBuilder()
+        builder.processor = job.build.processor
+        slave = OkSlave()
+        job.setBuilder(builder, slave)
+        chroot_lfa = self.factory.makeLibraryFileAlias(db_only=True)
+        job.build.distro_arch_series.addOrUpdateChroot(
+            chroot_lfa, image_type=BuildBaseImageType.CHROOT)
+        lxd_lfa = self.factory.makeLibraryFileAlias(db_only=True)
+        job.build.distro_arch_series.addOrUpdateChroot(
+            lxd_lfa, image_type=BuildBaseImageType.LXD)
+        yield job.dispatchBuildToSlave(DevNullLogger())
+        self.assertEqual(
+            ("ensurepresent", lxd_lfa.http_url, "", ""), slave.call_log[0])
+        self.assertEqual(1, self.stats_client.incr.call_count)
+        self.assertEqual(
+            self.stats_client.incr.call_args_list[0][0],
+            ("build.count,builder_name={},env=test,"
+             "job_type=CHARMRECIPEBUILD".format(builder.name),))
+
+    @defer.inlineCallbacks
+    def test_dispatchBuildToSlave_falls_back_to_chroot(self):
+        job = self.makeJob()
+        builder = MockBuilder()
+        builder.processor = job.build.processor
+        slave = OkSlave()
+        job.setBuilder(builder, slave)
+        chroot_lfa = self.factory.makeLibraryFileAlias(db_only=True)
+        job.build.distro_arch_series.addOrUpdateChroot(
+            chroot_lfa, image_type=BuildBaseImageType.CHROOT)
+        yield job.dispatchBuildToSlave(DevNullLogger())
+        self.assertEqual(
+            ("ensurepresent", chroot_lfa.http_url, "", ""), slave.call_log[0])
+
+
+class MakeCharmRecipeBuildMixin:
+    """Provide the common makeBuild method returning a queued build."""
+
+    def makeCharmRecipe(self):
+        self.useFixture(FeatureFixture({CHARM_RECIPE_ALLOW_CREATE: "on"}))
+        return self.factory.makeCharmRecipe(
+            store_upload=True, store_name=self.factory.getUniqueUnicode(),
+            store_secrets={"root": Macaroon().serialize()})
+
+    def makeBuild(self):
+        recipe = self.makeCharmRecipe()
+        build = self.factory.makeCharmRecipeBuild(
+            requester=recipe.registrant, recipe=recipe,
+            status=BuildStatus.BUILDING)
+        build.queueBuild()
+        return build
+
+    def makeUnmodifiableBuild(self):
+        recipe = self.makeCharmRecipe()
+        build = self.factory.makeCharmRecipeBuild(
+            requester=recipe.registrant, recipe=recipe,
+            status=BuildStatus.BUILDING)
+        build.distro_series.status = SeriesStatus.OBSOLETE
+        build.queueBuild()
+        return build
+
+
+class TestGetUploadMethodsForCharmRecipeBuild(
+        MakeCharmRecipeBuildMixin, TestGetUploadMethodsMixin,
+        TestCaseWithFactory):
+    """IPackageBuild.getUpload* methods work with charm recipe builds."""
+
+
+class TestVerifySuccessfulBuildForCharmRecipeBuild(
+        MakeCharmRecipeBuildMixin, TestVerifySuccessfulBuildMixin,
+        TestCaseWithFactory):
+    """IBuildFarmJobBehaviour.verifySuccessfulBuild works."""
+
+
+class TestHandleStatusForCharmRecipeBuild(
+        MakeCharmRecipeBuildMixin, TestHandleStatusMixin, TestCaseWithFactory):
+    """IPackageBuild.handleStatus works with charm recipe builds."""