Merge ~cjwatson/launchpad:resubmit-vote-name into launchpad:master
Proposed by
Colin Watson
Status: | Merged |
---|---|
Approved by: | Colin Watson |
Approved revision: | e4a40e3a67853e3dbdf6aff87c2f562593a0950e |
Merge reported by: | Otto Co-Pilot |
Merged at revision: | not available |
Proposed branch: | ~cjwatson/launchpad:resubmit-vote-name |
Merge into: | launchpad:master |
Diff against target: |
51 lines (+6/-5) 3 files modified
lib/canonical/launchpad/icing/css/colours.scss (+1/-1) lib/lp/code/browser/branchmergeproposal.py (+2/-1) lib/lp/code/enums.py (+3/-3) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Thiago F. Pappacena (community) | Approve | ||
Review via email: mp+399648@code.launchpad.net |
Commit message
Rename "Resubmit" vote to "Needs Resubmitting"
Description of the change
Merge proposal submitters often interpret the "Resubmit" vote to mean "I have made the requested changes to this merge proposal and would like to resubmit it for review", whereas in fact it's intended to be cast by a reviewer and means "the idea might be sound but the implementation needs significant rework". Rename it so that it's clearer that it goes with the "Needs Fixing" and "Needs Information" votes.
To post a comment you must log in.
LGTM