Merge ~cjwatson/launchpad:use-getUniqueUnicode into launchpad:master

Proposed by Colin Watson
Status: Merged
Approved by: Colin Watson
Approved revision: 67b8a5ac78232d26033d676d82729b0ac431557c
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~cjwatson/launchpad:use-getUniqueUnicode
Merge into: launchpad:master
Diff against target: 40 lines (+4/-4)
1 file modified
lib/lp/testing/factory.py (+4/-4)
Reviewer Review Type Date Requested Status
Thiago F. Pappacena (community) Approve
Review via email: mp+386919@code.launchpad.net

Commit message

Use getUniqueUnicode() rather than getUniqueString().decode()

Description of the change

This makes Python 3 porting easier, because the intent is clearer.

To post a comment you must log in.
Revision history for this message
Thiago F. Pappacena (pappacena) wrote :

LGTM

review: Approve
Revision history for this message
Otto Co-Pilot (otto-copilot) wrote :

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/lib/lp/testing/factory.py b/lib/lp/testing/factory.py
index 87ca1bc..1a6d4ec 100644
--- a/lib/lp/testing/factory.py
+++ b/lib/lp/testing/factory.py
@@ -1785,7 +1785,7 @@ class BareLaunchpadObjectFactory(ObjectFactory):
1785 if owner is None:1785 if owner is None:
1786 owner = self.makePerson()1786 owner = self.makePerson()
1787 if name is None:1787 if name is None:
1788 name = self.getUniqueString('gitrepository').decode('utf-8')1788 name = self.getUniqueUnicode('gitrepository')
17891789
1790 if target is _DEFAULT:1790 if target is _DEFAULT:
1791 target = self.makeProduct()1791 target = self.makeProduct()
@@ -1824,7 +1824,7 @@ class BareLaunchpadObjectFactory(ObjectFactory):
1824 if repository is None:1824 if repository is None:
1825 repository = self.makeGitRepository(**repository_kwargs)1825 repository = self.makeGitRepository(**repository_kwargs)
1826 if paths is None:1826 if paths is None:
1827 paths = [self.getUniqueString('refs/heads/path').decode('utf-8')]1827 paths = [self.getUniqueUnicode('refs/heads/path')]
1828 refs_info = {1828 refs_info = {
1829 path: {1829 path: {
1830 u"sha1": unicode(1830 u"sha1": unicode(
@@ -1843,7 +1843,7 @@ class BareLaunchpadObjectFactory(ObjectFactory):
1843 if repository_url is None:1843 if repository_url is None:
1844 repository_url = self.getUniqueURL()1844 repository_url = self.getUniqueURL()
1845 if path is None:1845 if path is None:
1846 path = self.getUniqueString('refs/heads/path').decode('utf-8')1846 path = self.getUniqueUnicode('refs/heads/path')
1847 return getUtility(IGitRefRemoteSet).new(repository_url, path)1847 return getUtility(IGitRefRemoteSet).new(repository_url, path)
18481848
1849 def makeGitRule(self, repository=None, ref_pattern=u"refs/heads/*",1849 def makeGitRule(self, repository=None, ref_pattern=u"refs/heads/*",
@@ -3081,7 +3081,7 @@ class BareLaunchpadObjectFactory(ObjectFactory):
3081 distroseries = self.makeSourcePackageRecipeDistroseries()3081 distroseries = self.makeSourcePackageRecipeDistroseries()
30823082
3083 if name is None:3083 if name is None:
3084 name = self.getUniqueString('spr-name').decode('utf8')3084 name = self.getUniqueUnicode('spr-name')
3085 if description is None:3085 if description is None:
3086 description = self.getUniqueString(3086 description = self.getUniqueString(
3087 'spr-description').decode('utf8')3087 'spr-description').decode('utf8')

Subscribers

People subscribed via source and target branches

to status/vote changes: