Merge ~cjwatson/launchpad:use-more-publishing-status-helpers into launchpad:master
- Git
- lp:~cjwatson/launchpad
- use-more-publishing-status-helpers
- Merge into master
Proposed by
Colin Watson
Status: | Merged |
---|---|
Approved by: | Colin Watson |
Approved revision: | 25ba24a6562e5cc9ffd51a865570256a8d32970d |
Merge reported by: | Otto Co-Pilot |
Merged at revision: | not available |
Proposed branch: | ~cjwatson/launchpad:use-more-publishing-status-helpers |
Merge into: | launchpad:master |
Diff against target: |
328 lines (+42/-55) 8 files modified
lib/lp/scripts/garbo.py (+3/-4) lib/lp/soyuz/adapters/overrides.py (+2/-4) lib/lp/soyuz/doc/archive.txt (+18/-20) lib/lp/soyuz/model/archive.py (+1/-2) lib/lp/soyuz/model/distributionsourcepackagecache.py (+5/-7) lib/lp/soyuz/model/distroseriespackagecache.py (+5/-8) lib/lp/soyuz/scripts/initialize_distroseries.py (+2/-4) lib/lp/soyuz/tests/test_archive.py (+6/-6) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ioana Lasc (community) | Approve | ||
Review via email: mp+383710@code.launchpad.net |
Commit message
Use the (in)active_
Description of the change
To post a comment you must log in.
Revision history for this message
Ioana Lasc (ilasc) : | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1 | diff --git a/lib/lp/scripts/garbo.py b/lib/lp/scripts/garbo.py | |||
2 | index e5a9e07..98c4b04 100644 | |||
3 | --- a/lib/lp/scripts/garbo.py | |||
4 | +++ b/lib/lp/scripts/garbo.py | |||
5 | @@ -118,7 +118,7 @@ from lp.services.webhooks.interfaces import IWebhookJobSource | |||
6 | 118 | from lp.services.webhooks.model import WebhookJob | 118 | from lp.services.webhooks.model import WebhookJob |
7 | 119 | from lp.snappy.model.snapbuild import SnapFile | 119 | from lp.snappy.model.snapbuild import SnapFile |
8 | 120 | from lp.snappy.model.snapbuildjob import SnapBuildJobType | 120 | from lp.snappy.model.snapbuildjob import SnapBuildJobType |
10 | 121 | from lp.soyuz.enums import PackagePublishingStatus | 121 | from lp.soyuz.interfaces.publishing import active_publishing_status |
11 | 122 | from lp.soyuz.model.archive import Archive | 122 | from lp.soyuz.model.archive import Archive |
12 | 123 | from lp.soyuz.model.distributionsourcepackagecache import ( | 123 | from lp.soyuz.model.distributionsourcepackagecache import ( |
13 | 124 | DistributionSourcePackageCache, | 124 | DistributionSourcePackageCache, |
14 | @@ -470,9 +470,8 @@ class PopulateDistributionSourcePackageCache(TunableLoop): | |||
15 | 470 | Archive.distributionID, | 470 | Archive.distributionID, |
16 | 471 | SourcePackageName.id, | 471 | SourcePackageName.id, |
17 | 472 | SourcePackageName.name), | 472 | SourcePackageName.name), |
21 | 473 | SourcePackagePublishingHistory.status.is_in(( | 473 | SourcePackagePublishingHistory.status.is_in( |
22 | 474 | PackagePublishingStatus.PENDING, | 474 | active_publishing_status), |
20 | 475 | PackagePublishingStatus.PUBLISHED)), | ||
23 | 476 | SourcePackagePublishingHistory.id > self.last_spph_id) | 475 | SourcePackagePublishingHistory.id > self.last_spph_id) |
24 | 477 | return rows.order_by(SourcePackagePublishingHistory.id) | 476 | return rows.order_by(SourcePackagePublishingHistory.id) |
25 | 478 | 477 | ||
26 | diff --git a/lib/lp/soyuz/adapters/overrides.py b/lib/lp/soyuz/adapters/overrides.py | |||
27 | index 8d585f1..a8d609d 100644 | |||
28 | --- a/lib/lp/soyuz/adapters/overrides.py | |||
29 | +++ b/lib/lp/soyuz/adapters/overrides.py | |||
30 | @@ -37,6 +37,7 @@ from lp.services.database.decoratedresultset import DecoratedResultSet | |||
31 | 37 | from lp.services.database.interfaces import IStore | 37 | from lp.services.database.interfaces import IStore |
32 | 38 | from lp.soyuz.enums import PackagePublishingStatus | 38 | from lp.soyuz.enums import PackagePublishingStatus |
33 | 39 | from lp.soyuz.interfaces.component import IComponentSet | 39 | from lp.soyuz.interfaces.component import IComponentSet |
34 | 40 | from lp.soyuz.interfaces.publishing import active_publishing_status | ||
35 | 40 | from lp.soyuz.model.binarypackagename import BinaryPackageName | 41 | from lp.soyuz.model.binarypackagename import BinaryPackageName |
36 | 41 | from lp.soyuz.model.binarypackagerelease import BinaryPackageRelease | 42 | from lp.soyuz.model.binarypackagerelease import BinaryPackageRelease |
37 | 42 | from lp.soyuz.model.component import Component | 43 | from lp.soyuz.model.component import Component |
38 | @@ -230,10 +231,7 @@ class FromExistingOverridePolicy(BaseOverridePolicy): | |||
39 | 230 | super(FromExistingOverridePolicy, self).__init__(*args, **kwargs) | 231 | super(FromExistingOverridePolicy, self).__init__(*args, **kwargs) |
40 | 231 | 232 | ||
41 | 232 | def getExistingPublishingStatuses(self, include_deleted): | 233 | def getExistingPublishingStatuses(self, include_deleted): |
46 | 233 | status = [ | 234 | status = list(active_publishing_status) |
43 | 234 | PackagePublishingStatus.PENDING, | ||
44 | 235 | PackagePublishingStatus.PUBLISHED, | ||
45 | 236 | ] | ||
47 | 237 | if include_deleted: | 235 | if include_deleted: |
48 | 238 | status.append(PackagePublishingStatus.DELETED) | 236 | status.append(PackagePublishingStatus.DELETED) |
49 | 239 | return status | 237 | return status |
50 | diff --git a/lib/lp/soyuz/doc/archive.txt b/lib/lp/soyuz/doc/archive.txt | |||
51 | index 484b643..e9c2424 100644 | |||
52 | --- a/lib/lp/soyuz/doc/archive.txt | |||
53 | +++ b/lib/lp/soyuz/doc/archive.txt | |||
54 | @@ -250,12 +250,10 @@ excludes architecture-independent duplications which is necessary for | |||
55 | 250 | having correct publication counters and archive size. | 250 | having correct publication counters and archive size. |
56 | 251 | 251 | ||
57 | 252 | >>> from lp.soyuz.enums import PackagePublishingStatus | 252 | >>> from lp.soyuz.enums import PackagePublishingStatus |
64 | 253 | 253 | >>> from lp.soyuz.interfaces.publishing import ( | |
65 | 254 | >>> active_status = [PackagePublishingStatus.PENDING, | 254 | ... active_publishing_status, |
66 | 255 | ... PackagePublishingStatus.PUBLISHED] | 255 | ... inactive_publishing_status, |
67 | 256 | 256 | ... ) | |
62 | 257 | >>> inactive_status = [PackagePublishingStatus.SUPERSEDED, | ||
63 | 258 | ... PackagePublishingStatus.DELETED] | ||
68 | 259 | 257 | ||
69 | 260 | >>> warty = cprov_archive.distribution['warty'] | 258 | >>> warty = cprov_archive.distribution['warty'] |
70 | 261 | >>> hoary = cprov_archive.distribution['hoary'] | 259 | >>> hoary = cprov_archive.distribution['hoary'] |
71 | @@ -365,19 +363,19 @@ Both methods support 'status' filter: | |||
72 | 365 | 4 | 363 | 4 |
73 | 366 | 364 | ||
74 | 367 | >>> cprov_archive.getPublishedOnDiskBinaries( | 365 | >>> cprov_archive.getPublishedOnDiskBinaries( |
76 | 368 | ... status=active_status).count() | 366 | ... status=active_publishing_status).count() |
77 | 369 | 3 | 367 | 3 |
78 | 370 | 368 | ||
79 | 371 | >>> cprov_archive.getAllPublishedBinaries( | 369 | >>> cprov_archive.getAllPublishedBinaries( |
81 | 372 | ... status=active_status).count() | 370 | ... status=active_publishing_status).count() |
82 | 373 | 4 | 371 | 4 |
83 | 374 | 372 | ||
84 | 375 | >>> cprov_archive.getPublishedOnDiskBinaries( | 373 | >>> cprov_archive.getPublishedOnDiskBinaries( |
86 | 376 | ... status=inactive_status).count() | 374 | ... status=inactive_publishing_status).count() |
87 | 377 | 0 | 375 | 0 |
88 | 378 | 376 | ||
89 | 379 | >>> cprov_archive.getAllPublishedBinaries( | 377 | >>> cprov_archive.getAllPublishedBinaries( |
91 | 380 | ... status=inactive_status).count() | 378 | ... status=inactive_publishing_status).count() |
92 | 381 | 0 | 379 | 0 |
93 | 382 | 380 | ||
94 | 383 | Using 'distroarchseries' filter: | 381 | Using 'distroarchseries' filter: |
95 | @@ -429,44 +427,44 @@ Using 'pocket' filter: | |||
96 | 429 | Associating 'name' and 'status' filters: | 427 | Associating 'name' and 'status' filters: |
97 | 430 | 428 | ||
98 | 431 | >>> status_lookup = cprov_archive.getPublishedOnDiskBinaries( | 429 | >>> status_lookup = cprov_archive.getPublishedOnDiskBinaries( |
100 | 432 | ... name=u'pmount', status=active_status) | 430 | ... name=u'pmount', status=active_publishing_status) |
101 | 433 | >>> status_lookup.count() | 431 | >>> status_lookup.count() |
102 | 434 | 1 | 432 | 1 |
103 | 435 | 433 | ||
104 | 436 | >>> status_lookup = cprov_archive.getAllPublishedBinaries( | 434 | >>> status_lookup = cprov_archive.getAllPublishedBinaries( |
106 | 437 | ... name=u'pmount', status=active_status) | 435 | ... name=u'pmount', status=active_publishing_status) |
107 | 438 | >>> status_lookup.count() | 436 | >>> status_lookup.count() |
108 | 439 | 2 | 437 | 2 |
109 | 440 | 438 | ||
110 | 441 | >>> status_lookup = cprov_archive.getPublishedOnDiskBinaries( | 439 | >>> status_lookup = cprov_archive.getPublishedOnDiskBinaries( |
112 | 442 | ... name=u'foo', status=active_status) | 440 | ... name=u'foo', status=active_publishing_status) |
113 | 443 | >>> status_lookup.count() | 441 | >>> status_lookup.count() |
114 | 444 | 0 | 442 | 0 |
115 | 445 | 443 | ||
116 | 446 | >>> status_lookup = cprov_archive.getAllPublishedBinaries( | 444 | >>> status_lookup = cprov_archive.getAllPublishedBinaries( |
118 | 447 | ... name=u'foo', status=active_status) | 445 | ... name=u'foo', status=active_publishing_status) |
119 | 448 | >>> status_lookup.count() | 446 | >>> status_lookup.count() |
120 | 449 | 0 | 447 | 0 |
121 | 450 | 448 | ||
122 | 451 | Associating 'name', 'version' and 'status' filters: | 449 | Associating 'name', 'version' and 'status' filters: |
123 | 452 | 450 | ||
124 | 453 | >>> status_lookup = cprov_archive.getPublishedOnDiskBinaries( | 451 | >>> status_lookup = cprov_archive.getPublishedOnDiskBinaries( |
126 | 454 | ... name=u'pmount', version='0.1-1', status=active_status) | 452 | ... name=u'pmount', version='0.1-1', status=active_publishing_status) |
127 | 455 | >>> status_lookup.count() | 453 | >>> status_lookup.count() |
128 | 456 | 1 | 454 | 1 |
129 | 457 | 455 | ||
130 | 458 | >>> status_lookup = cprov_archive.getAllPublishedBinaries( | 456 | >>> status_lookup = cprov_archive.getAllPublishedBinaries( |
132 | 459 | ... name=u'pmount', version='0.1-1', status=active_status) | 457 | ... name=u'pmount', version='0.1-1', status=active_publishing_status) |
133 | 460 | >>> status_lookup.count() | 458 | >>> status_lookup.count() |
134 | 461 | 2 | 459 | 2 |
135 | 462 | 460 | ||
136 | 463 | >>> status_lookup = cprov_archive.getPublishedOnDiskBinaries( | 461 | >>> status_lookup = cprov_archive.getPublishedOnDiskBinaries( |
138 | 464 | ... name=u'pmount', version='666', status=active_status) | 462 | ... name=u'pmount', version='666', status=active_publishing_status) |
139 | 465 | >>> status_lookup.count() | 463 | >>> status_lookup.count() |
140 | 466 | 0 | 464 | 0 |
141 | 467 | 465 | ||
142 | 468 | >>> status_lookup = cprov_archive.getAllPublishedBinaries( | 466 | >>> status_lookup = cprov_archive.getAllPublishedBinaries( |
144 | 469 | ... name=u'pmount', version='666', status=active_status) | 467 | ... name=u'pmount', version='666', status=active_publishing_status) |
145 | 470 | >>> status_lookup.count() | 468 | >>> status_lookup.count() |
146 | 471 | 0 | 469 | 0 |
147 | 472 | 470 | ||
148 | @@ -475,14 +473,14 @@ and 'exact_match' flag: | |||
149 | 475 | 473 | ||
150 | 476 | >>> status_lookup = cprov_archive.getAllPublishedBinaries( | 474 | >>> status_lookup = cprov_archive.getAllPublishedBinaries( |
151 | 477 | ... name=u'pmount', version='0.1-1', distroarchseries=warty_i386, | 475 | ... name=u'pmount', version='0.1-1', distroarchseries=warty_i386, |
153 | 478 | ... status=active_status, exact_match=True) | 476 | ... status=active_publishing_status, exact_match=True) |
154 | 479 | >>> status_lookup.count() | 477 | >>> status_lookup.count() |
155 | 480 | 1 | 478 | 1 |
156 | 481 | 479 | ||
157 | 482 | >>> status_lookup = cprov_archive.getAllPublishedBinaries( | 480 | >>> status_lookup = cprov_archive.getAllPublishedBinaries( |
158 | 483 | ... name=u'pmount', version='0.1-1', | 481 | ... name=u'pmount', version='0.1-1', |
159 | 484 | ... distroarchseries=[warty_i386, warty_hppa], | 482 | ... distroarchseries=[warty_i386, warty_hppa], |
161 | 485 | ... status=active_status, exact_match=True) | 483 | ... status=active_publishing_status, exact_match=True) |
162 | 486 | >>> status_lookup.count() | 484 | >>> status_lookup.count() |
163 | 487 | 2 | 485 | 2 |
164 | 488 | 486 | ||
165 | diff --git a/lib/lp/soyuz/model/archive.py b/lib/lp/soyuz/model/archive.py | |||
166 | index 6e430ec..a693166 100644 | |||
167 | --- a/lib/lp/soyuz/model/archive.py | |||
168 | +++ b/lib/lp/soyuz/model/archive.py | |||
169 | @@ -1915,8 +1915,7 @@ class Archive(SQLBase): | |||
170 | 1915 | # publication. | 1915 | # publication. |
171 | 1916 | published_sources = from_archive.getPublishedSources( | 1916 | published_sources = from_archive.getPublishedSources( |
172 | 1917 | name=name, distroseries=from_series_obj, exact_match=True, | 1917 | name=name, distroseries=from_series_obj, exact_match=True, |
175 | 1918 | status=(PackagePublishingStatus.PUBLISHED, | 1918 | status=active_publishing_status) |
174 | 1919 | PackagePublishingStatus.PENDING)) | ||
176 | 1920 | first_source = published_sources.first() | 1919 | first_source = published_sources.first() |
177 | 1921 | if first_source is not None: | 1920 | if first_source is not None: |
178 | 1922 | sources.append(first_source) | 1921 | sources.append(first_source) |
179 | diff --git a/lib/lp/soyuz/model/distributionsourcepackagecache.py b/lib/lp/soyuz/model/distributionsourcepackagecache.py | |||
180 | index 1fe14a3..c68f71f 100644 | |||
181 | --- a/lib/lp/soyuz/model/distributionsourcepackagecache.py | |||
182 | +++ b/lib/lp/soyuz/model/distributionsourcepackagecache.py | |||
183 | @@ -23,10 +23,10 @@ from lp.services.database import bulk | |||
184 | 23 | from lp.services.database.decoratedresultset import DecoratedResultSet | 23 | from lp.services.database.decoratedresultset import DecoratedResultSet |
185 | 24 | from lp.services.database.interfaces import IStore | 24 | from lp.services.database.interfaces import IStore |
186 | 25 | from lp.services.database.sqlbase import SQLBase | 25 | from lp.services.database.sqlbase import SQLBase |
187 | 26 | from lp.soyuz.enums import PackagePublishingStatus | ||
188 | 27 | from lp.soyuz.interfaces.distributionsourcepackagecache import ( | 26 | from lp.soyuz.interfaces.distributionsourcepackagecache import ( |
189 | 28 | IDistributionSourcePackageCache, | 27 | IDistributionSourcePackageCache, |
190 | 29 | ) | 28 | ) |
191 | 29 | from lp.soyuz.interfaces.publishing import active_publishing_status | ||
192 | 30 | from lp.soyuz.model.binarypackagebuild import BinaryPackageBuild | 30 | from lp.soyuz.model.binarypackagebuild import BinaryPackageBuild |
193 | 31 | from lp.soyuz.model.binarypackagename import BinaryPackageName | 31 | from lp.soyuz.model.binarypackagename import BinaryPackageName |
194 | 32 | from lp.soyuz.model.binarypackagerelease import BinaryPackageRelease | 32 | from lp.soyuz.model.binarypackagerelease import BinaryPackageRelease |
195 | @@ -76,9 +76,8 @@ class DistributionSourcePackageCache(SQLBase): | |||
196 | 76 | spn_ids = IStore(SourcePackagePublishingHistory).find( | 76 | spn_ids = IStore(SourcePackagePublishingHistory).find( |
197 | 77 | SourcePackagePublishingHistory.sourcepackagenameID, | 77 | SourcePackagePublishingHistory.sourcepackagenameID, |
198 | 78 | SourcePackagePublishingHistory.archive == archive, | 78 | SourcePackagePublishingHistory.archive == archive, |
202 | 79 | SourcePackagePublishingHistory.status.is_in(( | 79 | SourcePackagePublishingHistory.status.is_in( |
203 | 80 | PackagePublishingStatus.PENDING, | 80 | active_publishing_status)) |
201 | 81 | PackagePublishingStatus.PUBLISHED))) | ||
204 | 82 | return bulk.load(SourcePackageName, spn_ids.config(distinct=True)) | 81 | return bulk.load(SourcePackageName, spn_ids.config(distinct=True)) |
205 | 83 | 82 | ||
206 | 84 | @classmethod | 83 | @classmethod |
207 | @@ -151,9 +150,8 @@ class DistributionSourcePackageCache(SQLBase): | |||
208 | 151 | SourcePackagePublishingHistory.sourcepackagenameID.is_in( | 150 | SourcePackagePublishingHistory.sourcepackagenameID.is_in( |
209 | 152 | [spn.id for spn in sourcepackagenames]), | 151 | [spn.id for spn in sourcepackagenames]), |
210 | 153 | SourcePackagePublishingHistory.archive == archive, | 152 | SourcePackagePublishingHistory.archive == archive, |
214 | 154 | SourcePackagePublishingHistory.status.is_in(( | 153 | SourcePackagePublishingHistory.status.is_in( |
215 | 155 | PackagePublishingStatus.PENDING, | 154 | active_publishing_status), |
213 | 156 | PackagePublishingStatus.PUBLISHED)) | ||
216 | 157 | ).config(distinct=True).order_by(SourcePackageRelease.id)) | 155 | ).config(distinct=True).order_by(SourcePackageRelease.id)) |
217 | 158 | if len(all_sprs) == 0: | 156 | if len(all_sprs) == 0: |
218 | 159 | if log is not None: | 157 | if log is not None: |
219 | diff --git a/lib/lp/soyuz/model/distroseriespackagecache.py b/lib/lp/soyuz/model/distroseriespackagecache.py | |||
220 | index cabf07e..9bccd11 100644 | |||
221 | --- a/lib/lp/soyuz/model/distroseriespackagecache.py | |||
222 | +++ b/lib/lp/soyuz/model/distroseriespackagecache.py | |||
223 | @@ -24,10 +24,10 @@ from zope.interface import implementer | |||
224 | 24 | from lp.services.database import bulk | 24 | from lp.services.database import bulk |
225 | 25 | from lp.services.database.interfaces import IStore | 25 | from lp.services.database.interfaces import IStore |
226 | 26 | from lp.services.database.sqlbase import SQLBase | 26 | from lp.services.database.sqlbase import SQLBase |
227 | 27 | from lp.soyuz.enums import PackagePublishingStatus | ||
228 | 28 | from lp.soyuz.interfaces.distroseriespackagecache import ( | 27 | from lp.soyuz.interfaces.distroseriespackagecache import ( |
229 | 29 | IDistroSeriesPackageCache, | 28 | IDistroSeriesPackageCache, |
230 | 30 | ) | 29 | ) |
231 | 30 | from lp.soyuz.interfaces.publishing import active_publishing_status | ||
232 | 31 | from lp.soyuz.model.binarypackagename import BinaryPackageName | 31 | from lp.soyuz.model.binarypackagename import BinaryPackageName |
233 | 32 | from lp.soyuz.model.binarypackagerelease import BinaryPackageRelease | 32 | from lp.soyuz.model.binarypackagerelease import BinaryPackageRelease |
234 | 33 | from lp.soyuz.model.distroarchseries import DistroArchSeries | 33 | from lp.soyuz.model.distroarchseries import DistroArchSeries |
235 | @@ -61,10 +61,8 @@ class DistroSeriesPackageCache(SQLBase): | |||
236 | 61 | DistroArchSeries.id, tables=[DistroArchSeries], | 61 | DistroArchSeries.id, tables=[DistroArchSeries], |
237 | 62 | where=DistroArchSeries.distroseries == distroseries)), | 62 | where=DistroArchSeries.distroseries == distroseries)), |
238 | 63 | BinaryPackagePublishingHistory.archive == archive, | 63 | BinaryPackagePublishingHistory.archive == archive, |
243 | 64 | BinaryPackagePublishingHistory.status.is_in(( | 64 | BinaryPackagePublishingHistory.status.is_in( |
244 | 65 | PackagePublishingStatus.PENDING, | 65 | active_publishing_status)).config(distinct=True) |
241 | 66 | PackagePublishingStatus.PUBLISHED))).config( | ||
242 | 67 | distinct=True) | ||
245 | 68 | return bulk.load(BinaryPackageName, bpn_ids) | 66 | return bulk.load(BinaryPackageName, bpn_ids) |
246 | 69 | 67 | ||
247 | 70 | @classmethod | 68 | @classmethod |
248 | @@ -134,9 +132,8 @@ class DistroSeriesPackageCache(SQLBase): | |||
249 | 134 | DistroArchSeries.id, tables=[DistroArchSeries], | 132 | DistroArchSeries.id, tables=[DistroArchSeries], |
250 | 135 | where=DistroArchSeries.distroseries == distroseries)), | 133 | where=DistroArchSeries.distroseries == distroseries)), |
251 | 136 | BinaryPackagePublishingHistory.archive == archive, | 134 | BinaryPackagePublishingHistory.archive == archive, |
255 | 137 | BinaryPackagePublishingHistory.status.is_in(( | 135 | BinaryPackagePublishingHistory.status.is_in( |
256 | 138 | PackagePublishingStatus.PENDING, | 136 | active_publishing_status), |
254 | 139 | PackagePublishingStatus.PUBLISHED)) | ||
257 | 140 | ).group_by( | 137 | ).group_by( |
258 | 141 | BinaryPackageRelease.binarypackagenameID, | 138 | BinaryPackageRelease.binarypackagenameID, |
259 | 142 | BinaryPackageRelease.summary, | 139 | BinaryPackageRelease.summary, |
260 | diff --git a/lib/lp/soyuz/scripts/initialize_distroseries.py b/lib/lp/soyuz/scripts/initialize_distroseries.py | |||
261 | index 8ac2150..308ba42 100644 | |||
262 | --- a/lib/lp/soyuz/scripts/initialize_distroseries.py | |||
263 | +++ b/lib/lp/soyuz/scripts/initialize_distroseries.py | |||
264 | @@ -29,7 +29,6 @@ from lp.services.scripts import log | |||
265 | 29 | from lp.soyuz.adapters.packagelocation import PackageLocation | 29 | from lp.soyuz.adapters.packagelocation import PackageLocation |
266 | 30 | from lp.soyuz.enums import ( | 30 | from lp.soyuz.enums import ( |
267 | 31 | ArchivePurpose, | 31 | ArchivePurpose, |
268 | 32 | PackagePublishingStatus, | ||
269 | 33 | PackageUploadStatus, | 32 | PackageUploadStatus, |
270 | 34 | ) | 33 | ) |
271 | 35 | from lp.soyuz.interfaces.archive import ( | 34 | from lp.soyuz.interfaces.archive import ( |
272 | @@ -45,6 +44,7 @@ from lp.soyuz.interfaces.packageset import ( | |||
273 | 45 | IPackagesetSet, | 44 | IPackagesetSet, |
274 | 46 | NoSuchPackageSet, | 45 | NoSuchPackageSet, |
275 | 47 | ) | 46 | ) |
276 | 47 | from lp.soyuz.interfaces.publishing import active_publishing_status | ||
277 | 48 | from lp.soyuz.interfaces.queue import IPackageUploadSet | 48 | from lp.soyuz.interfaces.queue import IPackageUploadSet |
278 | 49 | from lp.soyuz.model.binarypackagebuild import COPY_ARCHIVE_SCORE_PENALTY | 49 | from lp.soyuz.model.binarypackagebuild import COPY_ARCHIVE_SCORE_PENALTY |
279 | 50 | from lp.soyuz.model.packageset import Packageset | 50 | from lp.soyuz.model.packageset import Packageset |
280 | @@ -577,9 +577,7 @@ class InitializeDistroSeries: | |||
281 | 577 | INIT_POCKETS.items()): | 577 | INIT_POCKETS.items()): |
282 | 578 | sources = archive.getPublishedSources( | 578 | sources = archive.getPublishedSources( |
283 | 579 | distroseries=parent, pocket=source_pocket, | 579 | distroseries=parent, pocket=source_pocket, |
287 | 580 | status=(PackagePublishingStatus.PENDING, | 580 | status=active_publishing_status, name=spns) |
285 | 581 | PackagePublishingStatus.PUBLISHED), | ||
286 | 582 | name=spns) | ||
288 | 583 | sources_published.extend(do_copy( | 581 | sources_published.extend(do_copy( |
289 | 584 | sources, target_archive, self.distroseries, | 582 | sources, target_archive, self.distroseries, |
290 | 585 | target_pocket, | 583 | target_pocket, |
291 | diff --git a/lib/lp/soyuz/tests/test_archive.py b/lib/lp/soyuz/tests/test_archive.py | |||
292 | index 8660e70..caef680 100644 | |||
293 | --- a/lib/lp/soyuz/tests/test_archive.py | |||
294 | +++ b/lib/lp/soyuz/tests/test_archive.py | |||
295 | @@ -113,6 +113,10 @@ from lp.soyuz.interfaces.binarypackagebuild import BuildSetStatus | |||
296 | 113 | from lp.soyuz.interfaces.binarypackagename import IBinaryPackageNameSet | 113 | from lp.soyuz.interfaces.binarypackagename import IBinaryPackageNameSet |
297 | 114 | from lp.soyuz.interfaces.component import IComponentSet | 114 | from lp.soyuz.interfaces.component import IComponentSet |
298 | 115 | from lp.soyuz.interfaces.packagecopyjob import IPlainPackageCopyJobSource | 115 | from lp.soyuz.interfaces.packagecopyjob import IPlainPackageCopyJobSource |
299 | 116 | from lp.soyuz.interfaces.publishing import ( | ||
300 | 117 | active_publishing_status, | ||
301 | 118 | inactive_publishing_status, | ||
302 | 119 | ) | ||
303 | 116 | from lp.soyuz.model.archive import ( | 120 | from lp.soyuz.model.archive import ( |
304 | 117 | Archive, | 121 | Archive, |
305 | 118 | validate_ppa, | 122 | validate_ppa, |
306 | @@ -2580,10 +2584,6 @@ class TestGetPublishedSources(TestCaseWithFactory): | |||
307 | 2580 | # publications. | 2584 | # publications. |
308 | 2581 | self.assertEqual(3, cprov_archive.getPublishedSources().count()) | 2585 | self.assertEqual(3, cprov_archive.getPublishedSources().count()) |
309 | 2582 | # Various filters. | 2586 | # Various filters. |
310 | 2583 | active_status = [PackagePublishingStatus.PENDING, | ||
311 | 2584 | PackagePublishingStatus.PUBLISHED] | ||
312 | 2585 | inactive_status = [PackagePublishingStatus.SUPERSEDED, | ||
313 | 2586 | PackagePublishingStatus.DELETED] | ||
314 | 2587 | warty = cprov_archive.distribution['warty'] | 2587 | warty = cprov_archive.distribution['warty'] |
315 | 2588 | hoary = cprov_archive.distribution['hoary'] | 2588 | hoary = cprov_archive.distribution['hoary'] |
316 | 2589 | breezy_autotest = cprov_archive.distribution['breezy-autotest'] | 2589 | breezy_autotest = cprov_archive.distribution['breezy-autotest'] |
317 | @@ -2616,9 +2616,9 @@ class TestGetPublishedSources(TestCaseWithFactory): | |||
318 | 2616 | self.assertEqual(3, cprov_archive.getPublishedSources( | 2616 | self.assertEqual(3, cprov_archive.getPublishedSources( |
319 | 2617 | status=PackagePublishingStatus.PUBLISHED).count()) | 2617 | status=PackagePublishingStatus.PUBLISHED).count()) |
320 | 2618 | self.assertEqual(3, cprov_archive.getPublishedSources( | 2618 | self.assertEqual(3, cprov_archive.getPublishedSources( |
322 | 2619 | status=active_status).count()) | 2619 | status=active_publishing_status).count()) |
323 | 2620 | self.assertEqual(0, cprov_archive.getPublishedSources( | 2620 | self.assertEqual(0, cprov_archive.getPublishedSources( |
325 | 2621 | status=inactive_status).count()) | 2621 | status=inactive_publishing_status).count()) |
326 | 2622 | self.assertEqual(2, cprov_archive.getPublishedSources( | 2622 | self.assertEqual(2, cprov_archive.getPublishedSources( |
327 | 2623 | distroseries=warty).count()) | 2623 | distroseries=warty).count()) |
328 | 2624 | self.assertEqual(0, cprov_archive.getPublishedSources( | 2624 | self.assertEqual(0, cprov_archive.getPublishedSources( |