Merge ~cjwatson/launchpad:simplify-external-translation-messages into launchpad:master
Proposed by
Colin Watson
Status: | Needs review | ||||
---|---|---|---|---|---|
Proposed branch: | ~cjwatson/launchpad:simplify-external-translation-messages | ||||
Merge into: | launchpad:master | ||||
Diff against target: |
31 lines (+1/-12) 1 file modified
lib/lp/translations/model/potmsgset.py (+1/-12) |
||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
William Grant | code | Needs Information | |
Review via email: mp+381540@code.launchpad.net |
Commit message
Simplify POTMsgSet.
Description of the change
There's no obvious point to sorting the results of a subquery and then passing it straight to the IN operator; this seems to be a vestige of earlier code that fetched the result of the subquery into Python. This doesn't seem to make a massive difference (though it's a bit hard to tell due to caching), but it at least simplifies the query plan.
To post a comment you must log in.
It's trying to get the most recent TranslationMessage with each distinct set of translations, not sort the output as such, so this change is likely to cause the result of the subquery and parent query to become orders of magnitude larger. Have you considered that?