Merge ~cjwatson/launchpad-mojo-specs:codeimport-bump-nrpe into launchpad-mojo-specs:master

Proposed by Colin Watson
Status: Merged
Merged at revision: 328138c8c1132112e5edde77b9a7e217b54eac87
Proposed branch: ~cjwatson/launchpad-mojo-specs:codeimport-bump-nrpe
Merge into: launchpad-mojo-specs:master
Diff against target: 46 lines (+5/-3)
3 files modified
lp-codeimport/collect-charms (+1/-1)
lp-codeimport/services (+3/-2)
lp-codeimport/upgrade-charms (+1/-0)
Reviewer Review Type Date Requested Status
Ioana Lasc (community) Approve
Review via email: mp+404117@code.launchpad.net

Commit message

codeimport: Upgrade nrpe to revision 73

Description of the change

We have to set nagios_master everywhere now, otherwise the charm considers itself to be blocked.

To post a comment you must log in.
Revision history for this message
Ioana Lasc (ilasc) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/lp-codeimport/collect-charms b/lp-codeimport/collect-charms
index 73d44dd..f533353 100644
--- a/lp-codeimport/collect-charms
+++ b/lp-codeimport/collect-charms
@@ -2,4 +2,4 @@
2lp-codeimport git+https://git.launchpad.net/~launchpad/lp-codeimport/+git/charm-build-lp-codeimport;revno=build/84590a6865a86b49a249bc3db9e7793f556e89692lp-codeimport git+https://git.launchpad.net/~launchpad/lp-codeimport/+git/charm-build-lp-codeimport;revno=build/84590a6865a86b49a249bc3db9e7793f556e8969
33
4# Subordinates4# Subordinates
5nrpe cs:nrpe-525nrpe cs:nrpe-73
diff --git a/lp-codeimport/services b/lp-codeimport/services
index 3cf072e..1707c1c 100644
--- a/lp-codeimport/services
+++ b/lp-codeimport/services
@@ -59,6 +59,9 @@
59{%- set log_hosts_allow = "" %}59{%- set log_hosts_allow = "" %}
60{%- set nagios_context = "lp-devel-codeimport" %}60{%- set nagios_context = "lp-devel-codeimport" %}
61{%- set nagios_hostgroups = "devel-lp" %}61{%- set nagios_hostgroups = "devel-lp" %}
62{#- The configured nagios_master doesn't have to be real, but it does have
63 to resolve. #}
64{%- set nagios_master = "localhost" %}
62{%- set oops_prefix = "DEVEL" %}65{%- set oops_prefix = "DEVEL" %}
63{%- set scheduler_endpoint = "http://xmlrpc-private.launchpad.test:8087/codeimportscheduler" %}66{%- set scheduler_endpoint = "http://xmlrpc-private.launchpad.test:8087/codeimportscheduler" %}
64{%- endif -%}67{%- endif -%}
@@ -105,9 +108,7 @@ lp-codeimport:
105 options:108 options:
106 hostgroups: "{{ nagios_hostgroups }}"109 hostgroups: "{{ nagios_hostgroups }}"
107 nagios_host_context: "{{ nagios_context }}"110 nagios_host_context: "{{ nagios_context }}"
108{%- if nagios_master %}
109 export_nagios_definitions: true111 export_nagios_definitions: true
110 nagios_master: "{{ nagios_master }}"112 nagios_master: "{{ nagios_master }}"
111{%- endif %}
112 relations:113 relations:
113 - ["nrpe", "lp-codeimport"]114 - ["nrpe", "lp-codeimport"]
diff --git a/lp-codeimport/upgrade-charms b/lp-codeimport/upgrade-charms
index ef477c7..7bdd407 100755
--- a/lp-codeimport/upgrade-charms
+++ b/lp-codeimport/upgrade-charms
@@ -9,6 +9,7 @@ from utils import utils
9juju_services = utils.juju_services()9juju_services = utils.juju_services()
10app_names = [10app_names = [
11 'lp-codeimport',11 'lp-codeimport',
12 'nrpe',
12 ]13 ]
1314
14for app_name in app_names:15for app_name in app_names:

Subscribers

People subscribed via source and target branches