Merge lp:~cjwatson/launchpad-buildd/fix-recipe-depfail into lp:launchpad-buildd
Proposed by
Colin Watson
Status: | Merged |
---|---|
Approved by: | Colin Watson |
Approved revision: | 86 |
Merged at revision: | 86 |
Proposed branch: | lp:~cjwatson/launchpad-buildd/fix-recipe-depfail |
Merge into: | lp:launchpad-buildd |
Diff against target: |
255 lines (+222/-2) 4 files modified
Makefile (+2/-1) debian/changelog (+7/-0) lpbuildd/sourcepackagerecipe.py (+1/-1) lpbuildd/tests/test_sourcepackagerecipe.py (+212/-0) |
To merge this branch: | bzr merge lp:~cjwatson/launchpad-buildd/fix-recipe-depfail |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
William Grant | code | Approve | |
Review via email: mp+189041@code.launchpad.net |
Commit message
Fix dep-wait detection when recipes fail to install build-dependencies.
Description of the change
Fix a crash in the recipe build manager, introduced in launchpad-buildd 116. This slipped through because the recipe build manager was untested, so I wrote a load of test code first.
QA: Try a recipe build with a deliberately unsatisfiable dependency, and make sure it lands in dep-wait.
To post a comment you must log in.