Merge lp:~cjwatson/isitdeployable/xenial into lp:isitdeployable

Proposed by Colin Watson
Status: Merged
Approved by: Colin Watson
Approved revision: 274
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: lp:~cjwatson/isitdeployable/xenial
Merge into: lp:isitdeployable
Diff against target: 93 lines (+11/-8)
6 files modified
Dockerfile (+1/-1)
README (+4/-4)
dependencies.txt (+1/-1)
dependencies.txt.docker (+3/-1)
ols-vms.conf (+1/-1)
requirements.txt (+1/-0)
To merge this branch: bzr merge lp:~cjwatson/isitdeployable/xenial
Reviewer Review Type Date Requested Status
Ricardo Kirkner (community) Approve
Review via email: mp+336858@code.launchpad.net

Commit message

Upgrade to xenial. Install pygit2 using requirements.txt rather than dependencies.txt.

Description of the change

The pygit2 change is required because otherwise cffi tries to write into site-packages at run-time and gets rather confused; and adding python-setuptools and python-wheel is needed because those are Recommends of python-pip in xenial but without them (at least) html5lib fails to install. Otherwise this is pretty trivial, and I've prepared the dependencies PPA appropriately.

Requires https://code.launchpad.net/~cjwatson/isitdeployable-dependencies/pygit2-0.24.2/+merge/336856.

To post a comment you must log in.
Revision history for this message
Ricardo Kirkner (ricardokirkner) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'Dockerfile'
--- Dockerfile 2017-09-12 18:18:08 +0000
+++ Dockerfile 2018-01-30 15:44:22 +0000
@@ -1,4 +1,4 @@
1FROM ubuntu:trusty1FROM ubuntu:xenial
22
3# create non-root user3# create non-root user
4RUN useradd -m -u 1000 ubuntu4RUN useradd -m -u 1000 ubuntu
55
=== modified file 'README'
--- README 2016-09-27 14:31:46 +0000
+++ README 2018-01-30 15:44:22 +0000
@@ -19,15 +19,15 @@
19We'll create a new container specifically for this project to isolate it from19We'll create a new container specifically for this project to isolate it from
20the system and other projects:20the system and other projects:
2121
22 $ sudo lxc-create -t ubuntu -n deployable-trusty -- -r trusty -a amd64 -b $USER22 $ sudo lxc-create -t ubuntu -n deployable-xenial -- -r xenial -a amd64 -b $USER
2323
24Once it's created, lets start the container and log in with your24Once it's created, lets start the container and log in with your
25existing credentials:25existing credentials:
2626
27 $ sudo lxc-start -n deployable-trusty -d27 $ sudo lxc-start -n deployable-xenial -d
28 $ ssh -A deployable-trusty28 $ ssh -A deployable-xenial
2929
30From now on, instructions will assume you're inside the deployable-trusty LXC,30From now on, instructions will assume you're inside the deployable-xenial LXC,
31unless otherwise noted.31unless otherwise noted.
3232
33To set the prerequisites up inside the container, you can run the33To set the prerequisites up inside the container, you can run the
3434
=== modified file 'dependencies.txt'
--- dependencies.txt 2016-09-27 14:31:46 +0000
+++ dependencies.txt 2018-01-30 15:44:22 +0000
@@ -1,5 +1,6 @@
1gettext1gettext
2iso-codes2iso-codes
3libgit2-24
3librsvg2-common4librsvg2-common
4python3-apt5python3-apt
5python3-chardet6python3-chardet
@@ -32,7 +33,6 @@
32python-piston-mini-client33python-piston-mini-client
33python-polib34python-polib
34python-psycopg235python-psycopg2
35python-pygit2
36python-pygooglechart36python-pygooglechart
37python-reportlab37python-reportlab
38python-restrictedpython38python-restrictedpython
3939
=== modified file 'dependencies.txt.docker'
--- dependencies.txt.docker 2017-09-01 14:11:18 +0000
+++ dependencies.txt.docker 2018-01-30 15:44:22 +0000
@@ -1,8 +1,10 @@
1bzr1bzr
2make2make
3libgit2-24
3libpq54libpq5
4openssh-client5openssh-client
5python-paramiko6python-paramiko
6python-pip7python-pip
7python-pygit28python-setuptools
9python-wheel
8ruby-compass10ruby-compass
911
=== modified file 'ols-vms.conf'
--- ols-vms.conf 2017-08-08 14:48:15 +0000
+++ ols-vms.conf 2018-01-30 15:44:22 +0000
@@ -3,7 +3,7 @@
3vm.architecture = amd643vm.architecture = amd64
44
5[isitdeployable]5[isitdeployable]
6vm.release = trusty6vm.release = xenial
7vm.update = True7vm.update = True
8# codetree and pygit28# codetree and pygit2
9apt.sources = ppa:mojo-maintainers/ppa, ppa:ubuntuone/isitdeployable-dependencies9apt.sources = ppa:mojo-maintainers/ppa, ppa:ubuntuone/isitdeployable-dependencies
1010
=== modified file 'requirements.txt'
--- requirements.txt 2018-01-29 15:34:06 +0000
+++ requirements.txt 2018-01-30 15:44:22 +0000
@@ -39,6 +39,7 @@
39Paste==1.7.5.139Paste==1.7.5.1
40psycopg2==2.4.540psycopg2==2.4.5
41pybars==0.0.441pybars==0.0.4
42pygit2==0.24.2
42PyMeta==0.5.043PyMeta==0.5.0
43pyinotify==0.9.344pyinotify==0.9.3
44six==1.10.045six==1.10.0

Subscribers

People subscribed via source and target branches