Merge lp:~cjwatson/isitdeployable/xenial into lp:isitdeployable

Proposed by Colin Watson
Status: Merged
Approved by: Colin Watson
Approved revision: 274
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: lp:~cjwatson/isitdeployable/xenial
Merge into: lp:isitdeployable
Diff against target: 93 lines (+11/-8)
6 files modified
Dockerfile (+1/-1)
README (+4/-4)
dependencies.txt (+1/-1)
dependencies.txt.docker (+3/-1)
ols-vms.conf (+1/-1)
requirements.txt (+1/-0)
To merge this branch: bzr merge lp:~cjwatson/isitdeployable/xenial
Reviewer Review Type Date Requested Status
Ricardo Kirkner (community) Approve
Review via email: mp+336858@code.launchpad.net

Commit message

Upgrade to xenial. Install pygit2 using requirements.txt rather than dependencies.txt.

Description of the change

The pygit2 change is required because otherwise cffi tries to write into site-packages at run-time and gets rather confused; and adding python-setuptools and python-wheel is needed because those are Recommends of python-pip in xenial but without them (at least) html5lib fails to install. Otherwise this is pretty trivial, and I've prepared the dependencies PPA appropriately.

Requires https://code.launchpad.net/~cjwatson/isitdeployable-dependencies/pygit2-0.24.2/+merge/336856.

To post a comment you must log in.
Revision history for this message
Ricardo Kirkner (ricardokirkner) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Dockerfile'
2--- Dockerfile 2017-09-12 18:18:08 +0000
3+++ Dockerfile 2018-01-30 15:44:22 +0000
4@@ -1,4 +1,4 @@
5-FROM ubuntu:trusty
6+FROM ubuntu:xenial
7
8 # create non-root user
9 RUN useradd -m -u 1000 ubuntu
10
11=== modified file 'README'
12--- README 2016-09-27 14:31:46 +0000
13+++ README 2018-01-30 15:44:22 +0000
14@@ -19,15 +19,15 @@
15 We'll create a new container specifically for this project to isolate it from
16 the system and other projects:
17
18- $ sudo lxc-create -t ubuntu -n deployable-trusty -- -r trusty -a amd64 -b $USER
19+ $ sudo lxc-create -t ubuntu -n deployable-xenial -- -r xenial -a amd64 -b $USER
20
21 Once it's created, lets start the container and log in with your
22 existing credentials:
23
24- $ sudo lxc-start -n deployable-trusty -d
25- $ ssh -A deployable-trusty
26+ $ sudo lxc-start -n deployable-xenial -d
27+ $ ssh -A deployable-xenial
28
29-From now on, instructions will assume you're inside the deployable-trusty LXC,
30+From now on, instructions will assume you're inside the deployable-xenial LXC,
31 unless otherwise noted.
32
33 To set the prerequisites up inside the container, you can run the
34
35=== modified file 'dependencies.txt'
36--- dependencies.txt 2016-09-27 14:31:46 +0000
37+++ dependencies.txt 2018-01-30 15:44:22 +0000
38@@ -1,5 +1,6 @@
39 gettext
40 iso-codes
41+libgit2-24
42 librsvg2-common
43 python3-apt
44 python3-chardet
45@@ -32,7 +33,6 @@
46 python-piston-mini-client
47 python-polib
48 python-psycopg2
49-python-pygit2
50 python-pygooglechart
51 python-reportlab
52 python-restrictedpython
53
54=== modified file 'dependencies.txt.docker'
55--- dependencies.txt.docker 2017-09-01 14:11:18 +0000
56+++ dependencies.txt.docker 2018-01-30 15:44:22 +0000
57@@ -1,8 +1,10 @@
58 bzr
59 make
60+libgit2-24
61 libpq5
62 openssh-client
63 python-paramiko
64 python-pip
65-python-pygit2
66+python-setuptools
67+python-wheel
68 ruby-compass
69
70=== modified file 'ols-vms.conf'
71--- ols-vms.conf 2017-08-08 14:48:15 +0000
72+++ ols-vms.conf 2018-01-30 15:44:22 +0000
73@@ -3,7 +3,7 @@
74 vm.architecture = amd64
75
76 [isitdeployable]
77-vm.release = trusty
78+vm.release = xenial
79 vm.update = True
80 # codetree and pygit2
81 apt.sources = ppa:mojo-maintainers/ppa, ppa:ubuntuone/isitdeployable-dependencies
82
83=== modified file 'requirements.txt'
84--- requirements.txt 2018-01-29 15:34:06 +0000
85+++ requirements.txt 2018-01-30 15:44:22 +0000
86@@ -39,6 +39,7 @@
87 Paste==1.7.5.1
88 psycopg2==2.4.5
89 pybars==0.0.4
90+pygit2==0.24.2
91 PyMeta==0.5.0
92 pyinotify==0.9.3
93 six==1.10.0

Subscribers

People subscribed via source and target branches