Merge lp:~cjwatson/frame/cross into lp:frame
Status: | Merged |
---|---|
Approved by: | Daniel d'Andrada |
Approved revision: | 110 |
Merged at revision: | 110 |
Proposed branch: | lp:~cjwatson/frame/cross |
Merge into: | lp:frame |
Diff against target: |
81 lines (+14/-35) 2 files modified
m4/gtest.m4 (+12/-4) m4/xorg-gtest.m4 (+2/-31) |
To merge this branch: | bzr merge lp:~cjwatson/frame/cross |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Daniel d'Andrada (community) | Approve | ||
PS Jenkins bot | continuous-integration | Pending | |
Review via email: mp+137457@code.launchpad.net |
Commit message
Remove _CHECK_GTEST macro, and fix CHECK_GTEST to work correctly when cross-compiling.
Description of the change
Fix cross-building.
Firstly, the _CHECK_GTEST macro appears to be a cloned-and-hacked copy of CHECK_GTEST, and furthermore it's broken: observe that $have_gtest_source is tested but never set. It seems better to delete it in favour of the one that looks more likely to work.
Secondly, AC_CHECK_FILES doesn't work when cross-compiling, and fails hard, exiting the configure script. I chose to replace it with a compiler test: this is slower, but it avoids this problem. Of course, tests can't generally actually be run when cross-building unless you have qemu-user-static support or similar, but it still ought to be possible to perform the build. I've tested that this permits cross-building frame from amd64 to armhf.
From the looks of things, I suspect that these Autoconf macros exist in multiple Canonical projects. If there's an upstream source for them, or if I should submit matching MPs to other projects, please let me know.
Looks ok.