Merge lp:~cjohnston/ubuntu/raring/vagrant/fix-dns into lp:ubuntu/raring/vagrant

Proposed by Chris Johnston
Status: Merged
Merge reported by: Luke Yelavich
Merged at revision: not available
Proposed branch: lp:~cjohnston/ubuntu/raring/vagrant/fix-dns
Merge into: lp:ubuntu/raring/vagrant
Diff against target: 94 lines (+40/-5)
6 files modified
.pc/applied-patches (+1/-0)
debian/changelog (+8/-0)
debian/control (+2/-1)
debian/patches/series (+1/-0)
debian/patches/update_dns.patch (+23/-0)
lib/vagrant/action/vm/sane_defaults.rb (+5/-4)
To merge this branch: bzr merge lp:~cjohnston/ubuntu/raring/vagrant/fix-dns
Reviewer Review Type Date Requested Status
Luke Yelavich (community) Approve
Ubuntu branches Pending
Review via email: mp+144004@code.launchpad.net

Description of the change

* Fix issue where DNS doesn't resolve properly for 12.10. [GH-1176]
    (LP: #1101914)

To post a comment you must log in.
8. By Chris Johnston

Detect Ubuntu's dns proxy (listening on 127.0.1.1) and disables
internal dns proxying. [GH-1176]
(LP: #1101914)

Revision history for this message
Luke Yelavich (themuso) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file '.pc/applied-patches'
--- .pc/applied-patches 2012-01-28 12:36:35 +0000
+++ .pc/applied-patches 2013-01-20 11:40:26 +0000
@@ -1,1 +1,2 @@
101_source_root_path.patch101_source_root_path.patch
2update_dns.patch
23
=== modified file 'debian/changelog'
--- debian/changelog 2012-05-03 17:01:09 +0000
+++ debian/changelog 2013-01-20 11:40:26 +0000
@@ -1,3 +1,11 @@
1vagrant (1.0.3-1ubuntu1) raring; urgency=low
2
3 * Detect Ubuntu's dns proxy (listening on 127.0.1.1) and disables
4 internal dns proxying. [GH-1176]
5 (LP: #1101914)
6
7 -- Chris Johnston <chrisjohnston@ubuntu.com> Sat, 19 Jan 2013 17:40:17 -0500
8
1vagrant (1.0.3-1) unstable; urgency=low9vagrant (1.0.3-1) unstable; urgency=low
210
3 * New upstream release11 * New upstream release
412
=== modified file 'debian/control'
--- debian/control 2012-05-03 17:01:09 +0000
+++ debian/control 2013-01-20 11:40:26 +0000
@@ -1,7 +1,8 @@
1Source: vagrant1Source: vagrant
2Section: admin2Section: admin
3Priority: optional3Priority: optional
4Maintainer: Laurent Bigonville <bigon@debian.org>4Maintainer: Ubuntu MOTU Developers <ubuntu-motu@lists.ubuntu.com>
5XSBC-Original-Maintainer: Laurent Bigonville <bigon@debian.org>
5Build-Depends: debhelper (>= 7.0.50~), gem2deb (>= 0.2.13~), bash-completion6Build-Depends: debhelper (>= 7.0.50~), gem2deb (>= 0.2.13~), bash-completion
6Standards-Version: 3.9.37Standards-Version: 3.9.3
7Vcs-Git: git://anonscm.debian.org/git/collab-maint/vagrant.git8Vcs-Git: git://anonscm.debian.org/git/collab-maint/vagrant.git
89
=== modified file 'debian/patches/series'
--- debian/patches/series 2012-01-28 12:36:35 +0000
+++ debian/patches/series 2013-01-20 11:40:26 +0000
@@ -1,1 +1,2 @@
101_source_root_path.patch101_source_root_path.patch
2update_dns.patch
23
=== added file 'debian/patches/update_dns.patch'
--- debian/patches/update_dns.patch 1970-01-01 00:00:00 +0000
+++ debian/patches/update_dns.patch 2013-01-20 11:40:26 +0000
@@ -0,0 +1,23 @@
1Index: vagrant/lib/vagrant/action/vm/sane_defaults.rb
2===================================================================
3--- vagrant.orig/lib/vagrant/action/vm/sane_defaults.rb 2013-01-19 18:39:05.000000000 -0500
4+++ vagrant/lib/vagrant/action/vm/sane_defaults.rb 2013-01-20 04:01:07.396706592 -0500
5@@ -32,13 +32,14 @@
6 begin
7 contents = File.read("/etc/resolv.conf")
8
9- if contents =~ /^nameserver 127\.0\.0\.1$/
10+ if contents =~ /^nameserver 127\.0\.0\.1$/ or
11+ contents =~ /^nameserver 127\.0\.1\.1$/
12 # The use of both natdnsproxy and natdnshostresolver break on
13- # Ubuntu 12.04 that uses resolvconf with localhost. When used
14+ # Ubuntu 12.04 and 12.10 that uses resolvconf with localhost. When used
15 # VirtualBox will give the client dns server 10.0.2.3, while
16 # not binding to that address itself. Therefore disable this
17- # feature if host uses the resolvconf server 127.0.0.1
18- @logger.info("Disabling DNS proxy since resolv.conf contains 127.0.0.1")
19+ # feature if host uses the resolvconf server 127.0.0.1 or 127.0.1.1
20+ @logger.info("Disabling DNS proxy since resolv.conf contains 127.0.0.1 or 127.0.1.1")
21 enable_dns_proxy = false
22 end
23 rescue Errno::ENOENT; end
024
=== modified file 'lib/vagrant/action/vm/sane_defaults.rb'
--- lib/vagrant/action/vm/sane_defaults.rb 2012-05-03 17:01:09 +0000
+++ lib/vagrant/action/vm/sane_defaults.rb 2013-01-20 11:40:26 +0000
@@ -32,13 +32,14 @@
32 begin32 begin
33 contents = File.read("/etc/resolv.conf")33 contents = File.read("/etc/resolv.conf")
3434
35 if contents =~ /^nameserver 127\.0\.0\.1$/35 if contents =~ /^nameserver 127\.0\.0\.1$/ or
36 contents =~ /^nameserver 127\.0\.1\.1$/
36 # The use of both natdnsproxy and natdnshostresolver break on37 # The use of both natdnsproxy and natdnshostresolver break on
37 # Ubuntu 12.04 that uses resolvconf with localhost. When used38 # Ubuntu 12.04 and 12.10 that uses resolvconf with localhost. When used
38 # VirtualBox will give the client dns server 10.0.2.3, while39 # VirtualBox will give the client dns server 10.0.2.3, while
39 # not binding to that address itself. Therefore disable this40 # not binding to that address itself. Therefore disable this
40 # feature if host uses the resolvconf server 127.0.0.141 # feature if host uses the resolvconf server 127.0.0.1 or 127.0.1.1
41 @logger.info("Disabling DNS proxy since resolv.conf contains 127.0.0.1")42 @logger.info("Disabling DNS proxy since resolv.conf contains 127.0.0.1 or 127.0.1.1")
42 enable_dns_proxy = false43 enable_dns_proxy = false
43 end44 end
44 rescue Errno::ENOENT; end45 rescue Errno::ENOENT; end

Subscribers

People subscribed via source and target branches