Merge lp:~cjohnston/ubuntu/raring/vagrant/fix-dns into lp:ubuntu/raring/vagrant

Proposed by Chris Johnston
Status: Merged
Merge reported by: Luke Yelavich
Merged at revision: not available
Proposed branch: lp:~cjohnston/ubuntu/raring/vagrant/fix-dns
Merge into: lp:ubuntu/raring/vagrant
Diff against target: 94 lines (+40/-5)
6 files modified
.pc/applied-patches (+1/-0)
debian/changelog (+8/-0)
debian/control (+2/-1)
debian/patches/series (+1/-0)
debian/patches/update_dns.patch (+23/-0)
lib/vagrant/action/vm/sane_defaults.rb (+5/-4)
To merge this branch: bzr merge lp:~cjohnston/ubuntu/raring/vagrant/fix-dns
Reviewer Review Type Date Requested Status
Luke Yelavich (community) Approve
Ubuntu branches Pending
Review via email: mp+144004@code.launchpad.net

Description of the change

* Fix issue where DNS doesn't resolve properly for 12.10. [GH-1176]
    (LP: #1101914)

To post a comment you must log in.
8. By Chris Johnston

Detect Ubuntu's dns proxy (listening on 127.0.1.1) and disables
internal dns proxying. [GH-1176]
(LP: #1101914)

Revision history for this message
Luke Yelavich (themuso) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file '.pc/applied-patches'
2--- .pc/applied-patches 2012-01-28 12:36:35 +0000
3+++ .pc/applied-patches 2013-01-20 11:40:26 +0000
4@@ -1,1 +1,2 @@
5 01_source_root_path.patch
6+update_dns.patch
7
8=== modified file 'debian/changelog'
9--- debian/changelog 2012-05-03 17:01:09 +0000
10+++ debian/changelog 2013-01-20 11:40:26 +0000
11@@ -1,3 +1,11 @@
12+vagrant (1.0.3-1ubuntu1) raring; urgency=low
13+
14+ * Detect Ubuntu's dns proxy (listening on 127.0.1.1) and disables
15+ internal dns proxying. [GH-1176]
16+ (LP: #1101914)
17+
18+ -- Chris Johnston <chrisjohnston@ubuntu.com> Sat, 19 Jan 2013 17:40:17 -0500
19+
20 vagrant (1.0.3-1) unstable; urgency=low
21
22 * New upstream release
23
24=== modified file 'debian/control'
25--- debian/control 2012-05-03 17:01:09 +0000
26+++ debian/control 2013-01-20 11:40:26 +0000
27@@ -1,7 +1,8 @@
28 Source: vagrant
29 Section: admin
30 Priority: optional
31-Maintainer: Laurent Bigonville <bigon@debian.org>
32+Maintainer: Ubuntu MOTU Developers <ubuntu-motu@lists.ubuntu.com>
33+XSBC-Original-Maintainer: Laurent Bigonville <bigon@debian.org>
34 Build-Depends: debhelper (>= 7.0.50~), gem2deb (>= 0.2.13~), bash-completion
35 Standards-Version: 3.9.3
36 Vcs-Git: git://anonscm.debian.org/git/collab-maint/vagrant.git
37
38=== modified file 'debian/patches/series'
39--- debian/patches/series 2012-01-28 12:36:35 +0000
40+++ debian/patches/series 2013-01-20 11:40:26 +0000
41@@ -1,1 +1,2 @@
42 01_source_root_path.patch
43+update_dns.patch
44
45=== added file 'debian/patches/update_dns.patch'
46--- debian/patches/update_dns.patch 1970-01-01 00:00:00 +0000
47+++ debian/patches/update_dns.patch 2013-01-20 11:40:26 +0000
48@@ -0,0 +1,23 @@
49+Index: vagrant/lib/vagrant/action/vm/sane_defaults.rb
50+===================================================================
51+--- vagrant.orig/lib/vagrant/action/vm/sane_defaults.rb 2013-01-19 18:39:05.000000000 -0500
52++++ vagrant/lib/vagrant/action/vm/sane_defaults.rb 2013-01-20 04:01:07.396706592 -0500
53+@@ -32,13 +32,14 @@
54+ begin
55+ contents = File.read("/etc/resolv.conf")
56+
57+- if contents =~ /^nameserver 127\.0\.0\.1$/
58++ if contents =~ /^nameserver 127\.0\.0\.1$/ or
59++ contents =~ /^nameserver 127\.0\.1\.1$/
60+ # The use of both natdnsproxy and natdnshostresolver break on
61+- # Ubuntu 12.04 that uses resolvconf with localhost. When used
62++ # Ubuntu 12.04 and 12.10 that uses resolvconf with localhost. When used
63+ # VirtualBox will give the client dns server 10.0.2.3, while
64+ # not binding to that address itself. Therefore disable this
65+- # feature if host uses the resolvconf server 127.0.0.1
66+- @logger.info("Disabling DNS proxy since resolv.conf contains 127.0.0.1")
67++ # feature if host uses the resolvconf server 127.0.0.1 or 127.0.1.1
68++ @logger.info("Disabling DNS proxy since resolv.conf contains 127.0.0.1 or 127.0.1.1")
69+ enable_dns_proxy = false
70+ end
71+ rescue Errno::ENOENT; end
72
73=== modified file 'lib/vagrant/action/vm/sane_defaults.rb'
74--- lib/vagrant/action/vm/sane_defaults.rb 2012-05-03 17:01:09 +0000
75+++ lib/vagrant/action/vm/sane_defaults.rb 2013-01-20 11:40:26 +0000
76@@ -32,13 +32,14 @@
77 begin
78 contents = File.read("/etc/resolv.conf")
79
80- if contents =~ /^nameserver 127\.0\.0\.1$/
81+ if contents =~ /^nameserver 127\.0\.0\.1$/ or
82+ contents =~ /^nameserver 127\.0\.1\.1$/
83 # The use of both natdnsproxy and natdnshostresolver break on
84- # Ubuntu 12.04 that uses resolvconf with localhost. When used
85+ # Ubuntu 12.04 and 12.10 that uses resolvconf with localhost. When used
86 # VirtualBox will give the client dns server 10.0.2.3, while
87 # not binding to that address itself. Therefore disable this
88- # feature if host uses the resolvconf server 127.0.0.1
89- @logger.info("Disabling DNS proxy since resolv.conf contains 127.0.0.1")
90+ # feature if host uses the resolvconf server 127.0.0.1 or 127.0.1.1
91+ @logger.info("Disabling DNS proxy since resolv.conf contains 127.0.0.1 or 127.0.1.1")
92 enable_dns_proxy = false
93 end
94 rescue Errno::ENOENT; end

Subscribers

People subscribed via source and target branches