Merge lp:~cjohnston/ubuntu-community-webthemes/wordpress-design-update into lp:ubuntu-community-webthemes/light-wordpress-theme

Proposed by Chris Johnston
Status: Merged
Approved by: Stas Sușcov
Approved revision: 35
Merged at revision: 59
Proposed branch: lp:~cjohnston/ubuntu-community-webthemes/wordpress-design-update
Merge into: lp:ubuntu-community-webthemes/light-wordpress-theme
Diff against target: 69 lines (+20/-12) (has conflicts)
2 files modified
functions.php (+8/-10)
style.css (+12/-2)
Text conflict in style.css
To merge this branch: bzr merge lp:~cjohnston/ubuntu-community-webthemes/wordpress-design-update
Reviewer Review Type Date Requested Status
Stas Sușcov (community) Approve
Review via email: mp+68368@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Stas Sușcov (sushkov) wrote :

Looks ok to me, except two things:
* The top bar strings have to be available for localisation, I can edit the patch later to fix that if you're ok with it
* The font change might be an issue. Right now the Google Fonts webservice is not offering full characters support for Ubuntu font family (see http://code.google.com/p/google-ajax-apis/issues/detail?id=557 for example). For Romanian language it's an issue, I don't if it's true for other languages.

Thanks.

Revision history for this message
Stas Sușcov (sushkov) wrote :

Merged, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'functions.php'
--- functions.php 2011-03-12 03:58:13 +0000
+++ functions.php 2011-07-19 12:21:43 +0000
@@ -73,15 +73,6 @@
73 'after_title' => '',73 'after_title' => '',
74 'description' => 'Secondary navigation menu.',74 'description' => 'Secondary navigation menu.',
75 ) );75 ) );
76 register_sidebar( array (
77 'name' => 'Top Bar',
78 'id' => 'top-bar-container',
79 'before_widget' => '',
80 'after_widget' => '',
81 'before_title' => '<span class="top-bar-title">',
82 'after_title' => '</span>',
83 'description' => 'Top bar content. Just drag-n-drop a links/menu widget...',
84 ) );
85}76}
8677
87/**78/**
@@ -216,7 +207,14 @@
216 <div id="top-bar">207 <div id="top-bar">
217 <?php if (is_sidebar_active('top-bar-container')): ?>208 <?php if (is_sidebar_active('top-bar-container')): ?>
218 <div class="top-bar-container">209 <div class="top-bar-container">
219 <?php dynamic_sidebar('top-bar-container'); ?>210 <div class="top-bar-container">
211 <ul>
212 <li><a href="http://www.ubuntu.com">Ubuntu.com</a></li>
213 <li><a href="http://www.ubuntu.com/community">Community</a></li>
214 <li><a href="http://www.ubuntu.com/support">Support</a></li>
215 <li><a href="http://www.ubuntu.com/partners">Partners</a></li>
216 </ul>
217 </div>
220 </div>218 </div>
221 <?php endif; ?>219 <?php endif; ?>
222 </div>220 </div>
223221
=== modified file 'style.css'
--- style.css 2011-06-13 13:27:40 +0000
+++ style.css 2011-07-19 12:21:43 +0000
@@ -184,6 +184,7 @@
184/*184/*
185Typography185Typography
186*/186*/
187<<<<<<< TREE
187body { font-family: 'Ubuntu','Bitstream Vera Sans','DejaVu Sans', Tahoma, sans-serif; }188body { font-family: 'Ubuntu','Bitstream Vera Sans','DejaVu Sans', Tahoma, sans-serif; }
188body { color: #333; font-size: 90%; line-height: 1.5; }189body { color: #333; font-size: 90%; line-height: 1.5; }
189h1, h2, h3, h4, h5, h6 { font-weight: normal; color: #772953; }190h1, h2, h3, h4, h5, h6 { font-weight: normal; color: #772953; }
@@ -191,10 +192,19 @@
191h2 { font-size: 160%; margin-bottom: 10px; font-weight: bold; }192h2 { font-size: 160%; margin-bottom: 10px; font-weight: bold; }
192h3 { font-size: 140%; margin-bottom: 10px; }193h3 { font-size: 140%; margin-bottom: 10px; }
193h4 { font-size: 120%; margin-bottom: 10px; }194h4 { font-size: 120%; margin-bottom: 10px; }
195=======
196body { font-family: 'Ubuntubeta', 'Ubuntu','Bitstream Vera Sans','DejaVu Sans', Tahoma, sans-serif; }
197body { color: #333; font-size: 13px; line-height: 1.4; }
198h1, h2, h3, h4, h5, h6 { font-weight: normal; color: #333333; }
199h1 { font-size: 36px; margin-bottom: 0px; line-height: 40px; }
200h2 { font-size: 24px; margin-bottom: 8px; margin-top: 16px; line-height: 28px; }
201h3 { font-size: 16px; margin-bottom: 8px; margin-top: 16px; line-height: 20px; }
202h4 { font-size: 110%; margin-bottom: 0px; }
203>>>>>>> MERGE-SOURCE
194h5 { font-size: 110%; font-weight: bold; margin-bottom: 10px; }204h5 { font-size: 110%; font-weight: bold; margin-bottom: 10px; }
195h6 { font-size: 110%; font-weight: bold; }205h6 { font-size: 110%; font-weight: bold; }
196a, a:active { color: #772953; }206a, a:active { color: #DD4814; }
197a:hover { color: #DD4814; }207a:hover { color: #DD4814; text-decoration: underline; }
198a:visited { color: #777777; }208a:visited { color: #777777; }
199#top-bar { text-align: right; line-height: 20px; font-size: 90%; }209#top-bar { text-align: right; line-height: 20px; font-size: 90%; }
200#top-bar .top-bar-title { display: none; }210#top-bar .top-bar-title { display: none; }

Subscribers

People subscribed via source and target branches