Merge lp:~cjohnston/ubuntu-community-webthemes/wordpress-design-update into lp:ubuntu-community-webthemes/light-wordpress-theme
Proposed by
Chris Johnston
Status: | Merged |
---|---|
Approved by: | Stas Sușcov |
Approved revision: | 35 |
Merged at revision: | 59 |
Proposed branch: | lp:~cjohnston/ubuntu-community-webthemes/wordpress-design-update |
Merge into: | lp:ubuntu-community-webthemes/light-wordpress-theme |
Diff against target: |
69 lines (+20/-12) (has conflicts) 2 files modified
functions.php (+8/-10) style.css (+12/-2) Text conflict in style.css |
To merge this branch: | bzr merge lp:~cjohnston/ubuntu-community-webthemes/wordpress-design-update |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Stas Sușcov (community) | Approve | ||
Review via email:
|
To post a comment you must log in.
Looks ok to me, except two things: code.google. com/p/google- ajax-apis/ issues/ detail? id=557 for example). For Romanian language it's an issue, I don't if it's true for other languages.
* The top bar strings have to be available for localisation, I can edit the patch later to fix that if you're ok with it
* The font change might be an issue. Right now the Google Fonts webservice is not offering full characters support for Ubuntu font family (see http://
Thanks.