Code review comment for lp:~cjohnston/ubuntu-ci-services-itself/ts-ticket-models

Revision history for this message
Ursula Junque (ursinha) wrote :

Hey Chris, only a few notes:

322 + (COMPLETED, "COMPLETED"),

I think this label should be "Completed".

456 +def create_ticket(title="This is my ticket",
457 + description="this is my ticket description",
458 + bug_id='12345', owner='Chris Johnston',
459 + current_workflow_step=200,
460 + status=220, base_image='17'):

Can we use the constants here (and other places that refer to it) instead of the integer, like Ticket.PKG_BUILDING, Ticket.PKG_BUILDING_INPROGRESS?

I think it looks good for now. If we detect these workflow steps/statuses aren't precise enough we can easily add more of them.

« Back to merge proposal