Code review comment for lp:~cjohnston/ubuntu-ci-services-itself/ts-ticket-models

Revision history for this message
Andy Doan (doanac) wrote :

On 12/10/2013 03:18 PM, Chris Johnston wrote:
> An artifact can be two different things. When you upload a source package
> at the initial time of creating a ticket, it is an artifact (it needs to be
> stored somewhere, and we need to be able to tell other parts of the CI
> engine where to look for the source package). As the system goes through
> and does things, there (I assume) will be output files (logs and such,
> maybe videos when using autopilot, etc). These things don't belong to a
> package upload, they belong to a ticket. So, your artifact can either be
> the source package or an output artifact from the CI engine.

So I think this means you don't want/need the
Artifact.soucepackageupload attribute.

If you wanted to know the source package uploads for a subticket you
could still get them with:

  subticket = <something>
  uploads = Artifact.objects.filter(
      ticket_component=subticket, type=Artfifact.SPU)

« Back to merge proposal